Skip to content

[Bug] Fix bug introduced by split RowsDelFiltered profile #4881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
Nov 13, 2020
Merged

[Bug] Fix bug introduced by split RowsDelFiltered profile #4881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions be/src/olap/olap_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,11 @@ struct OlapReaderStatistics {
int64_t rows_key_range_filtered = 0;
int64_t rows_stats_filtered = 0;
int64_t rows_bf_filtered = 0;
int64_t rows_del_filtered = 0;
int64_t rows_conditions_filtered = 0;
// Including the number of rows filtered out according to the Delete information in the Tablet,
// and the number of rows filtered for marked deleted rows under the unique key model.
int64_t rows_del_filtered = 0;
// the number of rows filtered by various column indexes.
int64_t rows_conditions_filtered = 0;

int64_t index_load_ns = 0;

Expand Down
3 changes: 2 additions & 1 deletion be/src/olap/rowset/beta_rowset_reader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ class BetaRowsetReader : public RowsetReader {

RowsetSharedPtr rowset() override { return std::dynamic_pointer_cast<Rowset>(_rowset); }

int64_t filtered_rows() override { return _stats->rows_del_filtered; }
// Return the total number of filtered rows, will be used for validation of schema change
int64_t filtered_rows() override { return _stats->rows_del_filtered + _stats->rows_conditions_filtered; }
Copy link
Contributor

@morningman morningman Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment for this method to notify that this method will be used for validation of schema change task, should be modified carefully.

Copy link
Contributor Author

@xinyiZzz xinyiZzz Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related comment have been added, I will be familiar with the development process again.


private:
BetaRowsetSharedPtr _rowset;
Expand Down