[fix](udf) alias udf skip check enable_java_udf #48843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32575 ms |
TPC-DS: Total hot run time: 192486 ms |
ClickBench: Total hot run time: 31.25 s |
morrySnow
reviewed
Mar 10, 2025
Comment on lines
217
to
219
| if (candidate.stream().anyMatch(builder -> !(builder instanceof AliasUdfBuilder))) { | ||
| FunctionUtil.checkEnableJavaUdfForNereids(); | ||
| } |
Contributor
There was a problem hiding this comment.
we should move this check to org.apache.doris.catalog.FunctionRegistry#findFunctionBuilder(java.lang.String, java.lang.String, java.util.List<?>)
do as below:
we do two round search in candidates list if java udf is disable.
first round we only search other udf.
if no other udf is matched, we do second round search in java udf.
if no java udf is matched yet, we report no function matched.
if some java udfs are matched, we report java udf is disable.
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32548 ms |
TPC-DS: Total hot run time: 195183 ms |
ClickBench: Total hot run time: 31.34 s |
morrySnow
approved these changes
Mar 11, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
924060929
approved these changes
Mar 11, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
if set Config.enable_java_udf = false, execute fe alias function will
throw exception:
```
MySQL root@127.0.0.1:(none)> create global alias function foo3(STRING) with parameter(s) as concat(s, "hello");
Query OK, 0 rows affected
Time: 7.590s
MySQL root@127.0.0.1:(none)> select foo3("tt");
(1105, 'errCode = 2, detailMessage = java_udf has been disabled.')
```
fix this, alias function no check enable_java_udf.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
if set Config.enable_java_udf = false, execute fe alias function will
throw exception:
```
MySQL root@127.0.0.1:(none)> create global alias function foo3(STRING) with parameter(s) as concat(s, "hello");
Query OK, 0 rows affected
Time: 7.590s
MySQL root@127.0.0.1:(none)> select foo3("tt");
(1105, 'errCode = 2, detailMessage = java_udf has been disabled.')
```
fix this, alias function no check enable_java_udf.
16 tasks
yiguolei
pushed a commit
that referenced
this pull request
Mar 14, 2025
dataroaring
pushed a commit
that referenced
this pull request
Mar 20, 2025
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
if set Config.enable_java_udf = false, execute fe alias function will
throw exception:
```
MySQL root@127.0.0.1:(none)> create global alias function foo3(STRING) with parameter(s) as concat(s, "hello");
Query OK, 0 rows affected
Time: 7.590s
MySQL root@127.0.0.1:(none)> select foo3("tt");
(1105, 'errCode = 2, detailMessage = java_udf has been disabled.')
```
fix this, alias function no check enable_java_udf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
if set Config.enable_java_udf = false, execute fe alias function will throw exception:
fix this, alias function no check enable_java_udf.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)