Skip to content

branch-3.0: [fix](udf) alias udf skip check enable_java_udf #48843 #48903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Mar 20, 2025
Merged

branch-3.0: [fix](udf) alias udf skip check enable_java_udf #48843 #48903

dataroaring merged 1 commit into from
Mar 20, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 11, 2025

Cherry-picked from #48843

@yujun777
[fix](udf) alias udf skip check enable_java_udf (#48843)
f9af53c 
if set Config.enable_java_udf = false, execute fe alias function will
throw exception:

```
MySQL root@127.0.0.1:(none)> create global alias function foo3(STRING) with parameter(s) as concat(s, "hello");
Query OK, 0 rows affected
Time: 7.590s
MySQL root@127.0.0.1:(none)> select foo3("tt");
(1105, 'errCode = 2, detailMessage = java_udf has been disabled.')
```

fix this, alias function no check enable_java_udf.
@github-actions github-actions bot requested a review from dataroaring as a code owner March 11, 2025 04:20
@Thearas
Copy link
Contributor

Thearas commented Mar 11, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 11, 2025
@Thearas
Copy link
Contributor

Thearas commented Mar 11, 2025

run buildall

@yujun777
Copy link
Contributor

yujun777 commented Mar 11, 2025

run p0

@yujun777
Copy link
Contributor

yujun777 commented Mar 11, 2025

run performance

@doris-robot
Copy link

doris-robot commented Mar 11, 2025

TPC-H: Total hot run time: 40094 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f9af53c86733a38876c92252e3183b6e84faf46b, data reload: false

------ Round 1 ----------------------------------
q1	17585	6742	6594	6594
q2	2053	175	168	168
q3	10850	1067	1180	1067
q4	10567	719	769	719
q5	7741	2830	2800	2800
q6	223	136	135	135
q7	968	608	609	608
q8	9361	1931	2004	1931
q9	6597	6364	6431	6364
q10	6990	2240	2304	2240
q11	463	269	262	262
q12	393	206	206	206
q13	17813	3003	3083	3003
q14	252	220	228	220
q15	510	465	476	465
q16	677	593	575	575
q17	962	652	580	580
q18	7312	6838	6745	6745
q19	1398	1120	1048	1048
q20	479	203	198	198
q21	3971	3297	3171	3171
q22	1068	995	1009	995
Total cold run time: 108233 ms
Total hot run time: 40094 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6584	6571	6565	6565
q2	326	237	232	232
q3	2884	2748	2897	2748
q4	2053	1794	1769	1769
q5	5760	6065	5780	5780
q6	208	126	131	126
q7	2213	1834	1850	1834
q8	3380	3548	3516	3516
q9	8901	8985	8939	8939
q10	3552	3543	3472	3472
q11	590	510	509	509
q12	813	618	607	607
q13	10415	3181	3134	3134
q14	305	279	279	279
q15	509	476	461	461
q16	679	652	651	651
q17	1848	1630	1619	1619
q18	8243	7758	7714	7714
q19	1630	1398	1443	1398
q20	2060	1851	1875	1851
q21	5519	5349	5217	5217
q22	1165	1066	1040	1040
Total cold run time: 69637 ms
Total hot run time: 59461 ms

@doris-robot
Copy link

doris-robot commented Mar 11, 2025

TPC-DS: Total hot run time: 197125 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f9af53c86733a38876c92252e3183b6e84faf46b, data reload: false

query1	1317	896	880	880
query2	6276	2018	1961	1961
query3	10818	4295	4187	4187
query4	61057	28845	23653	23653
query5	5104	463	448	448
query6	387	177	176	176
query7	5475	310	308	308
query8	307	210	218	210
query9	8718	2636	2610	2610
query10	461	271	261	261
query11	17630	15070	15571	15070
query12	154	106	110	106
query13	1489	444	445	444
query14	10988	6910	6957	6910
query15	195	180	178	178
query16	7145	464	416	416
query17	1151	567	563	563
query18	1810	323	299	299
query19	214	156	159	156
query20	116	108	118	108
query21	209	98	101	98
query22	4873	4641	4701	4641
query23	34717	34552	34272	34272
query24	6174	2922	2990	2922
query25	499	407	417	407
query26	655	176	171	171
query27	1720	362	359	359
query28	3908	2524	2447	2447
query29	700	472	497	472
query30	246	160	166	160
query31	1035	830	828	828
query32	63	59	54	54
query33	456	289	286	286
query34	906	509	534	509
query35	860	729	746	729
query36	1084	941	973	941
query37	112	61	66	61
query38	4149	3978	3996	3978
query39	1507	1473	1466	1466
query40	206	99	98	98
query41	48	50	48	48
query42	118	102	102	102
query43	510	484	474	474
query44	1194	810	798	798
query45	190	167	171	167
query46	1155	748	726	726
query47	2043	1916	1963	1916
query48	470	377	385	377
query49	713	384	421	384
query50	877	432	429	429
query51	7187	7241	7312	7241
query52	105	90	98	90
query53	267	188	197	188
query54	567	464	482	464
query55	89	85	84	84
query56	252	271	273	271
query57	1273	1177	1171	1171
query58	232	215	229	215
query59	3286	3074	2883	2883
query60	289	266	277	266
query61	127	131	153	131
query62	766	681	673	673
query63	214	188	191	188
query64	1474	750	721	721
query65	3222	3280	3150	3150
query66	650	307	317	307
query67	15963	15472	15740	15472
query68	4368	589	580	580
query69	439	267	276	267
query70	1185	1057	1121	1057
query71	316	300	260	260
query72	6053	3995	3916	3916
query73	761	350	357	350
query74	10142	9014	8989	8989
query75	3365	2675	2627	2627
query76	1828	1018	1125	1018
query77	485	276	267	267
query78	10555	9623	9563	9563
query79	1964	590	591	590
query80	1109	420	431	420
query81	538	238	235	235
query82	387	88	85	85
query83	166	143	140	140
query84	276	82	83	82
query85	940	299	289	289
query86	381	305	299	299
query87	4502	4244	4475	4244
query88	3621	2435	2375	2375
query89	418	288	283	283
query90	1903	186	186	186
query91	189	146	168	146
query92	65	50	52	50
query93	2215	551	551	551
query94	719	281	284	281
query95	356	259	259	259
query96	609	290	289	289
query97	3398	3180	3234	3180
query98	208	206	200	200
query99	1549	1268	1290	1268
Total cold run time: 313182 ms
Total hot run time: 197125 ms

@doris-robot
Copy link

doris-robot commented Mar 11, 2025

ClickBench: Total hot run time: 31.68 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f9af53c86733a38876c92252e3183b6e84faf46b, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.23	0.06	0.06
query4	1.62	0.11	0.10
query5	0.52	0.53	0.55
query6	1.13	0.71	0.74
query7	0.02	0.01	0.01
query8	0.03	0.03	0.03
query9	0.57	0.50	0.49
query10	0.55	0.55	0.55
query11	0.15	0.10	0.10
query12	0.15	0.12	0.11
query13	0.61	0.61	0.60
query14	2.85	2.74	2.86
query15	0.90	0.82	0.82
query16	0.37	0.41	0.38
query17	0.99	1.05	1.07
query18	0.23	0.22	0.21
query19	1.89	1.85	2.02
query20	0.02	0.01	0.01
query21	15.37	0.61	0.59
query22	2.56	2.29	2.02
query23	16.98	1.09	0.82
query24	2.95	0.42	1.14
query25	0.25	0.11	0.12
query26	0.45	0.13	0.14
query27	0.04	0.04	0.04
query28	10.92	0.49	0.44
query29	12.59	3.21	3.17
query30	0.24	0.06	0.05
query31	2.87	0.39	0.38
query32	3.23	0.45	0.46
query33	2.92	2.98	3.06
query34	16.96	4.44	4.48
query35	4.53	4.53	4.45
query36	0.68	0.47	0.49
query37	0.10	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 106.96 s
Total hot run time: 31.68 s

dataroaring
dataroaring approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit ba2fbf7 into branch-3.0 Mar 20, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-48843-branch-3.0 branch March 20, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thearas @yujun777 @doris-robot @dataroaring