Skip to content

Conversation

@morrySnow
Copy link
Contributor

What problem does this PR solve?

Related PR: #21727 #14397

Problem Summary:

  1. forgot to copy isChecked flag in LogicalWindow when do deep copy
  2. implement LogicalWindow To PhyscialWindow should not check isChecked flag

This PR:

  1. check deep copy for all plan node
  2. remove check isChecked in LogicalWindow To PhyscialWindow

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow morrySnow added usercase Important user case type label dev/2.1.x dev/3.0.x labels Mar 10, 2025
@morrySnow morrySnow force-pushed the fix_window_deep_copy branch from 2d3752d to bdcaf2a Compare March 10, 2025 08:35
@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32496 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bdcaf2a78deee1f6c55cfc658e1b5d1df55f2a26, data reload: false

------ Round 1 ----------------------------------
q1	17618	5207	5107	5107
q2	2048	297	161	161
q3	10435	1328	716	716
q4	10279	1036	534	534
q5	8282	2431	2354	2354
q6	193	164	141	141
q7	887	741	632	632
q8	9302	1247	1120	1120
q9	5543	4771	4790	4771
q10	6811	2315	1899	1899
q11	480	280	258	258
q12	346	349	215	215
q13	17757	3677	3082	3082
q14	227	231	205	205
q15	560	477	475	475
q16	632	606	575	575
q17	573	870	338	338
q18	6776	6427	6314	6314
q19	1580	948	567	567
q20	319	331	193	193
q21	2888	2117	1883	1883
q22	1061	1045	956	956
Total cold run time: 104597 ms
Total hot run time: 32496 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5211	5146	5164	5146
q2	235	332	225	225
q3	2174	2671	2307	2307
q4	1437	1793	1339	1339
q5	4225	4108	4187	4108
q6	204	165	123	123
q7	1929	1935	1777	1777
q8	2611	2650	2558	2558
q9	7267	7179	7234	7179
q10	2982	3241	2776	2776
q11	585	522	498	498
q12	665	737	588	588
q13	3515	3862	3263	3263
q14	276	282	274	274
q15	525	467	482	467
q16	646	680	633	633
q17	1162	1619	1342	1342
q18	7769	7605	7528	7528
q19	829	829	841	829
q20	1964	2016	1845	1845
q21	5413	4880	4841	4841
q22	1095	1045	1017	1017
Total cold run time: 52719 ms
Total hot run time: 50663 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184743 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bdcaf2a78deee1f6c55cfc658e1b5d1df55f2a26, data reload: false

query1	1007	385	367	367
query2	6528	1921	1897	1897
query3	6788	221	212	212
query4	26315	23531	22960	22960
query5	4417	694	474	474
query6	297	199	186	186
query7	4614	495	301	301
query8	299	246	230	230
query9	8616	2607	2612	2607
query10	457	306	262	262
query11	15407	15113	15006	15006
query12	157	108	113	108
query13	1669	524	417	417
query14	9748	6733	6265	6265
query15	203	182	167	167
query16	7725	620	494	494
query17	1203	716	559	559
query18	1986	416	315	315
query19	194	181	163	163
query20	125	120	113	113
query21	209	122	105	105
query22	4388	4135	4239	4135
query23	33647	33086	32900	32900
query24	7667	2351	2386	2351
query25	523	443	388	388
query26	1237	269	157	157
query27	2107	487	334	334
query28	3931	2429	2416	2416
query29	710	534	440	440
query30	284	215	188	188
query31	924	881	772	772
query32	71	69	60	60
query33	558	358	298	298
query34	785	839	484	484
query35	800	848	735	735
query36	952	967	892	892
query37	117	100	74	74
query38	4227	4225	3984	3984
query39	1453	1424	1391	1391
query40	207	113	103	103
query41	55	54	72	54
query42	115	102	104	102
query43	501	506	458	458
query44	1290	788	798	788
query45	173	166	168	166
query46	833	1021	612	612
query47	1756	1802	1727	1727
query48	380	428	309	309
query49	782	513	414	414
query50	706	722	403	403
query51	4152	4186	4190	4186
query52	114	107	97	97
query53	229	259	188	188
query54	487	507	408	408
query55	87	83	82	82
query56	263	273	271	271
query57	1092	1150	1063	1063
query58	247	249	232	232
query59	2677	2728	2402	2402
query60	274	285	248	248
query61	123	123	114	114
query62	770	719	692	692
query63	219	185	181	181
query64	4257	999	682	682
query65	4402	4360	4381	4360
query66	1070	403	297	297
query67	15749	15429	15449	15429
query68	8844	871	520	520
query69	464	295	255	255
query70	1186	1092	1071	1071
query71	467	298	264	264
query72	5555	3568	3799	3568
query73	815	743	344	344
query74	8983	9161	8636	8636
query75	3878	3182	2712	2712
query76	3591	1193	755	755
query77	788	363	283	283
query78	10101	10189	9417	9417
query79	2333	830	589	589
query80	610	530	437	437
query81	477	252	219	219
query82	705	125	99	99
query83	184	172	167	167
query84	234	95	73	73
query85	777	362	381	362
query86	379	312	303	303
query87	4428	4440	4364	4364
query88	3551	2198	2209	2198
query89	393	308	275	275
query90	1915	217	219	217
query91	144	138	113	113
query92	72	63	56	56
query93	1634	1060	585	585
query94	675	432	307	307
query95	354	268	260	260
query96	493	562	280	280
query97	3326	3436	3262	3262
query98	219	212	211	211
query99	1347	1387	1266	1266
Total cold run time: 274277 ms
Total hot run time: 184743 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.73 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bdcaf2a78deee1f6c55cfc658e1b5d1df55f2a26, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.07
query4	1.62	0.10	0.11
query5	0.56	0.56	0.55
query6	1.20	0.72	0.71
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.59	0.53	0.51
query10	0.58	0.60	0.60
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.61	0.60	0.58
query14	2.75	2.69	2.72
query15	0.95	0.85	0.86
query16	0.38	0.37	0.38
query17	1.06	1.02	1.02
query18	0.22	0.20	0.19
query19	1.91	1.89	2.02
query20	0.01	0.01	0.01
query21	15.36	0.91	0.55
query22	0.76	1.13	0.69
query23	14.97	1.38	0.63
query24	8.83	1.28	0.47
query25	0.48	0.23	0.14
query26	0.63	0.16	0.13
query27	0.05	0.06	0.05
query28	8.80	0.81	0.42
query29	12.53	3.98	3.32
query30	0.25	0.09	0.06
query31	2.82	0.58	0.39
query32	3.23	0.55	0.46
query33	3.02	3.03	3.03
query34	15.84	5.13	4.55
query35	4.59	4.55	4.54
query36	0.65	0.49	0.49
query37	0.10	0.07	0.07
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.16	0.13	0.13
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.48 s
Total hot run time: 30.73 s

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Mar 13, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 5550ce0 into apache:master Mar 13, 2025
25 of 26 checks passed
@morrySnow morrySnow deleted the fix_window_deep_copy branch March 13, 2025 04:22
github-actions bot pushed a commit that referenced this pull request Mar 13, 2025
### What problem does this PR solve?

Related PR: #21727 #14397

Problem Summary:

1. forgot to copy isChecked flag in LogicalWindow when do deep copy
2. implement LogicalWindow To PhyscialWindow should not check isChecked
flag

This PR:
1. check deep copy for all plan node
2. remove check isChecked in LogicalWindow To PhyscialWindow
github-actions bot pushed a commit that referenced this pull request Mar 13, 2025
### What problem does this PR solve?

Related PR: #21727 #14397

Problem Summary:

1. forgot to copy isChecked flag in LogicalWindow when do deep copy
2. implement LogicalWindow To PhyscialWindow should not check isChecked
flag

This PR:
1. check deep copy for all plan node
2. remove check isChecked in LogicalWindow To PhyscialWindow
morrySnow added a commit that referenced this pull request Mar 13, 2025
Related PR: #21727 #14397

Problem Summary:

1. forgot to copy isChecked flag in LogicalWindow when do deep copy
2. implement LogicalWindow To PhyscialWindow should not check isChecked
flag

This PR:
1. check deep copy for all plan node
2. remove check isChecked in LogicalWindow To PhyscialWindow
morrySnow added a commit that referenced this pull request Mar 13, 2025
Related PR: #21727 #14397

Problem Summary:

1. forgot to copy isChecked flag in LogicalWindow when do deep copy
2. implement LogicalWindow To PhyscialWindow should not check isChecked
flag

This PR:
1. check deep copy for all plan node
2. remove check isChecked in LogicalWindow To PhyscialWindow
yiguolei pushed a commit that referenced this pull request Mar 19, 2025
#49014)

Cherry-picked from #48861

Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
dataroaring pushed a commit that referenced this pull request Mar 20, 2025
#49013)

Cherry-picked from #48861

Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request May 15, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
### What problem does this PR solve?

Related PR: apache#21727 apache#14397

Problem Summary:

1. forgot to copy isChecked flag in LogicalWindow when do deep copy
2. implement LogicalWindow To PhyscialWindow should not check isChecked
flag

This PR:
1. check deep copy for all plan node
2. remove check isChecked in LogicalWindow To PhyscialWindow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.5-merged reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants