Skip to content

branch-2.1: [fix](Nereids) deep copy for LogicalWindow is wrong #48861 #49014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Mar 19, 2025
Merged

branch-2.1: [fix](Nereids) deep copy for LogicalWindow is wrong #48861 #49014

yiguolei merged 1 commit into from
Mar 19, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 13, 2025

Cherry-picked from #48861

@github-actions github-actions bot requested a review from yiguolei as a code owner March 13, 2025 04:24
@Thearas
Copy link
Contributor

Thearas commented Mar 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 13, 2025
@Thearas
Copy link
Contributor

Thearas commented Mar 13, 2025

run buildall

@morrySnow
[fix](Nereids) deep copy for LogicalWindow is wrong (#48861)
95f99c1 
Related PR: #21727 #14397

Problem Summary:

1. forgot to copy isChecked flag in LogicalWindow when do deep copy
2. implement LogicalWindow To PhyscialWindow should not check isChecked
flag

This PR:
1. check deep copy for all plan node
2. remove check isChecked in LogicalWindow To PhyscialWindow
@morrySnow morrySnow force-pushed the auto-pick-48861-branch-2.1 branch from 4f60e47 to 95f99c1 Compare March 13, 2025 08:03
@morrySnow
Copy link
Contributor

morrySnow commented Mar 13, 2025

run buildall

@yiguolei yiguolei merged commit a32a7ba into branch-2.1 Mar 19, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-48861-branch-2.1 branch March 19, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thearas @morrySnow @yiguolei @dataroaring