Skip to content

[Feature](function) support year of week #48870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BiteTheDDDDt merged 4 commits into from
Mar 13, 2025
Merged

[Feature](function) support year of week #48870

BiteTheDDDDt merged 4 commits into from
Mar 13, 2025

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Mar 10, 2025 •
edited
Loading

What problem does this PR solve?

support year of week

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 10, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 10, 2025

run buildall

@wm1581066 wm1581066 added usercase Important user case type label dev/3.1.x dev/2.1.x dev/3.0.x labels Mar 11, 2025
@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 11, 2025

run buildall

1 similar comment
@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 11, 2025

run buildall

HappenLee
HappenLee reviewed Mar 11, 2025
View reviewed changes
be/src/vec/functions/date_time_transforms.h Outdated
};

template <typename FromType, typename ToType>
struct Transformer<FromType, ToType, ToYearImpl<FromType>> {
Copy link
Contributor

@HappenLee HappenLee Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here better use inheritance, to reduce the code
struct Transformer<FromType, ToType, ToYearImpl<FromType>> : public TransformerYear<FromType, ToType, ToYearImpl<FromType>>

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 12, 2025

run buildall

HappenLee
HappenLee approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit c46d4e7 into apache:master Mar 13, 2025
24 of 26 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 13, 2025
@BiteTheDDDDt
[Feature](function) support year of week (#48870)
f3420a5 
### What problem does this PR solve?
support year of week

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [] No.
    - [x] Yes. <apache/doris-website#2169>

### Check List (For Reviewer who merge this PR)

- [x] Confirm the release note
- [x] Confirm test cases
- [x] Confirm document
- [x] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot mentioned this pull request Mar 13, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Mar 13, 2025
@BiteTheDDDDt
[Feature](function) support year of week (#48870)
a2c18c8 
### What problem does this PR solve?
support year of week

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [] No.
    - [x] Yes. <apache/doris-website#2169>

### Check List (For Reviewer who merge this PR)

- [x] Confirm the release note
- [x] Confirm test cases
- [x] Confirm document
- [x] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot mentioned this pull request Mar 13, 2025
Merged
yiguolei pushed a commit that referenced this pull request Mar 29, 2025
@github-actions
branch-2.1: [Feature](function) support year of week #48870 (#49012)
1259ee5
dataroaring pushed a commit that referenced this pull request Mar 30, 2025
@github-actions @BiteTheDDDDt
branch-3.0: [Feature](function) support year of week #48870 (#49011)
11ce43f 
Cherry-picked from #48870

Co-authored-by: Pxl <xl@selectdb.com>
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Closed
@yiguolei yiguolei mentioned this pull request May 13, 2025
Closed
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@BiteTheDDDDt @koarz
[Feature](function) support year of week (apache#48870)
48c0ade 
### What problem does this PR solve?
support year of week

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [] No.
    - [x] Yes. <apache/doris-website#2169>

### Check List (For Reviewer who merge this PR)

- [x] Confirm the release note
- [x] Confirm test cases
- [x] Confirm document
- [x] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.10-merged dev/3.0.5-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@BiteTheDDDDt @hello-stephen @HappenLee @zhangstar333 @yiguolei @wm1581066 @dataroaring @morrySnow