Skip to content

branch-3.0: [Feature](function) support year of week #48870 #49011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Mar 30, 2025
Merged

branch-3.0: [Feature](function) support year of week #48870 #49011

dataroaring merged 1 commit into from
Mar 30, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 13, 2025

Cherry-picked from #48870

@BiteTheDDDDt
[Feature](function) support year of week (#48870)
f3420a5 
### What problem does this PR solve?
support year of week

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [] No.
    - [x] Yes. <apache/doris-website#2169>

### Check List (For Reviewer who merge this PR)

- [x] Confirm the release note
- [x] Confirm test cases
- [x] Confirm document
- [x] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot requested a review from dataroaring as a code owner March 13, 2025 03:52
@Thearas
Copy link
Contributor

Thearas commented Mar 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 13, 2025
@Thearas
Copy link
Contributor

Thearas commented Mar 13, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 13, 2025

TPC-H: Total hot run time: 40206 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f3420a536de10249940c8f15e827f4a862954242, data reload: false

------ Round 1 ----------------------------------
q1	17676	6846	6614	6614
q2	2057	169	167	167
q3	10651	1153	1165	1153
q4	10301	732	773	732
q5	7724	2890	2804	2804
q6	221	138	138	138
q7	991	623	625	623
q8	9354	1948	2018	1948
q9	6665	6402	6400	6400
q10	6982	2287	2333	2287
q11	457	260	261	260
q12	408	212	210	210
q13	17792	2965	3010	2965
q14	237	209	209	209
q15	517	462	471	462
q16	663	598	619	598
q17	971	584	540	540
q18	7526	6681	6700	6681
q19	1392	1065	982	982
q20	476	198	204	198
q21	3994	3259	3307	3259
q22	1079	976	1018	976
Total cold run time: 108134 ms
Total hot run time: 40206 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6555	6550	6584	6550
q2	323	234	229	229
q3	2867	2817	2767	2767
q4	1922	1707	1678	1678
q5	5435	5519	5456	5456
q6	205	125	127	125
q7	2123	1693	1681	1681
q8	3244	3412	3440	3412
q9	8616	8506	8600	8506
q10	3440	3404	3434	3404
q11	590	484	485	484
q12	792	564	558	558
q13	9362	3014	2997	2997
q14	285	261	266	261
q15	496	459	440	440
q16	660	626	659	626
q17	1790	1569	1575	1569
q18	7889	7547	7500	7500
q19	1652	1480	1445	1445
q20	2057	1828	1795	1795
q21	5479	5159	5113	5113
q22	1084	1006	1000	1000
Total cold run time: 66866 ms
Total hot run time: 57596 ms

@doris-robot
Copy link

doris-robot commented Mar 13, 2025

TPC-DS: Total hot run time: 191552 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f3420a536de10249940c8f15e827f4a862954242, data reload: false

query1	1014	379	369	369
query2	6511	2116	2001	2001
query3	6705	217	225	217
query4	34043	23443	23538	23443
query5	5185	449	470	449
query6	267	166	170	166
query7	4620	316	314	314
query8	275	226	222	222
query9	9714	2591	2585	2585
query10	506	275	272	272
query11	18341	15598	15423	15423
query12	155	104	105	104
query13	1686	427	415	415
query14	10571	7169	7139	7139
query15	258	170	185	170
query16	7974	480	458	458
query17	1561	593	568	568
query18	2155	303	321	303
query19	386	163	157	157
query20	119	105	114	105
query21	213	104	102	102
query22	4378	4384	4260	4260
query23	34595	33573	33827	33573
query24	11034	2792	2979	2792
query25	674	415	412	412
query26	1196	175	176	175
query27	2519	356	353	353
query28	7572	2421	2425	2421
query29	857	458	457	457
query30	326	165	165	165
query31	1041	800	802	800
query32	105	62	62	62
query33	825	311	319	311
query34	919	501	536	501
query35	878	722	719	719
query36	1121	952	970	952
query37	145	73	72	72
query38	3993	3864	3884	3864
query39	1479	1415	1655	1415
query40	207	107	105	105
query41	54	55	52	52
query42	117	106	108	106
query43	535	490	494	490
query44	1342	795	806	795
query45	191	172	169	169
query46	1163	732	707	707
query47	1967	1844	1844	1844
query48	491	378	390	378
query49	1181	408	405	405
query50	823	415	417	415
query51	7217	7250	7181	7181
query52	104	92	92	92
query53	258	186	193	186
query54	1290	474	481	474
query55	82	85	79	79
query56	278	262	267	262
query57	1240	1110	1108	1108
query58	271	211	249	211
query59	3126	2858	2841	2841
query60	310	293	252	252
query61	112	115	113	113
query62	862	641	681	641
query63	218	192	192	192
query64	5331	695	643	643
query65	3357	3235	3204	3204
query66	1407	323	336	323
query67	15920	15504	15523	15504
query68	4618	584	588	584
query69	454	284	265	265
query70	1187	1134	1120	1120
query71	416	261	266	261
query72	6400	4058	4034	4034
query73	759	356	357	356
query74	10412	8873	9321	8873
query75	3416	2646	2637	2637
query76	2940	1046	1028	1028
query77	390	281	294	281
query78	10547	9711	9604	9604
query79	1094	603	602	602
query80	751	432	434	432
query81	520	237	243	237
query82	1261	93	90	90
query83	235	153	152	152
query84	241	85	79	79
query85	1028	322	294	294
query86	317	317	297	297
query87	4561	4249	4245	4245
query88	3661	2423	2358	2358
query89	404	294	286	286
query90	1857	189	190	189
query91	183	148	159	148
query92	63	51	54	51
query93	1049	561	557	557
query94	787	297	259	259
query95	359	268	257	257
query96	613	288	281	281
query97	3305	3231	3166	3166
query98	216	207	197	197
query99	1519	1284	1274	1274
Total cold run time: 300933 ms
Total hot run time: 191552 ms

@doris-robot
Copy link

doris-robot commented Mar 13, 2025

ClickBench: Total hot run time: 31.07 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f3420a536de10249940c8f15e827f4a862954242, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.02
query3	0.23	0.06	0.07
query4	1.62	0.10	0.10
query5	0.53	0.52	0.52
query6	1.12	0.73	0.72
query7	0.02	0.02	0.01
query8	0.03	0.03	0.03
query9	0.56	0.50	0.48
query10	0.55	0.56	0.55
query11	0.14	0.11	0.11
query12	0.14	0.12	0.11
query13	0.61	0.60	0.60
query14	2.80	2.75	2.75
query15	0.91	0.83	0.83
query16	0.38	0.39	0.37
query17	1.07	1.08	1.09
query18	0.22	0.21	0.22
query19	2.00	1.86	1.99
query20	0.02	0.01	0.01
query21	15.36	0.58	0.58
query22	2.59	2.84	1.52
query23	17.02	0.90	0.78
query24	3.23	1.10	0.12
query25	0.14	0.05	0.11
query26	0.41	0.13	0.14
query27	0.07	0.04	0.04
query28	11.35	0.52	0.45
query29	12.57	3.25	3.24
query30	0.25	0.07	0.06
query31	2.86	0.39	0.38
query32	3.23	0.47	0.46
query33	2.94	3.06	3.07
query34	17.28	4.48	4.47
query35	4.47	4.54	4.51
query36	0.67	0.47	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.97 s
Total hot run time: 31.07 s

@doris-robot
Copy link

doris-robot commented Mar 13, 2025

BE UT Coverage Report

Increment line coverage 55.00% (22/40) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.91% (10164/26125)
Line Coverage 30.33% (86631/285649)
Region Coverage 29.37% (44511/151542)
Branch Coverage 25.89% (22640/87462)

dataroaring
dataroaring approved these changes Mar 30, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 11ce43f into branch-3.0 Mar 30, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-48870-branch-3.0 branch March 30, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @doris-robot @dataroaring @BiteTheDDDDt