Skip to content

[cherry-pick](branch-2.1) Pick "[Fix](compaction) Fix nullptr when executing cold compaction (#48329)" #48886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Mar 20, 2025
Merged

[cherry-pick](branch-2.1) Pick "[Fix](compaction) Fix nullptr when executing cold compaction (#48329)" #48886

yiguolei merged 1 commit into from
Mar 20, 2025

Conversation

@Yukang-Lian
Copy link
Collaborator

@Yukang-Lian Yukang-Lian commented Mar 10, 2025

Pick #48329

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Yukang-Lian Yukang-Lian requested a review from yiguolei as a code owner March 10, 2025 12:48
@Thearas
Copy link
Contributor

Thearas commented Mar 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Yukang-Lian
Copy link
Collaborator Author

Yukang-Lian commented Mar 10, 2025

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 10, 2025
@doris-robot
Copy link

doris-robot commented Mar 10, 2025

BE UT Coverage Report

Increment line coverage 45.45% (5/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 37.09% (9772/26344)
Line Coverage 28.77% (81672/283901)
Region Coverage 27.32% (41785/152965)
Branch Coverage 24.04% (21209/88236)

@yagagagaga yagagagaga mentioned this pull request Mar 11, 2025
Merged
@Yukang-Lian
Copy link
Collaborator Author

Yukang-Lian commented Mar 13, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 13, 2025

BE UT Coverage Report

Increment line coverage 45.45% (5/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 37.31% (9830/26345)
Line Coverage 28.99% (82315/283915)
Region Coverage 27.61% (42231/152967)
Branch Coverage 24.38% (21508/88236)

@Yukang-Lian
Copy link
Collaborator Author

Yukang-Lian commented Mar 14, 2025

run p0

@Yukang-Lian @dataroaring
[Fix](compaction) Fix nullptr when executing cold compaction (apache#…
78768ed 
…48329)

The cold compaction did not set the compaction policy in the initial phase, causing a null pointer exception when logging later. This issue occurs infrequently; if the tablet has previously done any compaction or calculated a compaction score, the compaction policy will be set automatically, allowing cold compaction to run normally. However, if a newly created tablet undergoes cold compaction immediately, this problem will arise. This PR fixes the issue.
@dataroaring
Copy link
Contributor

dataroaring commented Mar 20, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 20, 2025

BE UT Coverage Report

Increment line coverage 45.45% (5/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 37.40% (9851/26343)
Line Coverage 29.07% (82496/283767)
Region Coverage 27.70% (42345/152855)
Branch Coverage 24.44% (21549/88160)

@yiguolei yiguolei merged commit 5ecfee5 into apache:branch-2.1 Mar 20, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@yiguolei yiguolei yiguolei approved these changes

+1 more reviewer

@yagagagaga yagagagaga yagagagaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Yukang-Lian @Thearas @doris-robot @dataroaring @hello-stephen @gavinchou @yiguolei @yagagagaga