Skip to content

[fix](Nereids) fix split part with regex not exist in source string #48895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Mar 11, 2025
Merged

[fix](Nereids) fix split part with regex not exist in source string #48895

morrySnow merged 1 commit into from
Mar 11, 2025

Conversation

@LiBinfeng-01
Copy link
Contributor

@LiBinfeng-01 LiBinfeng-01 commented Mar 11, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

example: select splict_part('abc', ':', 1); would get a 'abc' string in java splict function, but actually in sql semantic it should not

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 11, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Mar 11, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 11, 2025

TPC-H: Total hot run time: 32804 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f87020684c17eac93104ca2c6d86a3e39be2c1e8, data reload: false

------ Round 1 ----------------------------------
q1	17628	5163	5107	5107
q2	2048	286	158	158
q3	10426	1233	744	744
q4	10200	1013	531	531
q5	7527	2372	2364	2364
q6	184	165	133	133
q7	913	743	606	606
q8	9305	1291	1107	1107
q9	5023	4863	4804	4804
q10	6813	2324	1882	1882
q11	467	271	260	260
q12	360	378	227	227
q13	17742	3700	3115	3115
q14	222	225	216	216
q15	543	491	469	469
q16	627	615	607	607
q17	585	846	354	354
q18	6938	6457	6359	6359
q19	1612	953	574	574
q20	320	332	198	198
q21	2945	2156	2022	2022
q22	1065	1036	967	967
Total cold run time: 103493 ms
Total hot run time: 32804 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5263	5194	5160	5160
q2	246	331	235	235
q3	2171	2678	2422	2422
q4	1434	1878	1404	1404
q5	4333	4196	4234	4196
q6	207	169	130	130
q7	1964	1947	1825	1825
q8	3000	2743	2630	2630
q9	7457	7441	7319	7319
q10	3116	3239	2812	2812
q11	577	502	480	480
q12	667	741	585	585
q13	3666	3923	3290	3290
q14	291	297	292	292
q15	518	488	463	463
q16	648	707	658	658
q17	1166	1550	1439	1439
q18	7865	7599	7579	7579
q19	839	856	948	856
q20	1984	2038	1907	1907
q21	5488	4960	4896	4896
q22	1125	1060	1029	1029
Total cold run time: 54025 ms
Total hot run time: 51607 ms

@doris-robot
Copy link

doris-robot commented Mar 11, 2025

TPC-DS: Total hot run time: 191893 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f87020684c17eac93104ca2c6d86a3e39be2c1e8, data reload: false

query1	1438	983	977	977
query2	6449	1909	1883	1883
query3	11038	4357	4535	4357
query4	25872	23784	23250	23250
query5	3881	667	463	463
query6	285	192	187	187
query7	3985	502	288	288
query8	298	256	243	243
query9	8515	2635	2661	2635
query10	463	314	262	262
query11	15505	15057	14833	14833
query12	161	113	104	104
query13	1571	540	422	422
query14	8841	6235	6590	6235
query15	221	192	176	176
query16	7556	641	473	473
query17	1215	740	596	596
query18	2001	424	333	333
query19	207	199	170	170
query20	133	125	117	117
query21	210	126	109	109
query22	4547	4599	4309	4309
query23	34239	33630	33538	33538
query24	7892	2420	2413	2413
query25	512	462	402	402
query26	1213	276	165	165
query27	2331	495	337	337
query28	4325	2461	2441	2441
query29	709	598	458	458
query30	283	226	196	196
query31	934	873	791	791
query32	74	69	67	67
query33	536	357	307	307
query34	787	881	521	521
query35	792	850	759	759
query36	979	1032	908	908
query37	120	107	82	82
query38	4253	4265	4197	4197
query39	1473	1404	1494	1404
query40	224	117	105	105
query41	52	51	53	51
query42	116	104	112	104
query43	512	532	478	478
query44	1337	815	815	815
query45	182	170	166	166
query46	858	1061	641	641
query47	1798	1887	1791	1791
query48	387	434	318	318
query49	798	558	434	434
query50	716	762	424	424
query51	4352	4374	4273	4273
query52	110	110	97	97
query53	244	268	198	198
query54	510	497	434	434
query55	83	82	82	82
query56	278	309	260	260
query57	1160	1209	1101	1101
query58	254	238	228	228
query59	2670	2814	2734	2734
query60	285	311	266	266
query61	119	121	127	121
query62	778	770	668	668
query63	239	196	204	196
query64	4084	1029	678	678
query65	4523	4471	4484	4471
query66	1085	413	322	322
query67	16761	15457	15368	15368
query68	9353	887	508	508
query69	483	315	261	261
query70	1240	1154	1089	1089
query71	456	312	270	270
query72	5199	3633	3742	3633
query73	804	745	357	357
query74	9035	9138	8656	8656
query75	4168	3187	2699	2699
query76	3627	1178	758	758
query77	839	378	383	378
query78	9874	10047	9378	9378
query79	3452	843	592	592
query80	593	532	445	445
query81	498	263	217	217
query82	203	124	96	96
query83	169	169	156	156
query84	289	90	77	77
query85	832	348	306	306
query86	352	298	277	277
query87	4558	4546	4373	4373
query88	2919	2238	2232	2232
query89	425	310	284	284
query90	2169	215	222	215
query91	134	141	106	106
query92	69	62	58	58
query93	2333	1044	571	571
query94	670	403	300	300
query95	356	276	266	266
query96	503	561	272	272
query97	3289	3388	3339	3339
query98	222	212	201	201
query99	1371	1401	1291	1291
Total cold run time: 280843 ms
Total hot run time: 191893 ms

@doris-robot
Copy link

doris-robot commented Mar 11, 2025

ClickBench: Total hot run time: 31.02 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f87020684c17eac93104ca2c6d86a3e39be2c1e8, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.03
query3	0.23	0.07	0.06
query4	1.62	0.10	0.10
query5	0.58	0.54	0.54
query6	1.18	0.73	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.60	0.52	0.53
query10	0.58	0.61	0.57
query11	0.16	0.11	0.11
query12	0.14	0.11	0.11
query13	0.62	0.60	0.60
query14	2.68	2.70	2.68
query15	0.90	0.85	0.84
query16	0.39	0.39	0.38
query17	1.04	1.02	1.03
query18	0.22	0.19	0.20
query19	1.94	1.82	1.97
query20	0.02	0.02	0.01
query21	15.36	0.90	0.56
query22	0.75	1.08	0.64
query23	15.05	1.38	0.60
query24	7.60	0.91	1.07
query25	0.50	0.32	0.18
query26	0.66	0.16	0.14
query27	0.04	0.05	0.05
query28	10.07	0.87	0.43
query29	12.81	4.04	3.37
query30	0.25	0.10	0.07
query31	2.82	0.58	0.39
query32	3.22	0.55	0.46
query33	3.00	3.01	3.12
query34	15.80	5.12	4.51
query35	4.54	4.51	4.56
query36	0.66	0.50	0.48
query37	0.10	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.7 s
Total hot run time: 31.02 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit eec8aed into apache:master Mar 11, 2025
31 of 33 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 11, 2025
[fix](Nereids) fix split part with delim not exist in source string (#…
cb217f7 
…48895)

### What problem does this PR solve?

Related PR: #40441

Problem Summary:

if source string do not contains delim, split_part should return NULL
@github-actions github-actions bot mentioned this pull request Mar 11, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Mar 11, 2025
[fix](Nereids) fix split part with delim not exist in source string (#…
01611cc 
…48895)

### What problem does this PR solve?

Related PR: #40441

Problem Summary:

if source string do not contains delim, split_part should return NULL
@github-actions github-actions bot mentioned this pull request Mar 11, 2025
Merged
yiguolei pushed a commit that referenced this pull request Mar 11, 2025
@github-actions
branch-2.1: [fix](Nereids) fix split part with regex not exist in sou…
2c358a1 
…rce string #48895 (#48910)

Cherry-picked from #48895

Co-authored-by: LiBinfeng <libinfeng@selectdb.com>
dataroaring pushed a commit that referenced this pull request Mar 15, 2025
@github-actions
branch-3.0: [fix](Nereids) fix split part with regex not exist in sou…
cdbb07a 
…rce string #48895 (#48909)

Cherry-picked from #48895

Co-authored-by: LiBinfeng <libinfeng@selectdb.com>
csun5285 pushed a commit to csun5285/doris that referenced this pull request Mar 28, 2025
@morrySnow
[fix](Nereids) fix split part with regex not exist in source string (a…
4868dd1 
…pache#3810)

pick from doris' master apache#48895
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Closed
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@koarz
[fix](Nereids) fix split part with delim not exist in source string (a…
aa27434 
…pache#48895)

### What problem does this PR solve?

Related PR: apache#40441

Problem Summary:

if source string do not contains delim, split_part should return NULL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.5-merged p0_w reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@LiBinfeng-01 @Thearas @doris-robot @starocean999 @morrySnow @yiguolei @dataroaring