Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #48895

…48895)

### What problem does this PR solve?

Related PR: #40441

Problem Summary:

if source string do not contains delim, split_part should return NULL
@github-actions github-actions bot requested a review from dataroaring as a code owner March 11, 2025 06:32
@Thearas
Copy link
Contributor

Thearas commented Mar 11, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 11, 2025
@Thearas
Copy link
Contributor

Thearas commented Mar 11, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39907 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cb217f711f0f60a299697ba3ee034a6caafbc330, data reload: false

------ Round 1 ----------------------------------
q1	17576	6729	6627	6627
q2	2085	169	162	162
q3	10614	1066	1174	1066
q4	10564	693	733	693
q5	7744	2840	2791	2791
q6	221	133	132	132
q7	982	608	600	600
q8	9344	1920	1999	1920
q9	6605	6383	6393	6383
q10	7396	2276	2304	2276
q11	472	258	251	251
q12	407	214	212	212
q13	17805	2966	2983	2966
q14	247	201	211	201
q15	520	477	456	456
q16	675	593	595	593
q17	953	556	557	556
q18	7241	6634	6625	6625
q19	1445	1046	1097	1046
q20	465	206	200	200
q21	4364	3166	3179	3166
q22	1108	985	993	985
Total cold run time: 108833 ms
Total hot run time: 39907 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6563	6640	6545	6545
q2	325	227	229	227
q3	2855	2744	2880	2744
q4	2000	1809	1773	1773
q5	5705	5707	5727	5707
q6	205	131	131	131
q7	2233	1802	1827	1802
q8	3360	3564	3468	3468
q9	8924	8791	8906	8791
q10	3574	3502	3460	3460
q11	592	538	516	516
q12	822	624	596	596
q13	9358	3183	3179	3179
q14	312	273	283	273
q15	517	473	459	459
q16	696	666	635	635
q17	1847	1624	1598	1598
q18	8188	7827	7656	7656
q19	1691	1476	1553	1476
q20	2062	1805	1850	1805
q21	5590	5497	5345	5345
q22	1083	1043	1015	1015
Total cold run time: 68502 ms
Total hot run time: 59201 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197273 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cb217f711f0f60a299697ba3ee034a6caafbc330, data reload: false

query1	1276	906	885	885
query2	6278	2070	2061	2061
query3	10880	4302	4381	4302
query4	60580	29549	23580	23580
query5	5264	461	464	461
query6	395	196	184	184
query7	5457	322	306	306
query8	312	232	223	223
query9	8616	2625	2607	2607
query10	454	271	281	271
query11	17314	15086	15675	15086
query12	170	102	103	102
query13	1405	455	452	452
query14	10332	7525	7542	7525
query15	199	189	178	178
query16	7146	507	482	482
query17	1146	592	592	592
query18	1952	321	320	320
query19	214	162	153	153
query20	117	109	112	109
query21	215	103	102	102
query22	4835	4556	4576	4556
query23	34368	33817	34302	33817
query24	6374	2902	2927	2902
query25	551	421	431	421
query26	657	171	167	167
query27	1751	349	365	349
query28	4236	2467	2423	2423
query29	717	470	443	443
query30	236	162	168	162
query31	999	854	838	838
query32	70	57	57	57
query33	406	295	291	291
query34	917	512	505	505
query35	842	777	734	734
query36	1082	945	987	945
query37	119	73	67	67
query38	4119	4072	3994	3994
query39	1546	1482	1488	1482
query40	211	97	100	97
query41	48	49	51	49
query42	116	98	97	97
query43	525	493	496	493
query44	1158	804	819	804
query45	183	168	163	163
query46	1171	706	741	706
query47	2029	1919	1945	1919
query48	480	394	372	372
query49	716	389	399	389
query50	825	429	442	429
query51	7379	7171	7216	7171
query52	100	89	88	88
query53	254	180	182	180
query54	560	473	464	464
query55	87	87	76	76
query56	282	244	239	239
query57	1333	1170	1178	1170
query58	223	217	216	216
query59	3197	2917	3002	2917
query60	281	256	267	256
query61	108	107	105	105
query62	754	688	667	667
query63	216	182	183	182
query64	1391	652	634	634
query65	3248	3150	3176	3150
query66	715	292	307	292
query67	15922	15651	15428	15428
query68	4015	598	571	571
query69	435	257	258	257
query70	1156	1119	1124	1119
query71	345	269	255	255
query72	6360	4094	3999	3999
query73	757	349	350	349
query74	10146	9262	9040	9040
query75	3355	2661	2691	2661
query76	2024	990	1056	990
query77	550	267	269	267
query78	10759	9477	9583	9477
query79	1432	579	607	579
query80	854	428	440	428
query81	521	240	231	231
query82	1307	87	85	85
query83	182	140	148	140
query84	282	80	77	77
query85	857	294	289	289
query86	322	275	291	275
query87	4471	4211	4243	4211
query88	3670	2412	2389	2389
query89	408	291	285	285
query90	1964	182	177	177
query91	183	153	147	147
query92	58	48	49	48
query93	1684	562	557	557
query94	740	290	302	290
query95	352	257	247	247
query96	613	289	292	289
query97	3327	3212	3191	3191
query98	214	201	202	201
query99	1856	1265	1287	1265
Total cold run time: 312258 ms
Total hot run time: 197273 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.13 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cb217f711f0f60a299697ba3ee034a6caafbc330, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.02	0.03
query3	0.24	0.07	0.06
query4	1.64	0.10	0.10
query5	0.51	0.51	0.50
query6	1.14	0.73	0.73
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.55	0.51	0.49
query10	0.55	0.53	0.54
query11	0.14	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.61	0.59
query14	2.74	2.75	2.74
query15	0.88	0.82	0.83
query16	0.38	0.38	0.38
query17	1.07	1.07	1.07
query18	0.24	0.22	0.23
query19	1.99	1.85	2.05
query20	0.01	0.01	0.01
query21	15.35	0.58	0.55
query22	2.49	2.63	2.66
query23	17.00	1.15	0.83
query24	3.04	1.36	1.20
query25	0.22	0.08	0.13
query26	0.59	0.15	0.13
query27	0.06	0.04	0.04
query28	9.99	0.54	0.50
query29	12.57	3.20	3.19
query30	0.25	0.06	0.06
query31	2.89	0.40	0.38
query32	3.27	0.47	0.46
query33	3.00	3.01	3.08
query34	17.18	4.48	4.46
query35	4.49	4.53	4.44
query36	0.67	0.48	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.17	0.12	0.12
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.54 s
Total hot run time: 33.13 s

@LiBinfeng-01
Copy link
Contributor

run cloud_p0

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit cdbb07a into branch-3.0 Mar 15, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-48895-branch-3.0 branch March 15, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants