[fix] (streamload) fixed the issue of data loss due to concurrency wh… #48948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
rebuid all |
ghkang98
force-pushed
the
streamload-lost-data
branch
from
f23c3c8 to
f9ea572
Compare
Contributor
Author
|
rebuid all |
liaoxin01
reviewed
Mar 12, 2025
| _data_queue.clear(); | ||
| break; | ||
| //1) wait scan operator write data | ||
| if (!_eos && _data_queue.empty() && _writer_status.ok()) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!_eos && _data_queue.empty() && _writer_status.ok()) { | |
| { | |
| std::unique_lock l(_m); | |
| while (!_eos && _data_queue.empty() && _writer_status.ok()) { | |
| // Add 1s to check to avoid lost signal | |
| _cv.wait_for(l, std::chrono::seconds(1)); | |
| } | |
| } |
I think we can solve this problem by simply deleting this if condition. The issue of out-of-order execution will be synchronized through the lock later.
Contributor
Author
There was a problem hiding this comment.
The if condition is removed. At the same time, for the rigor and readability of the code, the data is taken from the queue or moved down.
ghkang98
force-pushed
the
streamload-lost-data
branch
from
68856cc to
f84f912
Compare
Contributor
Author
|
rebuid all |
ghkang98
force-pushed
the
streamload-lost-data
branch
3 times, most recently
from
a19d050 to
705d30c
Compare
HappenLee
reviewed
Mar 14, 2025
| if ((_eos && _data_queue.empty()) || !_writer_status.ok()) { | ||
| _data_queue.clear(); | ||
| break; | ||
| //1) wait scan operator write data |
Contributor
There was a problem hiding this comment.
better do the change：
{
std::unique_lock l(_m);
while (!_eos && _data_queue.empty() && _writer_status.ok()) {
// Add 1s to check to avoid lost signal
_cv.wait_for(l, std::chrono::seconds(1));
}
if ((_eos && _data_queue.empty()) || !_writer_status.ok()) {
_data_queue.clear();
break;
}
}
…en importing data from streamload
ghkang98
force-pushed
the
streamload-lost-data
branch
from
705d30c to
f1b0bfe
Compare
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
run buildall |
TPC-H: Total hot run time: 32784 ms |
TPC-DS: Total hot run time: 192129 ms |
ClickBench: Total hot run time: 31.38 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
liaoxin01
changed the title
liaoxin01
pushed a commit
to liaoxin01/doris
that referenced
this pull request
Apr 10, 2025
…en importing data from streamload (apache#48948) This is mainly to solve the multithreading problem caused by inconsistent visible order of EOS and data_queue variables in doris's streamload function and asyn_result_writer in the process_block process due to the compilation reordering of the ARM system or the weak memory order problem, which leads to data loss. Problem Summary: Mainly in the arm architecture, streamload has data loss problems. The transaction of importing data can be executed and submitted normally, but the NumberTotalRowshe NumberFilterRows in the returned load result are both zero [Uploading stream_load_lost_data.docx…]() ((https://github.com/user-attachments/files/19201955/stream_load.docx)) Co-authored-by: lik40 <lik40@chinatelecom.cn>
liaoxin01
pushed a commit
to liaoxin01/doris
that referenced
this pull request
Apr 10, 2025
…en importing data from streamload (apache#48948) This is mainly to solve the multithreading problem caused by inconsistent visible order of EOS and data_queue variables in doris's streamload function and asyn_result_writer in the process_block process due to the compilation reordering of the ARM system or the weak memory order problem, which leads to data loss. Problem Summary: Mainly in the arm architecture, streamload has data loss problems. The transaction of importing data can be executed and submitted normally, but the NumberTotalRowshe NumberFilterRows in the returned load result are both zero [Uploading stream_load_lost_data.docx…]() ((https://github.com/user-attachments/files/19201955/stream_load.docx)) Co-authored-by: lik40 <lik40@chinatelecom.cn>
starocean999
pushed a commit
to starocean999/incubator-doris
that referenced
this pull request
Apr 27, 2025
…en importing data from streamload (apache#48948) (apache#3843) cherry-pick from: apache#48948 http://jira.selectdb-in.cc/browse/CIR-14580
Closed
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…en importing data from streamload (apache#48948) ### What problem does this PR solve? This is mainly to solve the multithreading problem caused by inconsistent visible order of EOS and data_queue variables in doris's streamload function and asyn_result_writer in the process_block process due to the compilation reordering of the ARM system or the weak memory order problem, which leads to data loss. Problem Summary: Mainly in the arm architecture, streamload has data loss problems. The transaction of importing data can be executed and submitted normally, but the NumberTotalRowshe NumberFilterRows in the returned load result are both zero [Uploading stream_load_lost_data.docx…]() ((https://github.com/user-attachments/files/19201955/stream_load.docx)) Co-authored-by: lik40 <lik40@chinatelecom.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…en importing data from streamload
What problem does this PR solve?
This is mainly to solve the multithreading problem caused by inconsistent visible order of EOS and data_queue variables in doris's streamload function and asyn_result_writer in the process_block process due to the compilation reordering of the ARM system or the weak memory order problem, which leads to data loss.
Problem Summary:
Mainly in the arm architecture, streamload has data loss problems. The transaction of importing data can be executed and submitted normally, but the NumberTotalRowshe NumberFilterRows in the returned load result are both zero
Uploading stream_load_lost_data.docx…
((https://github.com/user-attachments/files/19201955/stream_load.docx))