Skip to content

Conversation

@liaoxin01
Copy link
Contributor

cherry pick from #48948

@liaoxin01 liaoxin01 requested a review from yiguolei as a code owner April 10, 2025 03:31
@liaoxin01
Copy link
Contributor Author

run buildall

@Thearas
Copy link
Contributor

Thearas commented Apr 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

…en importing data from streamload (apache#48948)

This is mainly to solve the multithreading problem caused by
inconsistent visible order of EOS and data_queue variables in doris's
streamload function and asyn_result_writer in the process_block process
due to the compilation reordering of the ARM system or the weak memory
order problem, which leads to data loss.

Problem Summary:

Mainly in the arm architecture, streamload has data loss problems. The
transaction of importing data can be executed and submitted normally,
but the NumberTotalRowshe NumberFilterRows in the returned load result
are both zero
[Uploading stream_load_lost_data.docx…]()
((https://github.com/user-attachments/files/19201955/stream_load.docx))

Co-authored-by: lik40 <lik40@chinatelecom.cn>
@liaoxin01 liaoxin01 force-pushed the pick_48948_to_origin_branch-2.1 branch from 8cb4326 to 0b7e0ac Compare April 10, 2025 03:34
@liaoxin01
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/22) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.18% (10062/26353)
Line Coverage 29.20% (82911/283908)
Region Coverage 27.86% (42612/152936)
Branch Coverage 24.48% (21591/88196)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 11, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit e70a3ab into apache:branch-2.1 Apr 11, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants