Skip to content

[fix](Nereids) fix substring with only one parameter #48957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
starocean999 merged 1 commit into from
Mar 13, 2025
Merged

[fix](Nereids) fix substring with only one parameter #48957

starocean999 merged 1 commit into from
Mar 13, 2025

Conversation

@LiBinfeng-01
Copy link
Contributor

@LiBinfeng-01 LiBinfeng-01 commented Mar 12, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

explain select substr('abcd', 2); would failed at fe fold constant because third parameter set to integer max. Should check upper bound when calculating

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Mar 12, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

doris-robot commented Mar 12, 2025

TPC-H: Total hot run time: 32686 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2b2f4aa48985ba1a1a17567abd3057f3c68ebd6b, data reload: false

------ Round 1 ----------------------------------
q1	17614	5203	5092	5092
q2	2047	281	159	159
q3	10443	1256	731	731
q4	10243	1012	529	529
q5	7801	2358	2300	2300
q6	185	168	131	131
q7	912	752	607	607
q8	9308	1283	1098	1098
q9	4838	4734	4734	4734
q10	6866	2318	1910	1910
q11	484	273	275	273
q12	351	367	217	217
q13	17799	3650	3222	3222
q14	249	240	232	232
q15	541	473	484	473
q16	633	629	579	579
q17	595	839	393	393
q18	7012	6500	6378	6378
q19	1353	946	548	548
q20	312	322	190	190
q21	2859	2086	1926	1926
q22	1009	1059	964	964
Total cold run time: 103454 ms
Total hot run time: 32686 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5197	5131	5131	5131
q2	241	322	238	238
q3	2181	2705	2300	2300
q4	1461	1827	1367	1367
q5	4209	4085	4194	4085
q6	202	165	123	123
q7	1875	1908	1764	1764
q8	2578	2647	2542	2542
q9	7268	7233	7113	7113
q10	3003	3246	2823	2823
q11	575	500	493	493
q12	700	797	573	573
q13	3451	3925	3326	3326
q14	284	289	265	265
q15	525	466	476	466
q16	653	676	638	638
q17	1157	1553	1387	1387
q18	7861	7624	7473	7473
q19	824	798	923	798
q20	1973	2038	1888	1888
q21	5575	4978	4621	4621
q22	1169	1088	1057	1057
Total cold run time: 52962 ms
Total hot run time: 50471 ms

@doris-robot
Copy link

doris-robot commented Mar 12, 2025

TPC-DS: Total hot run time: 192236 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2b2f4aa48985ba1a1a17567abd3057f3c68ebd6b, data reload: false

query1	1406	1016	987	987
query2	6110	1914	1894	1894
query3	11151	4582	4770	4582
query4	53955	25617	23079	23079
query5	5237	564	467	467
query6	363	190	186	186
query7	5026	507	289	289
query8	329	255	235	235
query9	6236	2604	2617	2604
query10	439	306	252	252
query11	15150	15043	14847	14847
query12	156	104	108	104
query13	1134	530	408	408
query14	10105	6509	6547	6509
query15	195	208	187	187
query16	7055	694	496	496
query17	1130	720	625	625
query18	1500	415	324	324
query19	211	192	175	175
query20	127	126	122	122
query21	209	129	101	101
query22	4513	4731	4253	4253
query23	34054	33341	33422	33341
query24	6246	2393	2435	2393
query25	471	472	404	404
query26	777	278	153	153
query27	2238	483	331	331
query28	3241	2453	2475	2453
query29	596	566	428	428
query30	271	219	192	192
query31	882	901	791	791
query32	74	62	65	62
query33	463	359	296	296
query34	777	864	506	506
query35	796	841	786	786
query36	966	1025	907	907
query37	118	101	77	77
query38	4319	4175	4121	4121
query39	1485	1441	1446	1441
query40	206	112	101	101
query41	63	53	51	51
query42	121	102	109	102
query43	495	528	483	483
query44	1297	796	794	794
query45	178	174	169	169
query46	838	1035	658	658
query47	1836	1906	1822	1822
query48	409	445	323	323
query49	707	523	421	421
query50	705	740	411	411
query51	4336	4264	4296	4264
query52	116	109	98	98
query53	236	254	187	187
query54	502	505	443	443
query55	87	83	82	82
query56	278	275	250	250
query57	1182	1179	1136	1136
query58	249	245	249	245
query59	2699	2856	2876	2856
query60	280	264	261	261
query61	134	118	118	118
query62	736	752	682	682
query63	235	197	191	191
query64	2086	1043	673	673
query65	4534	4414	4436	4414
query66	749	398	301	301
query67	15754	15564	15503	15503
query68	7338	912	501	501
query69	538	293	264	264
query70	1223	1166	1133	1133
query71	477	293	258	258
query72	5759	3614	3903	3614
query73	1324	747	356	356
query74	8951	8963	9010	8963
query75	3739	3153	2672	2672
query76	4249	1184	743	743
query77	576	340	286	286
query78	9998	10265	9375	9375
query79	2083	828	581	581
query80	719	524	471	471
query81	477	260	223	223
query82	424	124	97	97
query83	283	174	156	156
query84	291	90	74	74
query85	785	357	301	301
query86	344	298	286	286
query87	4505	4606	4417	4417
query88	3273	2232	2223	2223
query89	397	311	284	284
query90	1939	202	209	202
query91	139	136	111	111
query92	70	59	56	56
query93	1180	1063	582	582
query94	703	420	299	299
query95	346	266	260	260
query96	489	558	274	274
query97	3295	3350	3277	3277
query98	223	227	203	203
query99	1453	1389	1247	1247
Total cold run time: 298149 ms
Total hot run time: 192236 ms

@doris-robot
Copy link

doris-robot commented Mar 12, 2025

ClickBench: Total hot run time: 30.75 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2b2f4aa48985ba1a1a17567abd3057f3c68ebd6b, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.63	0.10	0.11
query5	0.57	0.54	0.56
query6	1.20	0.71	0.70
query7	0.03	0.02	0.02
query8	0.04	0.03	0.04
query9	0.61	0.51	0.51
query10	0.57	0.59	0.58
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.62	0.61	0.59
query14	2.66	2.73	2.67
query15	0.92	0.85	0.84
query16	0.37	0.37	0.38
query17	1.04	1.05	1.05
query18	0.21	0.20	0.19
query19	1.85	1.89	2.00
query20	0.01	0.01	0.02
query21	15.35	0.92	0.56
query22	0.76	1.30	0.67
query23	14.82	1.38	0.61
query24	7.36	1.70	0.64
query25	0.55	0.27	0.12
query26	0.62	0.16	0.13
query27	0.05	0.05	0.04
query28	9.98	0.88	0.43
query29	12.55	3.98	3.31
query30	0.27	0.09	0.06
query31	3.24	0.58	0.39
query32	3.49	0.54	0.47
query33	3.01	3.07	3.12
query34	15.86	5.16	4.50
query35	4.56	4.59	4.55
query36	0.65	0.49	0.49
query37	0.09	0.05	0.06
query38	0.05	0.04	0.03
query39	0.02	0.02	0.02
query40	0.17	0.13	0.13
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.54 s
Total hot run time: 30.75 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 753cc3e into apache:master Mar 13, 2025
33 of 35 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 13, 2025
[fix](Nereids) fix substring with only one parameter (#48957)
1ef2812 
Problem Summary:

explain select substr('abcd', 2); would failed at fe fold constant
because third parameter set to integer max. Should check upper bound
when calculating
@github-actions github-actions bot mentioned this pull request Mar 13, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Mar 13, 2025
[fix](Nereids) fix substring with only one parameter (#48957)
bd81dc5 
Problem Summary:

explain select substr('abcd', 2); would failed at fe fold constant
because third parameter set to integer max. Should check upper bound
when calculating
@github-actions github-actions bot mentioned this pull request Mar 13, 2025
Merged
dataroaring pushed a commit that referenced this pull request Mar 15, 2025
@github-actions
branch-3.0: [fix](Nereids) fix substring with only one parameter #48957…
baff13e 
… (#49029)

Cherry-picked from #48957

Co-authored-by: LiBinfeng <libinfeng@selectdb.com>
morrySnow pushed a commit that referenced this pull request Mar 18, 2025
@morrySnow
[fix](Nereids) fix substring with only one parameter (#48957)
0f2818b 
Problem Summary:

explain select substr('abcd', 2); would failed at fe fold constant
because third parameter set to integer max. Should check upper bound
when calculating
yiguolei pushed a commit that referenced this pull request Mar 19, 2025
@github-actions
branch-2.1: [fix](Nereids) fix substring with only one parameter #48957…
13c174d 
… (#49030)

Cherry-picked from #48957

Co-authored-by: LiBinfeng <libinfeng@selectdb.com>
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Closed
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@koarz
[fix](Nereids) fix substring with only one parameter (apache#48957)
246ae8c 
Problem Summary:

explain select substr('abcd', 2); would failed at fe fold constant
because third parameter set to integer max. Should check upper bound
when calculating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.5-merged p0_w reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@LiBinfeng-01 @hello-stephen @doris-robot @starocean999 @morrySnow @yiguolei @dataroaring