Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #48957

Problem Summary:

explain select substr('abcd', 2); would failed at fe fold constant
because third parameter set to integer max. Should check upper bound
when calculating
@github-actions github-actions bot requested a review from dataroaring as a code owner March 13, 2025 08:16
@Thearas
Copy link
Contributor

Thearas commented Mar 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 13, 2025
@Thearas
Copy link
Contributor

Thearas commented Mar 13, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39992 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1ef28120af4bbd5c54272797fc22e27fb9d33ad5, data reload: false

------ Round 1 ----------------------------------
q1	17589	6696	6590	6590
q2	2050	164	162	162
q3	10933	1070	1173	1070
q4	10545	714	715	714
q5	7715	2838	2811	2811
q6	215	131	130	130
q7	946	615	622	615
q8	9355	1945	2033	1945
q9	6556	6404	6447	6404
q10	7074	2224	2265	2224
q11	458	259	259	259
q12	398	211	217	211
q13	17759	3001	3000	3000
q14	240	210	209	209
q15	504	466	454	454
q16	667	610	595	595
q17	966	515	621	515
q18	7285	6694	6638	6638
q19	1438	1079	1014	1014
q20	473	204	197	197
q21	3991	3260	3260	3260
q22	1100	1002	975	975
Total cold run time: 108257 ms
Total hot run time: 39992 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6594	6528	6621	6528
q2	330	227	228	227
q3	2894	2728	2899	2728
q4	2020	1848	1829	1829
q5	5727	5684	5718	5684
q6	207	125	126	125
q7	2230	1860	1800	1800
q8	3395	3529	3500	3500
q9	8856	8883	8810	8810
q10	3612	3532	3528	3528
q11	588	484	496	484
q12	822	606	617	606
q13	9633	3216	3153	3153
q14	306	281	279	279
q15	515	449	480	449
q16	683	637	674	637
q17	1839	1613	1649	1613
q18	8207	7880	7644	7644
q19	1635	1622	1588	1588
q20	2074	1894	1842	1842
q21	5569	5247	5259	5247
q22	1100	1066	1019	1019
Total cold run time: 68836 ms
Total hot run time: 59320 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198084 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1ef28120af4bbd5c54272797fc22e27fb9d33ad5, data reload: false

query1	1296	908	880	880
query2	6242	2082	2109	2082
query3	10832	4239	4062	4062
query4	60224	35069	23826	23826
query5	5224	454	475	454
query6	307	169	171	169
query7	4931	322	323	322
query8	291	235	231	231
query9	6574	2648	2651	2648
query10	437	274	276	274
query11	15793	15088	15819	15088
query12	167	104	108	104
query13	1071	453	462	453
query14	10388	7330	7634	7330
query15	209	177	180	177
query16	7116	478	488	478
query17	1142	601	588	588
query18	1917	340	328	328
query19	221	170	162	162
query20	115	110	107	107
query21	207	102	103	102
query22	4624	4509	4633	4509
query23	34555	34040	33966	33966
query24	6480	2952	2927	2927
query25	544	440	440	440
query26	658	172	173	172
query27	1860	375	374	374
query28	4032	2464	2440	2440
query29	706	477	460	460
query30	250	172	163	163
query31	1015	815	805	805
query32	69	57	58	57
query33	415	267	294	267
query34	956	526	522	522
query35	840	725	734	725
query36	1102	979	987	979
query37	110	65	70	65
query38	4154	4025	4045	4025
query39	1551	1468	1459	1459
query40	204	101	98	98
query41	50	48	49	48
query42	115	102	97	97
query43	553	499	509	499
query44	1228	846	850	846
query45	184	168	165	165
query46	1155	751	751	751
query47	1993	1950	1922	1922
query48	485	389	390	389
query49	757	390	412	390
query50	852	427	439	427
query51	7485	7101	7218	7101
query52	108	93	88	88
query53	272	186	189	186
query54	596	464	472	464
query55	83	78	81	78
query56	268	247	245	245
query57	1296	1170	1154	1154
query58	220	205	212	205
query59	3334	3172	3037	3037
query60	283	243	258	243
query61	118	109	111	109
query62	766	658	696	658
query63	212	196	195	195
query64	1365	663	638	638
query65	3234	3194	3202	3194
query66	718	300	330	300
query67	16029	15675	15517	15517
query68	3484	618	607	607
query69	426	267	260	260
query70	1208	1154	1152	1152
query71	334	276	256	256
query72	6384	4125	4049	4049
query73	770	354	352	352
query74	9937	9191	9167	9167
query75	3337	2647	2669	2647
query76	1864	1072	1013	1013
query77	494	274	292	274
query78	10759	9485	9632	9485
query79	1463	604	610	604
query80	867	428	428	428
query81	521	243	236	236
query82	1274	93	87	87
query83	246	144	141	141
query84	279	81	76	76
query85	864	303	296	296
query86	336	295	298	295
query87	4415	4309	4285	4285
query88	3959	2414	2372	2372
query89	427	289	288	288
query90	2009	185	188	185
query91	183	151	147	147
query92	62	50	50	50
query93	1977	576	564	564
query94	732	305	278	278
query95	353	261	263	261
query96	615	282	282	282
query97	3297	3175	3187	3175
query98	212	205	199	199
query99	1553	1309	1319	1309
Total cold run time: 307229 ms
Total hot run time: 198084 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.18 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1ef28120af4bbd5c54272797fc22e27fb9d33ad5, data reload: false

query1	0.03	0.04	0.02
query2	0.07	0.03	0.02
query3	0.23	0.07	0.07
query4	1.60	0.10	0.10
query5	0.52	0.52	0.50
query6	1.14	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.05	0.03
query9	0.56	0.48	0.49
query10	0.55	0.54	0.58
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.60	0.59
query14	2.87	2.72	2.75
query15	0.89	0.82	0.82
query16	0.36	0.38	0.38
query17	0.99	1.00	1.07
query18	0.24	0.22	0.23
query19	1.95	1.87	1.99
query20	0.01	0.01	0.01
query21	15.36	0.57	0.58
query22	2.53	3.02	1.85
query23	16.85	1.20	0.66
query24	2.79	1.90	0.19
query25	0.17	0.06	0.05
query26	0.48	0.14	0.14
query27	0.05	0.04	0.03
query28	10.61	0.54	0.46
query29	12.58	3.22	3.22
query30	0.24	0.05	0.06
query31	2.89	0.39	0.38
query32	3.24	0.45	0.47
query33	2.94	3.01	3.02
query34	17.13	4.48	4.48
query35	4.58	4.56	4.52
query36	0.70	0.52	0.48
query37	0.10	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.16	0.13	0.12
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.59 s
Total hot run time: 31.18 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit baff13e into branch-3.0 Mar 15, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-48957-branch-3.0 branch March 15, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants