[improve](mow) improve mow get_agg by cache #48968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32935 ms |
TPC-DS: Total hot run time: 192512 ms |
ClickBench: Total hot run time: 31 s |
zhannngchen
reviewed
Mar 12, 2025
be/src/olap/tablet_meta.cpp
Outdated
| // remove rowset delete bitmap | ||
| delete_bitmap().remove({(*it)->rowset_id(), 0, 0}, | ||
| {(*it)->rowset_id(), UINT32_MAX, 0}); | ||
| delete_bitmap().remove_rowset_cache_version((*it)->rowset_id()); |
Contributor
There was a problem hiding this comment.
Add a DCHECK at the end of the fucntion, to check that the size of _rowset_cache_version is smaller than the size of _rs_metas.size() + _stale_rs_metas.size() to avoid mem leak
zhannngchen
reviewed
Mar 13, 2025
be/src/olap/tablet_meta.cpp
Outdated
| // of cache entries in some cases? | ||
| if (val == nullptr) { // Renew if needed, put a new Value to cache | ||
| val = new AggCache::Value(); | ||
| Version start_version = _get_rowset_cache_version(bmk); |
Contributor
There was a problem hiding this comment.
add a config to control whether this feature is enabled.
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32479 ms |
TPC-DS: Total hot run time: 192371 ms |
ClickBench: Total hot run time: 30.99 s |
Contributor
Author
|
run be_ut |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
bobhan1
approved these changes
Mar 14, 2025
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
pushed a commit
that referenced
this pull request
Mar 17, 2025
16 tasks
zhannngchen
pushed a commit
that referenced
this pull request
Mar 20, 2025
Problem Summary: introduced by #48968, fix the rowset_cache_version is not deleted if _rs_metas or _stale_rs_metas is changed: ``` F20250319 13:41:54.708062 5890 tablet_meta.cpp:955] Check failed: false . tablet: 1742356296291, rowset_cache_version size: 1607, _rs_metas size: 135, _stale_rs_metas size: 707 *** Check failure stack trace: *** @ 0x55aa24363916 google::LogMessage::SendToLog() @ 0x55aa24360360 google::LogMessage::Flush() @ 0x55aa24364159 google::LogMessageFatal::~LogMessageFatal() @ 0x55aa19c476a9 doris::TabletMeta::delete_stale_rs_meta_by_version() @ 0x55aa19bf38b3 doris::Tablet::_delete_stale_rowset_by_version() @ 0x55aa19bf451a doris::Tablet::delete_expired_stale_rowset() @ 0x55aa19c264f8 doris::TabletManager::for_each_tablet() @ 0x55aa19c2a473 doris::TabletManager::start_trash_sweep() @ 0x55aa19bd3fa5 doris::StorageEngine::start_trash_sweep() @ 0x55aa198b9da6 doris::StorageEngine::_garbage_sweeper_thread_callback() ```
github-actions bot
pushed a commit
that referenced
this pull request
Mar 20, 2025
Problem Summary: introduced by #48968, fix the rowset_cache_version is not deleted if _rs_metas or _stale_rs_metas is changed: ``` F20250319 13:41:54.708062 5890 tablet_meta.cpp:955] Check failed: false . tablet: 1742356296291, rowset_cache_version size: 1607, _rs_metas size: 135, _stale_rs_metas size: 707 *** Check failure stack trace: *** @ 0x55aa24363916 google::LogMessage::SendToLog() @ 0x55aa24360360 google::LogMessage::Flush() @ 0x55aa24364159 google::LogMessageFatal::~LogMessageFatal() @ 0x55aa19c476a9 doris::TabletMeta::delete_stale_rs_meta_by_version() @ 0x55aa19bf38b3 doris::Tablet::_delete_stale_rowset_by_version() @ 0x55aa19bf451a doris::Tablet::delete_expired_stale_rowset() @ 0x55aa19c264f8 doris::TabletManager::for_each_tablet() @ 0x55aa19c2a473 doris::TabletManager::start_trash_sweep() @ 0x55aa19bd3fa5 doris::StorageEngine::start_trash_sweep() @ 0x55aa198b9da6 doris::StorageEngine::_garbage_sweeper_thread_callback() ```
Closed
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
Problem Summary: introduced by apache#48968, fix the rowset_cache_version is not deleted if _rs_metas or _stale_rs_metas is changed: ``` F20250319 13:41:54.708062 5890 tablet_meta.cpp:955] Check failed: false . tablet: 1742356296291, rowset_cache_version size: 1607, _rs_metas size: 135, _stale_rs_metas size: 707 *** Check failure stack trace: *** @ 0x55aa24363916 google::LogMessage::SendToLog() @ 0x55aa24360360 google::LogMessage::Flush() @ 0x55aa24364159 google::LogMessageFatal::~LogMessageFatal() @ 0x55aa19c476a9 doris::TabletMeta::delete_stale_rs_meta_by_version() @ 0x55aa19bf38b3 doris::Tablet::_delete_stale_rowset_by_version() @ 0x55aa19bf451a doris::Tablet::delete_expired_stale_rowset() @ 0x55aa19c264f8 doris::TabletManager::for_each_tablet() @ 0x55aa19c2a473 doris::TabletManager::start_trash_sweep() @ 0x55aa19bd3fa5 doris::StorageEngine::start_trash_sweep() @ 0x55aa198b9da6 doris::StorageEngine::_garbage_sweeper_thread_callback() ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)