-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](mow) remove rowset cache version #49295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
Please add some comment to explain the problem which the pr tries to fix. |
80acfa5 to
f5f298d
Compare
|
run buildall |
TPC-H: Total hot run time: 32746 ms |
TPC-DS: Total hot run time: 185268 ms |
ClickBench: Total hot run time: 31.6 s |
|
run cloud_p0 |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
zhannngchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Problem Summary: introduced by #48968, fix the rowset_cache_version is not deleted if _rs_metas or _stale_rs_metas is changed: ``` F20250319 13:41:54.708062 5890 tablet_meta.cpp:955] Check failed: false . tablet: 1742356296291, rowset_cache_version size: 1607, _rs_metas size: 135, _stale_rs_metas size: 707 *** Check failure stack trace: *** @ 0x55aa24363916 google::LogMessage::SendToLog() @ 0x55aa24360360 google::LogMessage::Flush() @ 0x55aa24364159 google::LogMessageFatal::~LogMessageFatal() @ 0x55aa19c476a9 doris::TabletMeta::delete_stale_rs_meta_by_version() @ 0x55aa19bf38b3 doris::Tablet::_delete_stale_rowset_by_version() @ 0x55aa19bf451a doris::Tablet::delete_expired_stale_rowset() @ 0x55aa19c264f8 doris::TabletManager::for_each_tablet() @ 0x55aa19c2a473 doris::TabletManager::start_trash_sweep() @ 0x55aa19bd3fa5 doris::StorageEngine::start_trash_sweep() @ 0x55aa198b9da6 doris::StorageEngine::_garbage_sweeper_thread_callback() ```
Problem Summary: introduced by apache#48968, fix the rowset_cache_version is not deleted if _rs_metas or _stale_rs_metas is changed: ``` F20250319 13:41:54.708062 5890 tablet_meta.cpp:955] Check failed: false . tablet: 1742356296291, rowset_cache_version size: 1607, _rs_metas size: 135, _stale_rs_metas size: 707 *** Check failure stack trace: *** @ 0x55aa24363916 google::LogMessage::SendToLog() @ 0x55aa24360360 google::LogMessage::Flush() @ 0x55aa24364159 google::LogMessageFatal::~LogMessageFatal() @ 0x55aa19c476a9 doris::TabletMeta::delete_stale_rs_meta_by_version() @ 0x55aa19bf38b3 doris::Tablet::_delete_stale_rowset_by_version() @ 0x55aa19bf451a doris::Tablet::delete_expired_stale_rowset() @ 0x55aa19c264f8 doris::TabletManager::for_each_tablet() @ 0x55aa19c2a473 doris::TabletManager::start_trash_sweep() @ 0x55aa19bd3fa5 doris::StorageEngine::start_trash_sweep() @ 0x55aa198b9da6 doris::StorageEngine::_garbage_sweeper_thread_callback() ```
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
introduced by #48968, fix the rowset_cache_version is not deleted if _rs_metas or _stale_rs_metas is changed:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)