Skip to content

branch-3.0: [fix](mow) remove rowset cache version #49295 #49322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Mar 21, 2025
Merged

branch-3.0: [fix](mow) remove rowset cache version #49295 #49322

dataroaring merged 1 commit into from
Mar 21, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 20, 2025

Cherry-picked from #49295

@mymeiyi
[fix](mow) remove rowset cache version (#49295)
a36813e 
Problem Summary:
introduced by #48968, fix the
rowset_cache_version is not deleted if _rs_metas or _stale_rs_metas is
changed:
```
F20250319 13:41:54.708062  5890 tablet_meta.cpp:955] Check failed: false . tablet: 1742356296291, rowset_cache_version size: 1607, _rs_metas size: 135, _stale_rs_metas size: 707
*** Check failure stack trace: ***
    @     0x55aa24363916  google::LogMessage::SendToLog()
    @     0x55aa24360360  google::LogMessage::Flush()
    @     0x55aa24364159  google::LogMessageFatal::~LogMessageFatal()
    @     0x55aa19c476a9  doris::TabletMeta::delete_stale_rs_meta_by_version()
    @     0x55aa19bf38b3  doris::Tablet::_delete_stale_rowset_by_version()
    @     0x55aa19bf451a  doris::Tablet::delete_expired_stale_rowset()
    @     0x55aa19c264f8  doris::TabletManager::for_each_tablet()
    @     0x55aa19c2a473  doris::TabletManager::start_trash_sweep()
    @     0x55aa19bd3fa5  doris::StorageEngine::start_trash_sweep()
    @     0x55aa198b9da6  doris::StorageEngine::_garbage_sweeper_thread_callback()
```
@github-actions github-actions bot requested a review from dataroaring as a code owner March 20, 2025 10:48
@Thearas
Copy link
Contributor

Thearas commented Mar 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 20, 2025
@Thearas
Copy link
Contributor

Thearas commented Mar 20, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 20, 2025

BE UT Coverage Report

Increment line coverage 31.37% (16/51) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.89% (10173/26158)
Line Coverage 30.32% (86797/286281)
Region Coverage 29.36% (44583/151857)
Branch Coverage 25.88% (22677/87626)

dataroaring
dataroaring approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit a1818fd into branch-3.0 Mar 21, 2025
21 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49295-branch-3.0 branch March 21, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thearas @doris-robot @dataroaring @mymeiyi