Skip to content

Conversation

@amorynan
Copy link
Contributor

Reverts #48729
temp revert this pr for PartialUpdateInfo::_generate_default_values_for_missing_cids using empty string , which will make this check fail.

@amorynan amorynan requested a review from yiguolei as a code owner March 14, 2025 03:11
@amorynan
Copy link
Contributor Author

run buildall

@Thearas
Copy link
Contributor

Thearas commented Mar 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 14, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 36.84% (7/19) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 37.32% (9832/26345)
Line Coverage 29.00% (82325/283884)
Region Coverage 27.62% (42240/152938)
Branch Coverage 24.38% (21506/88214)

@yiguolei yiguolei merged commit e5a2b0e into apache:branch-2.1 Mar 14, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants