Skip to content

Conversation

@amorynan
Copy link
Contributor

@amorynan amorynan commented Mar 6, 2025

…ke select core (#48625)

fix invalid jsonb value write into segment file which make select core, so we add a check for jsonb value when convert_to_olap which value will be written into segment file

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…ke select core (apache#48625)

fix invalid jsonb value write into segment file which make select core,
so we add a check for jsonb value when convert_to_olap which value will
be written into segment file
@Thearas
Copy link
Contributor

Thearas commented Mar 6, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@amorynan amorynan changed the title [Pick](jsonb) add a check for jsonb value to avoid invalid jsonb value write into segment file [cherry-pick](jsonb) add a check for jsonb value to avoid invalid jsonb value write into segment file Mar 6, 2025
@amorynan
Copy link
Contributor Author

amorynan commented Mar 6, 2025

run buildall

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 32.56% (14/43) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 36.88% (9715/26339)
Line Coverage 28.56% (81063/283815)
Region Coverage 27.16% (41526/152906)
Branch Coverage 23.90% (21075/88194)

@yiguolei yiguolei merged commit 7b2899a into apache:branch-2.1 Mar 6, 2025
18 of 20 checks passed
yiguolei pushed a commit that referenced this pull request Mar 14, 2025
…alid jsonb value write into segment file " (#49058)

Reverts #48729
temp revert this pr for
PartialUpdateInfo::_generate_default_values_for_missing_cids using empty
string , which will make this check fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants