Skip to content

[fix](jsonb) fix invalid jsonb value write into segment file which make select core #48625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eldenmoon merged 7 commits into from
Mar 6, 2025
Merged

[fix](jsonb) fix invalid jsonb value write into segment file which make select core #48625

eldenmoon merged 7 commits into from
Mar 6, 2025

Conversation

@amorynan
Copy link
Contributor

@amorynan amorynan commented Mar 4, 2025 •
edited
Loading

What problem does this PR solve?

fix invalid jsonb value write into segment file which make select core, so we add a check for jsonb value when convert_to_olap which value will be written into segment file
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 4, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@amorynan
Copy link
Contributor Author

amorynan commented Mar 4, 2025

run buildall

csun5285
csun5285 reviewed Mar 4, 2025
View reviewed changes
@doris-robot
Copy link

doris-robot commented Mar 4, 2025

TPC-H: Total hot run time: 31909 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 191a2d22d706ca81470798a087eebc2c5c3a7910, data reload: false

------ Round 1 ----------------------------------
q1	17588	5264	5174	5174
q2	2057	299	170	170
q3	10399	1366	742	742
q4	10216	1037	562	562
q5	7494	2436	2391	2391
q6	189	171	141	141
q7	918	772	614	614
q8	9309	1343	1154	1154
q9	4968	4726	4843	4726
q10	6818	2327	1893	1893
q11	484	276	265	265
q12	353	359	230	230
q13	17760	3704	3096	3096
q14	232	226	207	207
q15	498	471	459	459
q16	661	625	572	572
q17	573	897	350	350
q18	7008	6203	6116	6116
q19	1199	949	551	551
q20	327	332	199	199
q21	3095	2334	1990	1990
q22	370	345	307	307
Total cold run time: 102516 ms
Total hot run time: 31909 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5218	5198	5233	5198
q2	242	333	231	231
q3	2172	2670	2302	2302
q4	1491	1832	1339	1339
q5	4245	4176	4153	4153
q6	207	166	129	129
q7	1869	1845	1774	1774
q8	2617	2669	2638	2638
q9	7361	7157	7209	7157
q10	2997	3241	2804	2804
q11	566	495	508	495
q12	723	793	626	626
q13	3505	4007	3227	3227
q14	289	291	296	291
q15	521	464	464	464
q16	634	697	644	644
q17	1175	1597	1340	1340
q18	7603	7492	7221	7221
q19	813	822	882	822
q20	1956	2022	1873	1873
q21	5502	5048	4981	4981
q22	663	623	609	609
Total cold run time: 52369 ms
Total hot run time: 50318 ms

@doris-robot
Copy link

doris-robot commented Mar 4, 2025

TPC-DS: Total hot run time: 184407 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 191a2d22d706ca81470798a087eebc2c5c3a7910, data reload: false

query1	1003	384	388	384
query2	6529	1926	1887	1887
query3	6790	221	215	215
query4	26553	23905	23408	23408
query5	4340	650	524	524
query6	306	201	182	182
query7	4607	505	302	302
query8	305	240	243	240
query9	8598	2550	2523	2523
query10	469	315	261	261
query11	15652	15175	14937	14937
query12	175	107	107	107
query13	1646	519	382	382
query14	9595	6527	7068	6527
query15	209	197	180	180
query16	7287	632	465	465
query17	1171	719	571	571
query18	1983	409	314	314
query19	196	184	161	161
query20	120	116	117	116
query21	213	121	103	103
query22	4125	4204	4067	4067
query23	34156	32909	33031	32909
query24	7751	2420	2443	2420
query25	532	493	418	418
query26	1243	277	163	163
query27	2273	507	340	340
query28	4019	2430	2408	2408
query29	761	576	449	449
query30	240	194	168	168
query31	961	866	841	841
query32	70	65	61	61
query33	573	346	291	291
query34	789	851	510	510
query35	792	803	730	730
query36	960	1013	875	875
query37	123	98	82	82
query38	4210	4254	4094	4094
query39	1449	1412	1407	1407
query40	205	115	102	102
query41	54	51	49	49
query42	122	109	106	106
query43	512	519	483	483
query44	1313	805	801	801
query45	178	165	164	164
query46	876	1037	668	668
query47	1729	1781	1694	1694
query48	374	409	310	310
query49	786	502	416	416
query50	698	727	416	416
query51	4220	4133	4177	4133
query52	106	105	92	92
query53	227	259	190	190
query54	498	491	429	429
query55	79	81	83	81
query56	262	267	251	251
query57	1125	1113	1036	1036
query58	254	233	260	233
query59	2901	2613	2544	2544
query60	281	264	261	261
query61	123	115	115	115
query62	800	740	663	663
query63	230	194	197	194
query64	4244	1003	644	644
query65	3309	3189	3178	3178
query66	1109	397	319	319
query67	15932	15582	15267	15267
query68	8639	887	525	525
query69	471	302	273	273
query70	1246	1115	1173	1115
query71	475	291	265	265
query72	5403	3470	3635	3470
query73	786	714	352	352
query74	9322	9231	8731	8731
query75	4099	3160	2747	2747
query76	3679	1200	742	742
query77	792	368	293	293
query78	9971	10234	9456	9456
query79	2241	828	599	599
query80	641	527	453	453
query81	490	280	292	280
query82	664	126	98	98
query83	170	176	151	151
query84	243	90	77	77
query85	778	346	302	302
query86	336	334	312	312
query87	4335	4443	4267	4267
query88	2909	2234	2244	2234
query89	396	336	288	288
query90	1942	207	198	198
query91	137	138	107	107
query92	74	61	62	61
query93	1134	1056	592	592
query94	670	415	295	295
query95	363	265	256	256
query96	490	553	272	272
query97	3410	3419	3252	3252
query98	224	212	204	204
query99	1438	1383	1279	1279
Total cold run time: 273289 ms
Total hot run time: 184407 ms

@doris-robot
Copy link

doris-robot commented Mar 4, 2025

ClickBench: Total hot run time: 30.94 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 191a2d22d706ca81470798a087eebc2c5c3a7910, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.23	0.07	0.06
query4	1.62	0.10	0.10
query5	0.55	0.55	0.55
query6	1.19	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.03
query9	0.57	0.54	0.51
query10	0.56	0.57	0.57
query11	0.15	0.11	0.10
query12	0.15	0.11	0.11
query13	0.61	0.62	0.60
query14	2.67	2.82	2.69
query15	0.93	0.87	0.86
query16	0.39	0.39	0.37
query17	1.01	1.00	1.02
query18	0.21	0.20	0.20
query19	1.88	1.83	1.91
query20	0.02	0.01	0.01
query21	15.36	0.89	0.56
query22	0.77	1.19	0.65
query23	14.92	1.37	0.66
query24	7.40	1.99	0.86
query25	0.49	0.21	0.10
query26	0.68	0.16	0.15
query27	0.06	0.05	0.06
query28	9.60	0.86	0.43
query29	12.63	3.94	3.31
query30	0.25	0.09	0.06
query31	2.82	0.59	0.38
query32	3.22	0.56	0.47
query33	2.99	2.99	3.08
query34	15.76	5.16	4.54
query35	4.57	4.59	4.54
query36	0.67	0.51	0.48
query37	0.09	0.06	0.06
query38	0.06	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.61 s
Total hot run time: 30.94 s

eldenmoon
eldenmoon reviewed Mar 4, 2025
View reviewed changes
@doris-robot
Copy link

doris-robot commented Mar 4, 2025

BE UT Coverage Report

Increment line coverage 35.00% (7/20) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.83% (12239/26706)
Line Coverage 35.35% (103520/292846)
Region Coverage 34.51% (53035/153693)
Branch Coverage 30.22% (26878/88928)

@amorynan
Copy link
Contributor Author

amorynan commented Mar 4, 2025

run buildall

@amorynan
Copy link
Contributor Author

amorynan commented Mar 4, 2025

run buildall

@amorynan
Copy link
Contributor Author

amorynan commented Mar 4, 2025

run buildall

@amorynan amorynan requested review from csun5285 and eldenmoon March 4, 2025 13:54
@doris-robot
Copy link

doris-robot commented Mar 4, 2025

TPC-H: Total hot run time: 31897 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 52223fbf7e278bcb141aee89bf4cc4d6a723e57e, data reload: false

------ Round 1 ----------------------------------
q1	17652	5287	5094	5094
q2	2051	305	190	190
q3	10417	1233	764	764
q4	10204	1018	530	530
q5	7504	2397	2381	2381
q6	205	174	136	136
q7	918	746	604	604
q8	9307	1323	1121	1121
q9	4942	4894	4916	4894
q10	6825	2327	1869	1869
q11	482	277	263	263
q12	348	352	224	224
q13	17794	3687	3055	3055
q14	242	233	209	209
q15	509	468	452	452
q16	636	623	597	597
q17	580	880	351	351
q18	6823	6166	6126	6126
q19	1296	944	567	567
q20	325	327	194	194
q21	2886	2174	1978	1978
q22	360	337	298	298
Total cold run time: 102306 ms
Total hot run time: 31897 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5166	5118	5103	5103
q2	232	335	230	230
q3	2179	2659	2323	2323
q4	1475	1858	1364	1364
q5	4254	4116	4144	4116
q6	214	168	128	128
q7	1872	1829	1714	1714
q8	2637	2624	2646	2624
q9	7276	7247	7223	7223
q10	3033	3183	2814	2814
q11	584	508	488	488
q12	710	785	653	653
q13	3392	3873	3242	3242
q14	275	294	284	284
q15	503	475	471	471
q16	654	708	645	645
q17	1157	1625	1338	1338
q18	7639	7342	7174	7174
q19	820	852	817	817
q20	1993	2037	1874	1874
q21	5600	5033	4785	4785
q22	605	562	538	538
Total cold run time: 52270 ms
Total hot run time: 49948 ms

@doris-robot
Copy link

doris-robot commented Mar 4, 2025

TPC-DS: Total hot run time: 190256 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 52223fbf7e278bcb141aee89bf4cc4d6a723e57e, data reload: false

query1	1299	950	973	950
query2	6261	1890	1895	1890
query3	11179	4502	4418	4418
query4	54426	25459	22938	22938
query5	5129	576	483	483
query6	360	178	177	177
query7	4938	504	289	289
query8	299	252	235	235
query9	5923	2631	2621	2621
query10	440	295	263	263
query11	15184	15052	14808	14808
query12	156	110	106	106
query13	1067	510	403	403
query14	10235	6774	6518	6518
query15	215	201	175	175
query16	7121	663	531	531
query17	1082	748	598	598
query18	1573	428	331	331
query19	207	214	165	165
query20	129	126	122	122
query21	207	129	111	111
query22	4582	4416	4539	4416
query23	33958	33384	33460	33384
query24	5725	2439	2485	2439
query25	461	459	409	409
query26	717	277	155	155
query27	1840	485	344	344
query28	3234	2482	2443	2443
query29	585	552	429	429
query30	224	186	165	165
query31	870	870	849	849
query32	81	62	62	62
query33	459	362	306	306
query34	778	862	508	508
query35	797	847	787	787
query36	952	1030	884	884
query37	120	104	79	79
query38	4102	4282	4198	4198
query39	1523	1444	1450	1444
query40	229	112	113	112
query41	58	55	53	53
query42	123	105	103	103
query43	510	510	487	487
query44	1331	798	804	798
query45	182	171	173	171
query46	886	1055	649	649
query47	1844	1855	1795	1795
query48	395	413	315	315
query49	707	516	413	413
query50	709	755	428	428
query51	4236	4363	4260	4260
query52	106	108	97	97
query53	237	262	192	192
query54	487	505	430	430
query55	86	78	79	78
query56	283	269	254	254
query57	1149	1171	1169	1169
query58	252	253	253	253
query59	2694	2844	2720	2720
query60	305	269	251	251
query61	121	117	120	117
query62	745	746	695	695
query63	233	190	190	190
query64	1945	1049	677	677
query65	3331	3249	3122	3122
query66	724	401	295	295
query67	15839	15606	15284	15284
query68	7075	900	499	499
query69	536	294	266	266
query70	1196	1162	1115	1115
query71	491	296	270	270
query72	5876	3656	3895	3656
query73	1358	744	353	353
query74	8959	9156	8623	8623
query75	3848	3137	2712	2712
query76	4158	1181	751	751
query77	656	377	277	277
query78	10034	10255	9352	9352
query79	2470	840	592	592
query80	611	526	451	451
query81	505	278	245	245
query82	556	124	98	98
query83	171	166	149	149
query84	292	91	74	74
query85	760	417	297	297
query86	379	303	276	276
query87	4472	4465	4284	4284
query88	3765	2245	2219	2219
query89	402	323	284	284
query90	1803	202	197	197
query91	137	141	106	106
query92	78	129	60	60
query93	1900	1063	578	578
query94	653	414	315	315
query95	357	268	259	259
query96	483	576	269	269
query97	3365	3398	3314	3314
query98	229	207	213	207
query99	1673	1380	1267	1267
Total cold run time: 297433 ms
Total hot run time: 190256 ms

@doris-robot
Copy link

doris-robot commented Mar 4, 2025

ClickBench: Total hot run time: 30.41 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 52223fbf7e278bcb141aee89bf4cc4d6a723e57e, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.03
query3	0.24	0.06	0.07
query4	1.63	0.10	0.10
query5	0.57	0.54	0.56
query6	1.19	0.72	0.72
query7	0.02	0.01	0.02
query8	0.04	0.02	0.03
query9	0.57	0.53	0.53
query10	0.57	0.57	0.57
query11	0.16	0.11	0.12
query12	0.14	0.11	0.12
query13	0.62	0.60	0.59
query14	2.78	2.67	2.82
query15	0.93	0.86	0.86
query16	0.38	0.39	0.37
query17	1.04	1.03	1.06
query18	0.22	0.21	0.21
query19	1.91	1.80	1.96
query20	0.01	0.01	0.01
query21	15.35	0.88	0.54
query22	0.73	1.01	0.61
query23	15.24	1.41	0.63
query24	7.26	1.61	0.47
query25	0.54	0.14	0.07
query26	0.63	0.17	0.14
query27	0.05	0.05	0.05
query28	9.06	0.91	0.43
query29	12.62	3.92	3.32
query30	0.24	0.09	0.06
query31	2.83	0.59	0.39
query32	3.22	0.54	0.46
query33	3.10	3.04	3.06
query34	15.52	5.14	4.52
query35	4.65	4.55	4.53
query36	0.65	0.50	0.49
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.11
query41	0.08	0.02	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.31 s
Total hot run time: 30.41 s

@amorynan
Copy link
Contributor Author

amorynan commented Mar 5, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 5, 2025

TPC-H: Total hot run time: 32479 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b2c1744e7a465926bed0a4f912d1910008b6d566, data reload: false

------ Round 1 ----------------------------------
q1	17595	5317	5111	5111
q2	2072	319	172	172
q3	10498	1289	727	727
q4	10243	1026	526	526
q5	7672	2422	2381	2381
q6	193	168	136	136
q7	918	755	599	599
q8	9291	1307	1095	1095
q9	5025	4939	4647	4647
q10	6816	2321	1892	1892
q11	508	282	262	262
q12	356	356	228	228
q13	17783	3706	3034	3034
q14	224	247	211	211
q15	544	502	492	492
q16	642	614	584	584
q17	586	871	356	356
q18	6666	6432	6372	6372
q19	1580	968	551	551
q20	330	315	191	191
q21	2802	2181	1929	1929
q22	1078	1028	983	983
Total cold run time: 103422 ms
Total hot run time: 32479 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5172	5142	5151	5142
q2	239	330	230	230
q3	2184	2677	2308	2308
q4	1420	1831	1401	1401
q5	4244	4127	4175	4127
q6	209	165	124	124
q7	1892	1918	1768	1768
q8	2621	2518	2524	2518
q9	7323	7246	7286	7246
q10	3063	3283	2766	2766
q11	573	506	503	503
q12	690	786	577	577
q13	3349	3939	3246	3246
q14	296	327	281	281
q15	518	487	471	471
q16	663	669	670	669
q17	1159	1633	1324	1324
q18	7838	7609	7576	7576
q19	813	826	950	826
q20	2006	2022	1879	1879
q21	5576	5144	4759	4759
q22	1118	1081	1035	1035
Total cold run time: 52966 ms
Total hot run time: 50776 ms

@doris-robot
Copy link

doris-robot commented Mar 5, 2025

TPC-DS: Total hot run time: 192433 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b2c1744e7a465926bed0a4f912d1910008b6d566, data reload: false

query1	1382	1026	1008	1008
query2	6110	1949	1913	1913
query3	11124	4649	4635	4635
query4	25792	23726	25945	23726
query5	4369	677	482	482
query6	297	209	184	184
query7	3999	502	285	285
query8	280	235	223	223
query9	8477	2551	2531	2531
query10	459	324	249	249
query11	15741	15232	14825	14825
query12	157	107	107	107
query13	1568	534	399	399
query14	8925	7035	6476	6476
query15	226	188	180	180
query16	7744	692	477	477
query17	1159	741	591	591
query18	2072	419	321	321
query19	196	190	166	166
query20	135	128	122	122
query21	203	124	102	102
query22	4432	4566	4430	4430
query23	34379	33519	33391	33391
query24	7795	2419	2409	2409
query25	494	468	404	404
query26	1178	270	154	154
query27	2319	528	333	333
query28	4181	2487	2461	2461
query29	696	570	434	434
query30	273	226	190	190
query31	898	865	781	781
query32	72	61	61	61
query33	560	358	305	305
query34	783	900	509	509
query35	806	876	784	784
query36	966	986	945	945
query37	118	129	78	78
query38	4205	4345	4142	4142
query39	1494	1400	1442	1400
query40	202	117	103	103
query41	51	55	52	52
query42	113	105	103	103
query43	526	505	492	492
query44	1315	824	811	811
query45	186	177	177	177
query46	867	1034	634	634
query47	1782	1864	1802	1802
query48	404	425	339	339
query49	764	494	422	422
query50	709	743	408	408
query51	4278	4260	4252	4252
query52	106	102	102	102
query53	228	265	196	196
query54	510	489	416	416
query55	87	90	80	80
query56	273	267	254	254
query57	1215	1185	1122	1122
query58	264	257	238	238
query59	2862	3068	2731	2731
query60	288	278	264	264
query61	127	118	118	118
query62	784	775	712	712
query63	242	185	193	185
query64	4182	1133	790	790
query65	4531	4465	4404	4404
query66	1017	455	303	303
query67	16030	15471	15258	15258
query68	9054	887	502	502
query69	472	293	266	266
query70	1237	1150	1117	1117
query71	457	283	256	256
query72	5582	3579	3711	3579
query73	795	739	337	337
query74	8980	9232	8921	8921
query75	3931	3208	2663	2663
query76	3724	1186	760	760
query77	790	351	284	284
query78	9891	10151	9371	9371
query79	1998	885	576	576
query80	718	513	437	437
query81	475	254	225	225
query82	662	126	97	97
query83	192	163	166	163
query84	269	99	72	72
query85	763	345	303	303
query86	336	293	281	281
query87	4441	4488	4278	4278
query88	2870	2203	2160	2160
query89	422	311	292	292
query90	1871	193	195	193
query91	136	135	114	114
query92	68	59	54	54
query93	1166	1043	583	583
query94	649	417	295	295
query95	354	268	252	252
query96	474	561	276	276
query97	3305	3402	3298	3298
query98	212	241	201	201
query99	1429	1404	1246	1246
Total cold run time: 277730 ms
Total hot run time: 192433 ms

@doris-robot
Copy link

doris-robot commented Mar 5, 2025

ClickBench: Total hot run time: 31.52 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b2c1744e7a465926bed0a4f912d1910008b6d566, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.03	0.04
query3	0.24	0.06	0.07
query4	1.62	0.10	0.10
query5	0.55	0.55	0.54
query6	1.20	0.72	0.73
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.57	0.53	0.53
query10	0.55	0.57	0.58
query11	0.16	0.11	0.10
query12	0.15	0.12	0.11
query13	0.61	0.61	0.60
query14	2.71	2.74	2.67
query15	0.92	0.85	0.84
query16	0.37	0.39	0.38
query17	1.02	1.01	1.01
query18	0.21	0.20	0.19
query19	1.90	1.79	1.97
query20	0.01	0.01	0.01
query21	15.36	0.89	0.52
query22	0.75	1.21	0.71
query23	14.88	1.42	0.62
query24	6.67	1.38	1.95
query25	0.53	0.29	0.20
query26	0.62	0.16	0.14
query27	0.05	0.05	0.06
query28	10.09	0.86	0.44
query29	12.55	4.00	3.29
query30	0.25	0.09	0.06
query31	2.82	0.60	0.38
query32	3.24	0.55	0.47
query33	3.07	2.98	3.20
query34	15.80	5.09	4.59
query35	4.51	4.57	4.54
query36	0.66	0.49	0.48
query37	0.10	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.32 s
Total hot run time: 31.52 s

eldenmoon
eldenmoon previously approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eldenmoon
eldenmoon approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

PR approved by at least one committer and no changes requested.

csun5285
csun5285 approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon merged commit 1182402 into apache:master Mar 6, 2025
25 of 27 checks passed
amorynan added a commit to amorynan/doris that referenced this pull request Mar 6, 2025
@amorynan
[fix](jsonb) fix invalid jsonb value write into segment file which ma…
0070509 
…ke select core (apache#48625)

fix invalid jsonb value write into segment file which make select core,
so we add a check for jsonb value when convert_to_olap which value will
be written into segment file
@amorynan amorynan mentioned this pull request Mar 6, 2025
Merged
16 tasks
amorynan added a commit to amorynan/doris that referenced this pull request Mar 6, 2025
@amorynan
[fix](jsonb) fix invalid jsonb value write into segment file which ma…
4665a5a 
…ke select core (apache#48625)

fix invalid jsonb value write into segment file which make select core,
so we add a check for jsonb value when convert_to_olap which value will
be written into segment file
@amorynan amorynan mentioned this pull request Mar 6, 2025
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request Mar 6, 2025
[cherry-pick](jsonb) add a check for jsonb value to avoid invalid jso…
7b2899a 
…nb value write into segment file (#48729)

…ke select core (#48625)

fix invalid jsonb value write into segment file which make select core,
so we add a check for jsonb value when convert_to_olap which value will
be written into segment file
dataroaring pushed a commit that referenced this pull request Mar 6, 2025
@amorynan
[cherry-pick](jsonb) fix invalid jsonb value write into segment file …
2fdc378 
…which make be crash (#48731)

…ke select core (#48625)

fix invalid jsonb value write into segment file which make select core,
so we add a check for jsonb value when convert_to_olap which value will
be written into segment file

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [x] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@bobhan1 bobhan1 mentioned this pull request Mar 14, 2025
Merged
16 tasks
zhannngchen pushed a commit that referenced this pull request Mar 17, 2025
@bobhan1
[Fix](partial update) use correct default value for missing columns i…
ac5c37c 
…n partial update (#49066)

### What problem does this PR solve?


related PR: #48625
In partial update, we should fill the columns which is not nullable and
doesn't have user defined default value with its type's default value
when the row's delete sign is marked.
bobhan1 added a commit to bobhan1/doris that referenced this pull request Mar 17, 2025
@bobhan1
[Fix](partial update) use correct default value for missing columns i…
c73d89d 
…n partial update (apache#49066)

related PR: apache#48625
In partial update, we should fill the columns which is not nullable and
doesn't have user defined default value with its type's default value
when the row's delete sign is marked.
bobhan1 added a commit to bobhan1/doris that referenced this pull request Mar 18, 2025
@bobhan1
[Fix](partial update) use correct default value for missing columns i…
6537d98 
…n partial update (apache#49066)

related PR: apache#48625
In partial update, we should fill the columns which is not nullable and
doesn't have user defined default value with its type's default value
when the row's delete sign is marked.
@shuke987 shuke987 removed the dev/2.1.x label May 7, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@amorynan @koarz
[fix](jsonb) fix invalid jsonb value write into segment file which ma…
4c5319e 
…ke select core (apache#48625)

fix invalid jsonb value write into segment file which make select core,
so we add a check for jsonb value when convert_to_olap which value will
be written into segment file
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@bobhan1 @koarz
[Fix](partial update) use correct default value for missing columns i…
14bba90 
…n partial update (apache#49066)

### What problem does this PR solve?


related PR: apache#48625
In partial update, we should fill the columns which is not nullable and
doesn't have user defined default value with its type's default value
when the row's delete sign is marked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eldenmoon eldenmoon eldenmoon approved these changes

+1 more reviewer

@csun5285 csun5285 csun5285 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.5-merged p0_b reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@amorynan @hello-stephen @doris-robot @eldenmoon @csun5285 @yiguolei @shuke987 @wm1581066 @dataroaring