Skip to content

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Mar 14, 2025

What problem does this PR solve?

related PR: #48625
In partial update, we should fill the columns which is not nullable and doesn't have user defined default value with its type's default value when the row's delete sign is marked.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1 bobhan1 force-pushed the fix-pu-missing-col-default-val branch from 0f6b3bf to 3f50733 Compare March 14, 2025 05:19
zhannngchen
zhannngchen previously approved these changes Mar 14, 2025
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 14, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 14, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 14, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 14, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 32430 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d4fb7c7a77b66c52c7dad2190edec55ea05ba15f, data reload: false

------ Round 1 ----------------------------------
q1	17588	5272	5101	5101
q2	2054	301	158	158
q3	10426	1284	742	742
q4	10219	1027	522	522
q5	7619	2324	2373	2324
q6	190	164	131	131
q7	905	735	607	607
q8	9294	1281	1128	1128
q9	4848	4807	4616	4616
q10	6812	2305	1906	1906
q11	481	269	262	262
q12	361	358	222	222
q13	17769	3692	3078	3078
q14	234	222	206	206
q15	541	491	477	477
q16	617	604	581	581
q17	586	871	342	342
q18	6735	6525	6381	6381
q19	1222	939	573	573
q20	340	354	202	202
q21	2861	2125	1892	1892
q22	1014	991	979	979
Total cold run time: 102716 ms
Total hot run time: 32430 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5288	5262	5232	5232
q2	243	332	240	240
q3	2161	2677	2341	2341
q4	1424	1807	1401	1401
q5	4241	4112	4221	4112
q6	206	165	127	127
q7	1868	1848	1755	1755
q8	2630	2589	2573	2573
q9	7221	7159	7213	7159
q10	2994	3239	2771	2771
q11	582	511	485	485
q12	722	834	609	609
q13	3453	3975	3320	3320
q14	288	299	290	290
q15	527	471	486	471
q16	649	680	663	663
q17	1173	1591	1356	1356
q18	7753	7498	7607	7498
q19	872	924	1146	924
q20	2009	2024	1848	1848
q21	5727	5019	4753	4753
q22	1131	1050	1027	1027
Total cold run time: 53162 ms
Total hot run time: 50955 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191649 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d4fb7c7a77b66c52c7dad2190edec55ea05ba15f, data reload: false

query1	1383	990	966	966
query2	6261	1865	1824	1824
query3	11013	4417	4367	4367
query4	55236	24681	23313	23313
query5	4978	557	462	462
query6	329	190	181	181
query7	4869	511	288	288
query8	297	241	228	228
query9	5602	2554	2550	2550
query10	434	307	253	253
query11	15227	15056	14941	14941
query12	158	115	109	109
query13	1035	505	410	410
query14	10566	6699	6348	6348
query15	201	196	183	183
query16	7137	659	518	518
query17	1088	729	615	615
query18	1523	436	316	316
query19	197	201	178	178
query20	128	117	124	117
query21	209	133	117	117
query22	4404	4545	4248	4248
query23	34041	33299	33451	33299
query24	5639	2459	2388	2388
query25	435	492	414	414
query26	690	274	156	156
query27	1772	509	358	358
query28	2887	2472	2478	2472
query29	569	574	427	427
query30	276	233	192	192
query31	883	871	782	782
query32	74	68	60	60
query33	446	352	302	302
query34	781	866	504	504
query35	800	834	780	780
query36	966	1008	911	911
query37	121	103	76	76
query38	4294	4328	4300	4300
query39	1515	1450	1444	1444
query40	210	114	102	102
query41	51	54	51	51
query42	123	111	105	105
query43	492	507	489	489
query44	1343	829	799	799
query45	177	173	162	162
query46	853	1041	654	654
query47	1871	1909	1811	1811
query48	400	425	313	313
query49	708	527	434	434
query50	717	767	414	414
query51	4305	4324	4168	4168
query52	107	103	96	96
query53	230	254	211	211
query54	493	501	413	413
query55	83	78	83	78
query56	256	269	280	269
query57	1187	1210	1110	1110
query58	270	250	259	250
query59	2630	2749	2700	2700
query60	294	295	269	269
query61	125	120	120	120
query62	749	765	666	666
query63	234	194	196	194
query64	1627	1038	703	703
query65	4543	4339	4318	4318
query66	695	387	292	292
query67	15779	15551	15367	15367
query68	7121	821	508	508
query69	535	300	264	264
query70	1149	1143	1111	1111
query71	469	285	266	266
query72	5873	3620	3731	3620
query73	1380	761	345	345
query74	8981	9093	8697	8697
query75	3797	3168	2726	2726
query76	4088	1215	730	730
query77	656	365	284	284
query78	10148	10009	9369	9369
query79	2937	846	584	584
query80	699	508	449	449
query81	492	260	216	216
query82	651	124	93	93
query83	259	165	157	157
query84	285	99	71	71
query85	759	351	367	351
query86	380	290	285	285
query87	4403	4484	4510	4484
query88	3678	2232	2221	2221
query89	408	310	282	282
query90	1803	207	206	206
query91	152	145	108	108
query92	80	57	56	56
query93	1983	1061	573	573
query94	663	416	297	297
query95	341	275	259	259
query96	491	575	274	274
query97	3345	3368	3288	3288
query98	220	204	205	204
query99	1436	1385	1316	1316
Total cold run time: 298678 ms
Total hot run time: 191649 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.58 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d4fb7c7a77b66c52c7dad2190edec55ea05ba15f, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.03
query3	0.23	0.07	0.06
query4	1.62	0.10	0.10
query5	0.56	0.55	0.54
query6	1.18	0.72	0.71
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.59	0.53	0.52
query10	0.57	0.59	0.59
query11	0.15	0.11	0.10
query12	0.14	0.11	0.11
query13	0.62	0.61	0.60
query14	2.81	2.80	2.71
query15	0.93	0.84	0.84
query16	0.38	0.37	0.39
query17	1.03	1.06	1.03
query18	0.22	0.20	0.20
query19	1.86	1.77	1.95
query20	0.01	0.01	0.01
query21	15.36	0.90	0.54
query22	0.75	1.29	0.92
query23	14.71	1.40	0.63
query24	7.39	2.29	0.37
query25	0.52	0.23	0.14
query26	0.68	0.17	0.14
query27	0.05	0.05	0.05
query28	9.24	0.86	0.42
query29	12.53	3.96	3.28
query30	0.25	0.09	0.06
query31	2.83	0.59	0.38
query32	3.22	0.54	0.47
query33	2.96	2.99	3.04
query34	15.86	5.15	4.50
query35	4.52	4.53	4.55
query36	0.66	0.50	0.49
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.03
query40	0.17	0.13	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.08 s
Total hot run time: 30.58 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 47.97% (12825/26738)
Line Coverage 37.36% (109453/292978)
Region Coverage 36.48% (56073/153718)
Branch Coverage 31.77% (28259/88952)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 15, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@zhannngchen zhannngchen merged commit ac5c37c into apache:master Mar 17, 2025
27 of 28 checks passed
bobhan1 added a commit to bobhan1/doris that referenced this pull request Mar 17, 2025
…n partial update (apache#49066)

related PR: apache#48625
In partial update, we should fill the columns which is not nullable and
doesn't have user defined default value with its type's default value
when the row's delete sign is marked.
bobhan1 added a commit to bobhan1/doris that referenced this pull request Mar 18, 2025
…n partial update (apache#49066)

related PR: apache#48625
In partial update, we should fill the columns which is not nullable and
doesn't have user defined default value with its type's default value
when the row's delete sign is marked.
dataroaring pushed a commit that referenced this pull request Mar 19, 2025
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
@shuke987 shuke987 removed the dev/2.1.x label May 7, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
…n partial update (apache#49066)

### What problem does this PR solve?


related PR: apache#48625
In partial update, we should fill the columns which is not nullable and
doesn't have user defined default value with its type's default value
when the row's delete sign is marked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants