Skip to content

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Mar 18, 2025

pick #49066

…n partial update (apache#49066)

related PR: apache#48625
In partial update, we should fill the columns which is not nullable and
doesn't have user defined default value with its type's default value
when the row's delete sign is marked.
@bobhan1 bobhan1 requested a review from dataroaring as a code owner March 18, 2025 13:40
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 18, 2025

run buildall

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.88% (10168/26154)
Line Coverage 30.30% (86695/286085)
Region Coverage 29.35% (44536/151734)
Branch Coverage 25.88% (22653/87546)

@doris-robot
Copy link

TPC-H: Total hot run time: 39948 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6537d988b9b7a0df41d21221c75daf8e7bf6a127, data reload: false

------ Round 1 ----------------------------------
q1	17608	6736	6596	6596
q2	2049	178	198	178
q3	10553	1070	1157	1070
q4	10577	745	782	745
q5	7783	2831	2796	2796
q6	222	134	136	134
q7	954	620	607	607
q8	9589	1943	2010	1943
q9	6765	6362	6418	6362
q10	7068	2292	2260	2260
q11	471	263	267	263
q12	398	222	217	217
q13	17788	2960	3006	2960
q14	241	209	220	209
q15	498	479	474	474
q16	672	598	584	584
q17	970	532	611	532
q18	7199	6700	6725	6700
q19	1393	1115	986	986
q20	475	208	207	207
q21	3955	3187	3138	3138
q22	1045	989	987	987
Total cold run time: 108273 ms
Total hot run time: 39948 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6604	6561	6548	6548
q2	326	232	232	232
q3	2894	2759	2878	2759
q4	1998	1740	1787	1740
q5	5787	5815	5772	5772
q6	210	129	128	128
q7	2210	1836	1802	1802
q8	3391	3567	3514	3514
q9	8725	8887	8837	8837
q10	3572	3515	3510	3510
q11	585	503	490	490
q12	806	591	601	591
q13	9429	3179	3200	3179
q14	293	264	271	264
q15	513	469	457	457
q16	692	645	658	645
q17	1858	1590	1598	1590
q18	8225	7702	7685	7685
q19	1655	1559	1559	1559
q20	2050	1858	1889	1858
q21	5615	5313	5373	5313
q22	1107	1047	1054	1047
Total cold run time: 68545 ms
Total hot run time: 59520 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197972 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6537d988b9b7a0df41d21221c75daf8e7bf6a127, data reload: false

query1	1315	903	898	898
query2	6228	2047	2003	2003
query3	10821	4334	4163	4163
query4	61148	28724	23608	23608
query5	5189	476	464	464
query6	418	179	175	175
query7	5508	321	313	313
query8	302	244	230	230
query9	8548	2695	2642	2642
query10	464	273	266	266
query11	17700	15302	15723	15302
query12	163	107	105	105
query13	1417	468	453	453
query14	10915	7337	7711	7337
query15	201	181	184	181
query16	7220	521	547	521
query17	1172	596	604	596
query18	1852	329	325	325
query19	213	176	162	162
query20	125	116	113	113
query21	216	107	113	107
query22	4829	4408	4547	4408
query23	34577	33808	34592	33808
query24	6297	2903	3029	2903
query25	551	458	453	453
query26	663	169	172	169
query27	1745	352	357	352
query28	4229	2506	2485	2485
query29	705	480	479	479
query30	238	163	168	163
query31	1029	830	852	830
query32	66	57	57	57
query33	447	310	302	302
query34	935	503	511	503
query35	845	736	728	728
query36	1105	944	988	944
query37	124	71	70	70
query38	4057	4035	4094	4035
query39	1530	1659	1540	1540
query40	204	100	105	100
query41	49	51	47	47
query42	114	103	101	101
query43	531	493	509	493
query44	1208	820	826	820
query45	190	171	173	171
query46	1164	740	729	729
query47	2047	1894	1931	1894
query48	495	387	397	387
query49	721	410	408	408
query50	881	435	429	429
query51	7377	7195	7250	7195
query52	104	98	92	92
query53	256	184	190	184
query54	596	476	488	476
query55	83	79	79	79
query56	274	255	266	255
query57	1292	1215	1181	1181
query58	217	229	229	229
query59	3170	2976	3029	2976
query60	280	266	258	258
query61	112	119	104	104
query62	786	670	667	667
query63	223	190	187	187
query64	1405	671	668	668
query65	3284	3221	3220	3220
query66	718	292	303	292
query67	16031	15469	15446	15446
query68	4045	593	568	568
query69	443	272	270	270
query70	1161	1177	1153	1153
query71	352	264	264	264
query72	6100	4027	3990	3990
query73	753	349	346	346
query74	10490	8906	9132	8906
query75	3356	2809	2672	2672
query76	1989	1149	1124	1124
query77	500	278	281	278
query78	10596	9637	9574	9574
query79	1651	601	612	601
query80	898	433	420	420
query81	522	243	243	243
query82	1280	90	86	86
query83	246	145	142	142
query84	277	84	93	84
query85	916	328	295	295
query86	323	302	304	302
query87	4506	4306	4270	4270
query88	3789	2438	2427	2427
query89	426	290	289	289
query90	1988	191	186	186
query91	188	148	151	148
query92	61	50	55	50
query93	1934	560	568	560
query94	759	292	292	292
query95	371	265	260	260
query96	617	295	294	294
query97	3325	3131	3165	3131
query98	220	225	199	199
query99	1543	1301	1267	1267
Total cold run time: 314544 ms
Total hot run time: 197972 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.91 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6537d988b9b7a0df41d21221c75daf8e7bf6a127, data reload: false

query1	0.03	0.02	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.07
query4	1.63	0.10	0.10
query5	0.51	0.49	0.50
query6	1.14	0.72	0.73
query7	0.02	0.02	0.01
query8	0.04	0.02	0.03
query9	0.57	0.50	0.50
query10	0.55	0.55	0.56
query11	0.14	0.11	0.10
query12	0.14	0.11	0.11
query13	0.60	0.59	0.60
query14	2.73	2.84	2.75
query15	0.91	0.84	0.83
query16	0.38	0.38	0.37
query17	1.01	0.96	1.05
query18	0.24	0.23	0.23
query19	1.90	1.87	1.94
query20	0.01	0.01	0.01
query21	15.36	0.57	0.57
query22	2.33	2.21	1.50
query23	17.14	0.80	0.75
query24	2.93	1.02	1.76
query25	0.26	0.25	0.14
query26	0.45	0.14	0.14
query27	0.04	0.05	0.04
query28	9.90	0.55	0.53
query29	12.58	3.25	3.25
query30	0.24	0.07	0.07
query31	2.86	0.39	0.39
query32	3.22	0.46	0.45
query33	2.97	3.03	3.01
query34	17.04	4.51	4.44
query35	4.54	4.51	4.49
query36	0.68	0.48	0.47
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.85 s
Total hot run time: 31.91 s

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 19, 2025

run cloud_p0

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 19, 2025

run external

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 19, 2025

run cloud_p0

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit a127aa1 into apache:branch-3.0 Mar 19, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants