Skip to content

branch-2.1-pick: [Fix](partial update) use correct default value for missing columns in partial update (#49066) #49146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bobhan1 wants to merge 3 commits into from
Closed

branch-2.1-pick: [Fix](partial update) use correct default value for missing columns in partial update (#49066) #49146

bobhan1 wants to merge 3 commits into from

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Mar 17, 2025

pick #49066

@bobhan1
[Fix](partial update) use correct default value for missing columns i…
c73d89d 
…n partial update (apache#49066)

related PR: apache#48625
In partial update, we should fill the columns which is not nullable and
doesn't have user defined default value with its type's default value
when the row's delete sign is marked.
@bobhan1 bobhan1 requested a review from yiguolei as a code owner March 17, 2025 08:33
@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 17, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 17, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 37.31% (9831/26347)
Line Coverage 28.99% (82305/283914)
Region Coverage 27.61% (42224/152950)
Branch Coverage 24.37% (21499/88220)

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 17, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 17, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 37.31% (9831/26347)
Line Coverage 28.99% (82315/283914)
Region Coverage 27.62% (42242/152950)
Branch Coverage 24.37% (21503/88220)

@bobhan1 bobhan1 closed this Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei Awaiting requested review from yiguolei yiguolei is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobhan1 @hello-stephen @doris-robot