Skip to content

[fix](Nereids) fix initcap fe fold constant #49061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 2 commits into from
Mar 17, 2025
Merged

[fix](Nereids) fix initcap fe fold constant #49061

morrySnow merged 2 commits into from
Mar 17, 2025

Conversation

@LiBinfeng-01
Copy link
Contributor

@LiBinfeng-01 LiBinfeng-01 commented Mar 14, 2025 •
edited by morrySnow
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #40441

Problem Summary:

Release note

initcap should upper first character in all words

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Mar 14, 2025

run buildall

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Mar 14, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 14, 2025

TPC-H: Total hot run time: 32829 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b84d352551cc71de6661bdd41ed0d850f39d20ed, data reload: false

------ Round 1 ----------------------------------
q1	13509	5205	5129	5129
q2	1871	283	162	162
q3	4119	1288	715	715
q4	703	1033	532	532
q5	2154	2338	2281	2281
q6	205	170	135	135
q7	894	774	617	617
q8	1100	1138	1153	1138
q9	4900	4799	4888	4799
q10	2235	2366	1920	1920
q11	422	288	251	251
q12	318	355	226	226
q13	3414	3710	3092	3092
q14	228	230	214	214
q15	563	493	497	493
q16	620	615	595	595
q17	567	869	360	360
q18	6653	6646	6449	6449
q19	550	952	566	566
q20	336	328	198	198
q21	4901	2192	1956	1956
q22	1090	1032	1001	1001
Total cold run time: 51352 ms
Total hot run time: 32829 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5171	5166	5159	5159
q2	239	327	230	230
q3	2145	2863	2323	2323
q4	1429	1844	1386	1386
q5	4277	4176	4166	4166
q6	208	164	125	125
q7	1899	1844	1649	1649
q8	2531	2537	2422	2422
q9	6904	6839	6752	6752
q10	2905	3090	2698	2698
q11	588	493	493	493
q12	648	737	605	605
q13	3305	3702	3085	3085
q14	264	279	263	263
q15	533	489	483	483
q16	657	670	627	627
q17	1096	1506	1364	1364
q18	7351	7157	7253	7157
q19	804	810	946	810
q20	1917	1929	1827	1827
q21	5250	4797	4744	4744
q22	1068	1057	1005	1005
Total cold run time: 51189 ms
Total hot run time: 49373 ms

@doris-robot
Copy link

doris-robot commented Mar 14, 2025

TPC-DS: Total hot run time: 186735 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b84d352551cc71de6661bdd41ed0d850f39d20ed, data reload: false

query1	1032	387	373	373
query2	6538	1912	1878	1878
query3	6793	212	217	212
query4	26762	24025	23425	23425
query5	5608	687	486	486
query6	303	199	183	183
query7	4659	525	310	310
query8	304	253	235	235
query9	8649	2637	2634	2634
query10	500	317	258	258
query11	15515	15236	16358	15236
query12	167	119	106	106
query13	1660	525	417	417
query14	11093	7162	7345	7162
query15	260	190	180	180
query16	7808	626	456	456
query17	1551	753	574	574
query18	2042	407	324	324
query19	255	185	158	158
query20	125	119	119	119
query21	217	121	103	103
query22	4409	4274	3985	3985
query23	33959	33119	33135	33119
query24	6854	2404	2460	2404
query25	504	473	395	395
query26	1199	265	155	155
query27	2024	487	382	382
query28	3885	2433	2397	2397
query29	717	567	425	425
query30	289	215	190	190
query31	934	889	743	743
query32	73	62	65	62
query33	552	358	316	316
query34	779	840	528	528
query35	786	809	758	758
query36	950	987	903	903
query37	118	101	78	78
query38	4314	4169	4096	4096
query39	1442	1382	1393	1382
query40	214	116	102	102
query41	55	54	50	50
query42	126	104	105	104
query43	495	499	471	471
query44	1323	794	783	783
query45	179	169	163	163
query46	851	1045	642	642
query47	1748	1802	1721	1721
query48	377	414	296	296
query49	788	532	438	438
query50	674	727	411	411
query51	4157	4222	4114	4114
query52	106	110	106	106
query53	253	262	193	193
query54	491	490	417	417
query55	84	81	79	79
query56	263	258	263	258
query57	1177	1151	1095	1095
query58	250	228	232	228
query59	2635	2554	2406	2406
query60	282	278	249	249
query61	117	112	113	112
query62	782	760	691	691
query63	238	194	192	192
query64	4272	976	664	664
query65	4504	4344	4392	4344
query66	985	398	302	302
query67	15786	15731	15295	15295
query68	8286	875	496	496
query69	510	325	265	265
query70	1195	1151	1129	1129
query71	496	293	277	277
query72	5629	3677	3934	3677
query73	787	730	348	348
query74	8945	9308	8733	8733
query75	3941	3194	2707	2707
query76	3734	1188	779	779
query77	770	376	289	289
query78	10074	10240	9263	9263
query79	2882	802	615	615
query80	628	522	440	440
query81	476	268	226	226
query82	680	131	95	95
query83	175	165	159	159
query84	235	98	74	74
query85	737	345	307	307
query86	336	300	292	292
query87	4400	4453	4411	4411
query88	3020	2268	2292	2268
query89	401	316	281	281
query90	1952	210	211	210
query91	143	141	108	108
query92	76	62	57	57
query93	1159	1058	586	586
query94	658	421	301	301
query95	340	262	256	256
query96	478	557	274	274
query97	3326	3420	3262	3262
query98	221	213	204	204
query99	1620	1430	1273	1273
Total cold run time: 277151 ms
Total hot run time: 186735 ms

@doris-robot
Copy link

doris-robot commented Mar 14, 2025

ClickBench: Total hot run time: 31.05 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b84d352551cc71de6661bdd41ed0d850f39d20ed, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.63	0.11	0.10
query5	0.56	0.54	0.56
query6	1.17	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.55	0.51
query10	0.57	0.59	0.59
query11	0.16	0.11	0.10
query12	0.14	0.11	0.10
query13	0.62	0.60	0.60
query14	2.73	2.70	2.80
query15	0.93	0.85	0.85
query16	0.38	0.40	0.38
query17	1.02	1.03	1.01
query18	0.22	0.20	0.20
query19	1.86	1.83	2.03
query20	0.01	0.02	0.01
query21	15.35	0.88	0.54
query22	0.75	1.27	0.74
query23	14.74	1.37	0.62
query24	7.48	1.67	0.87
query25	0.51	0.29	0.12
query26	0.58	0.16	0.15
query27	0.05	0.05	0.04
query28	9.25	0.78	0.42
query29	12.59	4.00	3.33
query30	0.24	0.08	0.06
query31	2.83	0.56	0.38
query32	3.23	0.53	0.47
query33	3.00	3.08	3.02
query34	15.78	5.17	4.53
query35	4.58	4.56	4.59
query36	0.66	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.02	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.02
Total cold run time: 105.07 s
Total hot run time: 31.05 s

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Mar 17, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 17, 2025

TPC-H: Total hot run time: 32409 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9c586d6df81f2ea81fbb6ead53c091c724189bca, data reload: false

------ Round 1 ----------------------------------
q1	24542	5067	5028	5028
q2	2054	316	176	176
q3	10369	1265	706	706
q4	10233	1014	558	558
q5	7534	2854	2363	2363
q6	190	165	134	134
q7	894	739	604	604
q8	9300	1290	1082	1082
q9	4984	4764	4597	4597
q10	6830	2307	1903	1903
q11	477	267	256	256
q12	353	351	223	223
q13	17774	3710	3073	3073
q14	239	241	213	213
q15	541	488	478	478
q16	612	628	577	577
q17	558	857	357	357
q18	6737	6599	6361	6361
q19	1805	957	570	570
q20	326	320	190	190
q21	2864	2114	1980	1980
q22	1064	1038	980	980
Total cold run time: 110280 ms
Total hot run time: 32409 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5234	5165	5186	5165
q2	241	328	236	236
q3	2151	2703	2274	2274
q4	1483	1849	1417	1417
q5	4304	4199	4473	4199
q6	216	168	128	128
q7	2018	1954	1811	1811
q8	2633	2754	2584	2584
q9	7194	7214	7237	7214
q10	3033	3119	2762	2762
q11	570	519	524	519
q12	721	783	649	649
q13	3541	3962	3298	3298
q14	280	283	263	263
q15	552	506	515	506
q16	677	691	628	628
q17	1138	1595	1362	1362
q18	7823	7571	7644	7571
q19	823	839	846	839
q20	1989	2053	1870	1870
q21	5463	4950	4973	4950
q22	1152	1085	1061	1061
Total cold run time: 53236 ms
Total hot run time: 51306 ms

@doris-robot
Copy link

doris-robot commented Mar 17, 2025

TPC-DS: Total hot run time: 192647 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9c586d6df81f2ea81fbb6ead53c091c724189bca, data reload: false

query1	1423	1048	1040	1040
query2	6216	1968	2011	1968
query3	11180	4731	4493	4493
query4	25818	23715	23276	23276
query5	4370	655	478	478
query6	307	202	199	199
query7	3988	499	291	291
query8	311	254	232	232
query9	8520	2654	2647	2647
query10	469	318	255	255
query11	15653	15093	14968	14968
query12	169	109	109	109
query13	1581	543	400	400
query14	10410	6866	6419	6419
query15	203	191	174	174
query16	7619	634	513	513
query17	1318	765	551	551
query18	2019	402	304	304
query19	205	176	163	163
query20	123	128	120	120
query21	209	125	109	109
query22	4604	4570	4550	4550
query23	34284	33640	33476	33476
query24	7340	2437	2418	2418
query25	481	481	395	395
query26	1270	284	153	153
query27	2044	496	329	329
query28	4391	2461	2424	2424
query29	697	597	450	450
query30	273	224	194	194
query31	924	926	799	799
query32	74	61	64	61
query33	548	368	327	327
query34	831	896	530	530
query35	859	857	750	750
query36	978	991	901	901
query37	118	107	73	73
query38	4248	4221	4423	4221
query39	1493	1435	1498	1435
query40	217	120	109	109
query41	51	51	50	50
query42	120	105	107	105
query43	520	512	484	484
query44	1355	810	826	810
query45	173	169	166	166
query46	854	1031	655	655
query47	1828	1869	1789	1789
query48	397	437	297	297
query49	765	511	429	429
query50	707	763	421	421
query51	4267	4373	4182	4182
query52	114	115	98	98
query53	233	257	183	183
query54	512	491	412	412
query55	85	83	79	79
query56	285	257	259	257
query57	1194	1169	1125	1125
query58	263	237	255	237
query59	2931	2803	2701	2701
query60	292	278	262	262
query61	121	127	152	127
query62	791	742	692	692
query63	233	193	191	191
query64	4110	1034	693	693
query65	4562	4471	4492	4471
query66	985	397	314	314
query67	16134	15771	15500	15500
query68	8846	900	507	507
query69	495	313	263	263
query70	1208	1149	1133	1133
query71	463	289	257	257
query72	5587	3551	3730	3551
query73	745	699	354	354
query74	9193	8948	8847	8847
query75	4017	3154	2691	2691
query76	3781	1249	740	740
query77	790	366	271	271
query78	10085	10205	9263	9263
query79	3226	800	580	580
query80	717	524	446	446
query81	467	259	225	225
query82	672	125	92	92
query83	200	166	154	154
query84	281	90	76	76
query85	781	356	306	306
query86	334	297	306	297
query87	4599	4511	4442	4442
query88	3398	2293	2266	2266
query89	429	321	276	276
query90	1929	217	221	217
query91	145	147	106	106
query92	77	61	60	60
query93	1548	1077	582	582
query94	675	407	303	303
query95	363	272	267	267
query96	490	573	274	274
query97	3353	3448	3311	3311
query98	220	208	199	199
query99	1425	1426	1257	1257
Total cold run time: 282206 ms
Total hot run time: 192647 ms

@doris-robot
Copy link

doris-robot commented Mar 17, 2025

ClickBench: Total hot run time: 31.43 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9c586d6df81f2ea81fbb6ead53c091c724189bca, data reload: false

query1	0.04	0.04	0.04
query2	0.14	0.10	0.10
query3	0.24	0.19	0.19
query4	1.60	0.19	0.19
query5	0.60	0.58	0.60
query6	1.18	0.73	0.73
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.60	0.51	0.52
query10	0.58	0.59	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.61	0.62
query14	2.82	2.72	2.84
query15	0.93	0.87	0.85
query16	0.38	0.38	0.38
query17	1.04	1.02	1.03
query18	0.22	0.20	0.20
query19	1.90	2.07	1.82
query20	0.02	0.01	0.01
query21	15.35	0.92	0.53
query22	0.76	1.29	0.67
query23	14.82	1.40	0.62
query24	7.35	1.34	0.85
query25	0.57	0.15	0.20
query26	0.58	0.15	0.13
query27	0.05	0.05	0.05
query28	9.41	0.93	0.45
query29	12.54	3.97	3.28
query30	0.25	0.08	0.06
query31	2.82	0.61	0.39
query32	3.22	0.57	0.48
query33	3.01	3.06	3.07
query34	15.75	5.31	4.54
query35	4.58	4.59	4.63
query36	0.68	0.51	0.50
query37	0.08	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.03
query40	0.18	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 105.51 s
Total hot run time: 31.43 s

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Mar 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2025

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 6d6c66e into apache:master Mar 17, 2025
25 of 26 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 17, 2025
[fix](Nereids) initcap constant folding should upper first character …
4865095 
…in all words (#49061)
@github-actions github-actions bot mentioned this pull request Mar 17, 2025
Closed
github-actions bot pushed a commit that referenced this pull request Mar 17, 2025
[fix](Nereids) initcap constant folding should upper first character …
450a15f 
…in all words (#49061)
@github-actions github-actions bot mentioned this pull request Mar 17, 2025
Closed
LiBinfeng-01 pushed a commit to LiBinfeng-01/doris that referenced this pull request Mar 21, 2025
[fix](Nereids) initcap constant folding should upper first character …
368f95d 
…in all words (apache#49061)
@LiBinfeng-01 LiBinfeng-01 mentioned this pull request Mar 21, 2025
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request Mar 21, 2025
[fix](Nereids) initcap constant folding should upper first character …
b130500 
…in all words (#49061) (#49342)
LiBinfeng-01 pushed a commit to LiBinfeng-01/doris that referenced this pull request Mar 27, 2025
@LiBinfeng-01
[fix](Nereids) initcap constant folding should upper first character …
862753a 
…in all words (apache#49061)
@LiBinfeng-01 LiBinfeng-01 mentioned this pull request Mar 27, 2025
Merged
dataroaring pushed a commit that referenced this pull request Mar 30, 2025
branch-3.0: [fix](Nereids) fix initcap fe fold constant #49061 (#49583)
0e33923 
Cherry-picked from #49061
case of initcap has been added at:
(#49346)
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Closed
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@koarz
[fix](Nereids) initcap constant folding should upper first character …
ba12464 
…in all words (apache#49061)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.5-merged p0_w reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@LiBinfeng-01 @Thearas @doris-robot @starocean999 @morrySnow @yiguolei @dataroaring