Skip to content

Conversation

@LiBinfeng-01
Copy link
Contributor

@LiBinfeng-01 LiBinfeng-01 commented Mar 27, 2025

Cherry-picked from #49061
case of initcap has been added at: (#49346)

@Thearas
Copy link
Contributor

Thearas commented Mar 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@LiBinfeng-01 LiBinfeng-01 changed the title [fix](Nereids) initcap constant folding should upper first character in all words (#49061) branch-3.0: [fix](Nereids) fix initcap fe fold constant #49061 Mar 27, 2025
@dataroaring
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39793 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 862753afbad4f27d4884ffde7dbc9d03ddf117f8, data reload: false

------ Round 1 ----------------------------------
q1	17694	6728	6635	6635
q2	2068	164	160	160
q3	10904	1075	1226	1075
q4	10605	787	719	719
q5	7774	2807	2831	2807
q6	217	132	134	132
q7	941	614	605	605
q8	9454	1907	1987	1907
q9	6598	6360	6380	6360
q10	7055	2231	2335	2231
q11	471	249	257	249
q12	397	212	212	212
q13	17809	2996	3012	2996
q14	236	213	212	212
q15	513	475	465	465
q16	697	572	574	572
q17	977	542	644	542
q18	7251	6544	6538	6538
q19	1453	1076	1026	1026
q20	461	198	195	195
q21	3926	3173	3161	3161
q22	1074	1001	994	994
Total cold run time: 108575 ms
Total hot run time: 39793 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6626	6579	6588	6579
q2	327	238	231	231
q3	2887	2750	2891	2750
q4	2056	1810	1762	1762
q5	5756	5729	5735	5729
q6	215	128	130	128
q7	2212	1840	1827	1827
q8	3422	3565	3546	3546
q9	8708	8958	8862	8862
q10	3564	3521	3539	3521
q11	588	492	518	492
q12	824	614	637	614
q13	10261	3258	3170	3170
q14	306	275	281	275
q15	510	457	457	457
q16	677	650	641	641
q17	1858	1639	1624	1624
q18	8229	7872	7571	7571
q19	1658	1570	1597	1570
q20	2102	1883	1847	1847
q21	5605	5410	5448	5410
q22	1127	1052	1018	1018
Total cold run time: 69518 ms
Total hot run time: 59624 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197732 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 862753afbad4f27d4884ffde7dbc9d03ddf117f8, data reload: false

query1	1299	931	943	931
query2	6231	2040	2019	2019
query3	10818	4299	4355	4299
query4	65269	28408	23477	23477
query5	4993	448	445	445
query6	401	187	177	177
query7	5503	301	301	301
query8	288	216	219	216
query9	8699	2593	2585	2585
query10	473	264	251	251
query11	17230	15186	15889	15186
query12	166	104	104	104
query13	1513	478	447	447
query14	10711	7684	7617	7617
query15	200	183	176	176
query16	7139	484	502	484
query17	1068	572	568	568
query18	1884	295	318	295
query19	204	159	166	159
query20	116	111	106	106
query21	215	102	105	102
query22	4901	4617	4599	4599
query23	34672	34156	33937	33937
query24	6156	2868	2949	2868
query25	544	424	434	424
query26	687	174	165	165
query27	1870	354	362	354
query28	4058	2476	2432	2432
query29	720	480	470	470
query30	242	165	167	165
query31	1035	847	829	829
query32	72	57	59	57
query33	436	313	322	313
query34	926	514	505	505
query35	882	721	749	721
query36	1086	967	975	967
query37	116	67	73	67
query38	4073	4049	4068	4049
query39	1517	1476	1482	1476
query40	205	103	100	100
query41	52	50	50	50
query42	118	106	100	100
query43	521	495	486	486
query44	1193	825	828	825
query45	182	164	170	164
query46	1148	740	744	740
query47	2075	1927	1982	1927
query48	474	393	405	393
query49	750	410	409	409
query50	879	431	451	431
query51	7341	7125	7146	7125
query52	102	88	87	87
query53	262	183	183	183
query54	566	470	459	459
query55	77	77	77	77
query56	278	253	264	253
query57	1234	1095	1066	1066
query58	208	202	213	202
query59	3127	3112	2956	2956
query60	285	272	248	248
query61	114	115	104	104
query62	777	650	650	650
query63	213	181	196	181
query64	1406	668	635	635
query65	3260	3191	3182	3182
query66	675	298	296	296
query67	16034	15761	15976	15761
query68	4153	579	575	575
query69	406	263	266	263
query70	1181	1122	1139	1122
query71	340	277	265	265
query72	6392	4027	3983	3983
query73	760	346	350	346
query74	10137	8849	9103	8849
query75	3361	2646	2651	2646
query76	2314	1039	1022	1022
query77	458	268	264	264
query78	10499	9671	9515	9515
query79	2106	600	605	600
query80	1393	433	434	433
query81	543	239	242	239
query82	1277	86	86	86
query83	177	151	138	138
query84	280	83	80	80
query85	997	321	281	281
query86	414	307	292	292
query87	4442	4241	4363	4241
query88	3655	2389	2331	2331
query89	412	286	288	286
query90	1874	186	189	186
query91	181	146	146	146
query92	61	49	52	49
query93	2822	562	555	555
query94	795	290	291	290
query95	351	259	256	256
query96	643	285	281	281
query97	3332	3209	3214	3209
query98	217	202	205	202
query99	1559	1324	1268	1268
Total cold run time: 319501 ms
Total hot run time: 197732 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.83 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 862753afbad4f27d4884ffde7dbc9d03ddf117f8, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.11	0.11
query5	0.53	0.52	0.51
query6	1.13	0.73	0.73
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.57	0.51	0.50
query10	0.56	0.55	0.54
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.60	0.59
query14	2.73	2.89	2.87
query15	0.90	0.84	0.83
query16	0.39	0.38	0.38
query17	0.99	1.06	1.02
query18	0.25	0.21	0.21
query19	1.98	1.90	2.02
query20	0.02	0.01	0.00
query21	15.36	0.57	0.58
query22	2.67	1.86	1.90
query23	17.18	1.14	0.92
query24	3.35	1.74	0.31
query25	0.24	0.14	0.04
query26	0.53	0.13	0.14
query27	0.06	0.04	0.05
query28	10.29	0.47	0.45
query29	12.59	3.26	3.21
query30	0.25	0.07	0.06
query31	2.84	0.39	0.38
query32	3.25	0.46	0.46
query33	2.93	3.07	3.05
query34	17.19	4.47	4.47
query35	4.47	4.54	4.56
query36	0.67	0.50	0.47
query37	0.08	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.03	0.02
query40	0.15	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.28 s
Total hot run time: 31.83 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 0e33923 into apache:branch-3.0 Mar 30, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants