Skip to content

branch-3.0: [fix](Nereids) fix initcap fe fold constant #49061 #49583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Mar 30, 2025
Merged

branch-3.0: [fix](Nereids) fix initcap fe fold constant #49061 #49583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions ...ava/org/apache/doris/nereids/trees/expressions/functions/executable/StringArithmetic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,12 +420,9 @@ public static Expression characterLength(StringLikeLiteral first) {
return new IntegerLiteral(first.getValue().codePointCount(0, first.getValue().length()));
}

private static boolean isSeparator(char c) {
if (".$|()[{^?*+\\".indexOf(c) == -1) {
return false;
} else {
return true;
}
private static boolean isAlphabetic(char c) {
Pattern pattern = Pattern.compile("\\p{Alnum}");
return pattern.matcher(String.valueOf(c)).find();
}

/**
Expand All @@ -437,7 +434,7 @@ public static Expression initCap(StringLikeLiteral first) {
boolean capitalizeNext = true;

for (char c : first.getValue().toCharArray()) {
if (Character.isWhitespace(c) || isSeparator(c)) {
if (Character.isWhitespace(c) || !isAlphabetic(c)) {
result.append(c);
capitalizeNext = true; // Next character should be capitalized
} else if (capitalizeNext) {
Expand Down
Loading