Skip to content

[fix](cloud-schema-change) Remove schema change job even if alter version < 2 #49062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 7 commits into from
Apr 9, 2025
Merged

[fix](cloud-schema-change) Remove schema change job even if alter version < 2 #49062

gavinchou merged 7 commits into from
Apr 9, 2025

Conversation

@Hastyshell
Copy link
Collaborator

@Hastyshell Hastyshell commented Mar 14, 2025 •
edited
Loading

What problem does this PR solve?

Problem Summary:

Remove schema change job even if alter version < 2, to avoid base compaction disablility after doing schema change on empty tables.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

gavinchou
gavinchou previously approved these changes Mar 21, 2025
View reviewed changes
@gavinchou gavinchou added the p0_b label Mar 21, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2025

PR approved by anyone and no changes requested.

@Hastyshell Hastyshell marked this pull request as ready for review March 25, 2025 03:08
@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Mar 25, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 25, 2025

TeamCity cloud ut coverage result:
Function Coverage: 83.04% (1087/1309)
Line Coverage: 66.08% (18099/27391)
Region Coverage: 65.44% (8907/13611)
Branch Coverage: 55.24% (4793/8676)
Coverage Report: http://coverage.selectdb-in.cc/coverage/338fda5f48b6f40294dce376503d01ca14cf8027_338fda5f48b6f40294dce376503d01ca14cf8027_cloud/report/index.html

@gavinchou
Copy link
Contributor

gavinchou commented Mar 26, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 26, 2025

TeamCity cloud ut coverage result:
Function Coverage: 83.04% (1087/1309)
Line Coverage: 66.07% (18096/27391)
Region Coverage: 65.43% (8906/13611)
Branch Coverage: 55.26% (4794/8676)
Coverage Report: http://coverage.selectdb-in.cc/coverage/338fda5f48b6f40294dce376503d01ca14cf8027_338fda5f48b6f40294dce376503d01ca14cf8027_cloud/report/index.html

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 26, 2025
@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Mar 26, 2025

run buildall

@Hastyshell Hastyshell marked this pull request as draft March 26, 2025 09:34
@doris-robot
Copy link

doris-robot commented Mar 26, 2025

TeamCity cloud ut coverage result:
Function Coverage: 83.04% (1087/1309)
Line Coverage: 66.13% (18113/27391)
Region Coverage: 65.49% (8914/13611)
Branch Coverage: 55.36% (4803/8676)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9c7a67bac5fb5f4a5e375923fef07bfb3f2b45fe_9c7a67bac5fb5f4a5e375923fef07bfb3f2b45fe_cloud/report/index.html

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Mar 26, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 26, 2025

TeamCity cloud ut coverage result:
Function Coverage: 83.04% (1087/1309)
Line Coverage: 66.08% (18100/27391)
Region Coverage: 65.45% (8908/13611)
Branch Coverage: 55.31% (4799/8676)
Coverage Report: http://coverage.selectdb-in.cc/coverage/21686e12c4fea490a5bc220673dbd57be55af726_21686e12c4fea490a5bc220673dbd57be55af726_cloud/report/index.html

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Mar 26, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 26, 2025

TeamCity cloud ut coverage result:
Function Coverage: 83.04% (1087/1309)
Line Coverage: 66.12% (18111/27391)
Region Coverage: 65.48% (8913/13611)
Branch Coverage: 55.31% (4799/8676)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e327dfeb6a0124c606fe010c1772d7f9cb91f442_e327dfeb6a0124c606fe010c1772d7f9cb91f442_cloud/report/index.html

@doris-robot
Copy link

doris-robot commented Mar 27, 2025

TeamCity cloud ut coverage result:
Function Coverage: 83.04% (1087/1309)
Line Coverage: 66.06% (18095/27391)
Region Coverage: 65.43% (8905/13611)
Branch Coverage: 55.26% (4794/8676)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d2e0fe074516ab58e16c14d86afadc7f97499eb8_d2e0fe074516ab58e16c14d86afadc7f97499eb8_cloud/report/index.html

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Apr 8, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 8, 2025

TeamCity cloud ut coverage result:
Function Coverage: 83.07% (1089/1311)
Line Coverage: 66.04% (18155/27489)
Region Coverage: 65.49% (8944/13657)
Branch Coverage: 55.29% (4815/8708)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0c3deda3a0ee54a27fa7bdb95da8faed54420490_0c3deda3a0ee54a27fa7bdb95da8faed54420490_cloud/report/index.html

@Hastyshell Hastyshell marked this pull request as ready for review April 8, 2025 12:12
gavinchou
gavinchou previously approved these changes Apr 8, 2025
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

PR approved by at least one committer and no changes requested.

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Apr 8, 2025

run cloud_p0

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Apr 9, 2025

run p0

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Apr 9, 2025

run cloud_p0

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Apr 9, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 9, 2025

TeamCity cloud ut coverage result:
Function Coverage: 83.07% (1089/1311)
Line Coverage: 66.05% (18157/27489)
Region Coverage: 65.50% (8945/13657)
Branch Coverage: 55.34% (4819/8708)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a33c599672ba11d45500d835d69a7f138e0447cc_a33c599672ba11d45500d835d69a7f138e0447cc_cloud/report/index.html

@Hastyshell Hastyshell force-pushed the fix-empty-table-sc-job-commit branch from a33c599 to 1de1dc0 Compare April 9, 2025 09:40
@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Apr 9, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 9, 2025
@doris-robot
Copy link

doris-robot commented Apr 9, 2025

TeamCity cloud ut coverage result:
Function Coverage: 83.07% (1089/1311)
Line Coverage: 66.08% (18166/27489)
Region Coverage: 65.53% (8950/13657)
Branch Coverage: 55.41% (4825/8708)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1de1dc093c571016a4ff32f56ddee74fd13b4621_1de1dc093c571016a4ff32f56ddee74fd13b4621_cloud/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

PR approved by at least one committer and no changes requested.

@gavinchou gavinchou merged commit 12e774b into apache:master Apr 9, 2025
24 of 25 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 9, 2025
@Hastyshell
[fix](cloud-schema-change) Remove schema change job even if alter ver…
637c329 
…sion < 2 (#49062)

Remove schema change job even if alter version < 2, to avoid base
compaction disablility after doing schema change on empty tables.
@github-actions github-actions bot mentioned this pull request Apr 9, 2025
Merged
dataroaring pushed a commit that referenced this pull request Apr 10, 2025
@github-actions @Hastyshell
branch-3.0: [fix](cloud-schema-change) Remove schema change job even …
60df072 
…if alter version < 2 #49062 (#49921)

Cherry-picked from #49062

Co-authored-by: Siyang Tang <tangsiyang@selectdb.com>
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Closed
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@Hastyshell
[fix](cloud-schema-change) Remove schema change job even if alter ver…
5e3f461 
…sion < 2 (apache#49062)

Remove schema change job even if alter version < 2, to avoid base
compaction disablility after doing schema change on empty tables.
suxiaogang223 pushed a commit to suxiaogang223/doris that referenced this pull request Jul 15, 2025
@Hastyshell @github-actions
branch-3.0: [fix](cloud-schema-change) Remove schema change job even …
5deb06a 
…if alter version < 2 apache#49062 (apache#49921) (apache#3899)

Cherry-picked from apache#49062

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@luwei16 luwei16 luwei16 approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.5-merged p0_b reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Hastyshell @hello-stephen @doris-robot @gavinchou @luwei16 @dataroaring