Skip to content

branch-3.0: [fix](cloud-schema-change) Remove schema change job even if alter version < 2 #49062 #49921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Apr 10, 2025
Merged

branch-3.0: [fix](cloud-schema-change) Remove schema change job even if alter version < 2 #49062 #49921

dataroaring merged 1 commit into from
Apr 10, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 9, 2025

Cherry-picked from #49062

@Hastyshell
[fix](cloud-schema-change) Remove schema change job even if alter ver…
637c329 
…sion < 2 (#49062)

Remove schema change job even if alter version < 2, to avoid base
compaction disablility after doing schema change on empty tables.
@github-actions github-actions bot requested a review from dataroaring as a code owner April 9, 2025 12:15
@Thearas
Copy link
Contributor

Thearas commented Apr 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Apr 9, 2025
@dataroaring dataroaring reopened this Apr 9, 2025
@Thearas
Copy link
Contributor

Thearas commented Apr 9, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 9, 2025
@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 9, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 9, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Apr 9, 2025

TeamCity cloud ut coverage result:
Function Coverage: 82.99% (1083/1305)
Line Coverage: 65.98% (17936/27183)
Region Coverage: 65.51% (8847/13504)
Branch Coverage: 55.44% (4777/8616)
Coverage Report: http://coverage.selectdb-in.cc/coverage/637c329953e4d2c9dfd1fa56aa8acd8de789a135_637c329953e4d2c9dfd1fa56aa8acd8de789a135_cloud/report/index.html

dataroaring
dataroaring approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 60df072 into branch-3.0 Apr 10, 2025
26 of 28 checks passed
@github-actions github-actions bot deleted the auto-pick-49062-branch-3.0 branch April 10, 2025 06:31
suxiaogang223 pushed a commit to suxiaogang223/doris that referenced this pull request Jul 15, 2025
@Hastyshell @github-actions
branch-3.0: [fix](cloud-schema-change) Remove schema change job even …
5deb06a 
…if alter version < 2 apache#49062 (apache#49921) (apache#3899)

Cherry-picked from apache#49062

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @doris-robot @gavinchou @dataroaring @Hastyshell