Skip to content

[fix](multi table load) error URL does not depend on the value of _number_filtered_rows #49111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Mar 17, 2025
Merged

[fix](multi table load) error URL does not depend on the value of _number_filtered_rows #49111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions be/src/io/fs/multi_table_pipe.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ Status MultiTablePipe::exec_plans(ExecEnv* exec_env, std::vector<ExecParam> para
_number_loaded_rows += state->num_rows_load_success();
_number_filtered_rows += state->num_rows_load_filtered();
_number_unselected_rows += state->num_rows_load_unselected();

_ctx->error_url = to_load_error_http_path(state->get_error_log_file_path());
// check filtered ratio for this plan fragment
int64_t num_selected_rows =
state->num_rows_load_total() - state->num_rows_load_unselected();
Expand All @@ -280,9 +280,6 @@ Status MultiTablePipe::exec_plans(ExecEnv* exec_env, std::vector<ExecParam> para
_ctx->max_filter_ratio) {
*status = Status::DataQualityError("too many filtered rows");
}
if (_number_filtered_rows > 0 && !state->get_error_log_file_path().empty()) {
_ctx->error_url = to_load_error_http_path(state->get_error_log_file_path());
}

// if any of the plan fragment exec failed, set the status to the first failed plan
if (!status->ok()) {
Expand Down
Loading