Skip to content

Conversation

@sollhui
Copy link
Contributor

@sollhui sollhui commented Mar 16, 2025

What problem does this PR solve?

The error URL does not depend on the value of _number_filtered_rows for it may not be correct.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@sollhui
Copy link
Contributor Author

sollhui commented Mar 16, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32374 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c10bbefde20ba2abbcef383a5f5aafa1604438f3, data reload: false

------ Round 1 ----------------------------------
q1	17599	5252	5038	5038
q2	2045	300	161	161
q3	10428	1287	779	779
q4	10207	1033	528	528
q5	7544	2418	2323	2323
q6	189	162	131	131
q7	923	756	612	612
q8	9305	1324	1085	1085
q9	4893	4800	4667	4667
q10	6820	2306	1880	1880
q11	464	288	269	269
q12	346	359	226	226
q13	17771	3665	3099	3099
q14	229	228	219	219
q15	542	474	475	474
q16	625	609	583	583
q17	589	881	350	350
q18	6899	6597	6315	6315
q19	1523	965	565	565
q20	322	331	196	196
q21	2814	2124	1896	1896
q22	1010	1024	978	978
Total cold run time: 103087 ms
Total hot run time: 32374 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5159	5172	5071	5071
q2	237	335	228	228
q3	2199	2710	2311	2311
q4	1435	1854	1344	1344
q5	4239	4136	4131	4131
q6	209	164	124	124
q7	1893	1900	1777	1777
q8	2724	2664	2570	2570
q9	7293	7284	7230	7230
q10	2999	3252	2797	2797
q11	593	507	481	481
q12	702	782	619	619
q13	3337	3896	3271	3271
q14	298	307	263	263
q15	502	485	457	457
q16	649	708	658	658
q17	1155	1616	1389	1389
q18	7899	7677	7635	7635
q19	869	866	998	866
q20	2001	2043	1892	1892
q21	5523	4997	4722	4722
q22	1077	1066	1030	1030
Total cold run time: 52992 ms
Total hot run time: 50866 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192465 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c10bbefde20ba2abbcef383a5f5aafa1604438f3, data reload: false

query1	1427	1035	970	970
query2	6219	1936	1916	1916
query3	11019	4521	4484	4484
query4	54965	24759	23027	23027
query5	5078	580	497	497
query6	327	194	200	194
query7	4885	558	296	296
query8	307	253	236	236
query9	5549	2610	2620	2610
query10	418	304	246	246
query11	15096	15214	14878	14878
query12	154	109	102	102
query13	1026	501	411	411
query14	10215	6373	6385	6373
query15	185	184	184	184
query16	7043	660	488	488
query17	1076	722	545	545
query18	1541	404	320	320
query19	187	197	167	167
query20	152	120	118	118
query21	216	127	107	107
query22	4533	4773	4602	4602
query23	34131	33480	33455	33455
query24	6241	2422	2384	2384
query25	451	448	428	428
query26	662	282	160	160
query27	1957	495	323	323
query28	2982	2468	2437	2437
query29	578	576	435	435
query30	274	225	194	194
query31	867	873	828	828
query32	80	62	61	61
query33	465	365	328	328
query34	768	838	502	502
query35	810	856	762	762
query36	945	1003	898	898
query37	124	99	77	77
query38	4395	4251	4139	4139
query39	1494	1433	1431	1431
query40	217	132	108	108
query41	52	49	48	48
query42	125	109	110	109
query43	509	525	482	482
query44	1329	814	819	814
query45	185	174	166	166
query46	894	1025	648	648
query47	1811	1851	1805	1805
query48	410	428	314	314
query49	700	515	423	423
query50	723	764	428	428
query51	4257	4317	4304	4304
query52	116	106	108	106
query53	240	267	189	189
query54	496	502	424	424
query55	82	84	119	84
query56	278	270	249	249
query57	1177	1173	1111	1111
query58	246	248	237	237
query59	2696	2812	2813	2812
query60	288	291	284	284
query61	124	114	115	114
query62	745	703	686	686
query63	229	186	196	186
query64	1442	1140	795	795
query65	4625	4495	4354	4354
query66	724	399	310	310
query67	15833	15364	15353	15353
query68	5693	920	520	520
query69	548	307	275	275
query70	1231	1127	1118	1118
query71	452	294	269	269
query72	5994	3683	3787	3683
query73	1355	766	360	360
query74	8920	9096	8911	8911
query75	3195	3161	2704	2704
query76	3829	1178	737	737
query77	547	367	273	273
query78	10236	10112	9417	9417
query79	2493	883	583	583
query80	707	528	439	439
query81	489	260	229	229
query82	608	127	92	92
query83	177	168	149	149
query84	291	97	72	72
query85	760	354	312	312
query86	367	306	289	289
query87	4444	4468	4361	4361
query88	3703	2251	2238	2238
query89	405	311	286	286
query90	1712	209	214	209
query91	142	141	111	111
query92	70	59	57	57
query93	2487	1059	580	580
query94	712	416	296	296
query95	346	274	255	255
query96	484	577	275	275
query97	3414	3405	3370	3370
query98	232	208	201	201
query99	1582	1379	1238	1238
Total cold run time: 297020 ms
Total hot run time: 192465 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.96 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c10bbefde20ba2abbcef383a5f5aafa1604438f3, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.03
query3	0.23	0.06	0.07
query4	1.64	0.10	0.11
query5	0.57	0.55	0.54
query6	1.20	0.73	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.51	0.55
query10	0.58	0.64	0.58
query11	0.16	0.11	0.10
query12	0.15	0.12	0.11
query13	0.62	0.60	0.60
query14	2.80	2.72	2.68
query15	0.91	0.85	0.84
query16	0.39	0.39	0.37
query17	1.06	1.02	1.03
query18	0.22	0.21	0.21
query19	1.97	1.83	2.01
query20	0.02	0.01	0.01
query21	15.35	0.92	0.56
query22	0.75	1.25	0.94
query23	14.74	1.37	0.61
query24	7.47	1.87	0.75
query25	0.52	0.19	0.09
query26	0.57	0.16	0.13
query27	0.05	0.05	0.05
query28	9.38	0.76	0.42
query29	12.59	3.93	3.31
query30	0.25	0.08	0.08
query31	2.83	0.59	0.38
query32	3.23	0.54	0.45
query33	3.04	3.03	3.01
query34	15.68	5.11	4.50
query35	4.52	4.50	4.50
query36	0.68	0.49	0.48
query37	0.08	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.03
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.4 s
Total hot run time: 30.96 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 48.34% (12931/26752)
Line Coverage 37.84% (110936/293178)
Region Coverage 36.80% (56609/153834)
Branch Coverage 32.02% (28505/89022)

Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 16, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit ee8685b into apache:master Mar 17, 2025
28 of 29 checks passed
@dataroaring dataroaring added the usercase Important user case type label label Mar 17, 2025
github-actions bot pushed a commit that referenced this pull request Mar 17, 2025
…mber_filtered_rows (#49111)

### What problem does this PR solve?

The error URL does not depend on the value of _number_filtered_rows for
it may not be correct.
github-actions bot pushed a commit that referenced this pull request Mar 17, 2025
…mber_filtered_rows (#49111)

### What problem does this PR solve?

The error URL does not depend on the value of _number_filtered_rows for
it may not be correct.
dataroaring pushed a commit that referenced this pull request Mar 17, 2025
…value of _number_filtered_rows #49111 (#49130)

Cherry-picked from #49111

Co-authored-by: hui lai <laihui@selectdb.com>
yiguolei pushed a commit that referenced this pull request Mar 19, 2025
…value of _number_filtered_rows #49111 (#49131)

Cherry-picked from #49111

Co-authored-by: hui lai <laihui@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
…mber_filtered_rows (apache#49111)

### What problem does this PR solve?

The error URL does not depend on the value of _number_filtered_rows for
it may not be correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.5-merged reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants