Skip to content

branch-3.0: [fix](multi table load) error URL does not depend on the value of _number_filtered_rows #49111 #49130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Mar 17, 2025
Merged

branch-3.0: [fix](multi table load) error URL does not depend on the value of _number_filtered_rows #49111 #49130

dataroaring merged 1 commit into from
Mar 17, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 17, 2025

Cherry-picked from #49111

@sollhui
[fix](multi table load) error URL does not depend on the value of _nu…
c9769e2 
…mber_filtered_rows (#49111)

### What problem does this PR solve?

The error URL does not depend on the value of _number_filtered_rows for
it may not be correct.
@github-actions github-actions bot requested a review from dataroaring as a code owner March 17, 2025 02:48
@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 17, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 17, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 17, 2025

TPC-H: Total hot run time: 39560 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c9769e24d8360f9ea32504cb2bdf37417e32723f, data reload: false

------ Round 1 ----------------------------------
q1	17571	6732	6627	6627
q2	2110	171	159	159
q3	10994	1066	1116	1066
q4	10544	737	689	689
q5	7734	2817	2792	2792
q6	215	134	131	131
q7	971	615	595	595
q8	9355	1893	1982	1893
q9	6607	6365	6345	6345
q10	7011	2227	2256	2227
q11	468	265	266	265
q12	393	217	208	208
q13	17793	2929	3011	2929
q14	235	199	209	199
q15	501	464	460	460
q16	665	579	573	573
q17	969	682	517	517
q18	7174	6622	6576	6576
q19	1396	1081	1001	1001
q20	481	204	193	193
q21	4140	3166	3180	3166
q22	1124	968	949	949
Total cold run time: 108451 ms
Total hot run time: 39560 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6564	6620	6553	6553
q2	338	232	233	232
q3	2891	2745	2817	2745
q4	2031	1825	1794	1794
q5	5742	5708	5691	5691
q6	209	133	129	129
q7	2210	1805	1805	1805
q8	3351	3566	3476	3476
q9	8761	8865	8759	8759
q10	3570	3523	3489	3489
q11	593	487	508	487
q12	788	612	609	609
q13	9598	3262	3185	3185
q14	309	269	272	269
q15	519	462	463	462
q16	692	651	651	651
q17	1833	1636	1587	1587
q18	8185	7626	7730	7626
q19	1652	1534	1432	1432
q20	2101	1890	1868	1868
q21	5456	5420	5478	5420
q22	1119	1013	1034	1013
Total cold run time: 68512 ms
Total hot run time: 59282 ms

@doris-robot
Copy link

doris-robot commented Mar 17, 2025

TPC-DS: Total hot run time: 196404 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c9769e24d8360f9ea32504cb2bdf37417e32723f, data reload: false

query1	1311	920	914	914
query2	6407	2060	1973	1973
query3	10809	4423	4247	4247
query4	65457	28273	23385	23385
query5	4995	436	425	425
query6	391	166	174	166
query7	5517	324	313	313
query8	298	207	206	206
query9	8863	2591	2589	2589
query10	457	274	248	248
query11	17251	15404	15740	15404
query12	163	106	107	106
query13	1476	481	436	436
query14	10406	6817	6700	6700
query15	208	170	182	170
query16	7122	476	462	462
query17	1066	560	554	554
query18	1951	307	292	292
query19	200	152	149	149
query20	114	107	109	107
query21	200	100	104	100
query22	4641	4459	4360	4360
query23	34427	34175	34251	34175
query24	6127	2972	2983	2972
query25	549	416	424	416
query26	666	175	169	169
query27	1902	353	363	353
query28	4472	2485	2464	2464
query29	714	451	453	451
query30	246	173	165	165
query31	972	833	844	833
query32	71	59	57	57
query33	423	322	292	292
query34	912	508	505	505
query35	847	740	733	733
query36	1079	972	961	961
query37	120	71	70	70
query38	4119	3933	4021	3933
query39	1499	1475	1478	1475
query40	205	98	100	98
query41	51	50	49	49
query42	121	98	104	98
query43	537	477	495	477
query44	1188	839	842	839
query45	195	169	173	169
query46	1145	726	732	726
query47	2087	1893	1915	1893
query48	483	378	384	378
query49	725	382	385	382
query50	863	422	418	418
query51	7328	7340	7106	7106
query52	97	86	87	86
query53	261	179	182	179
query54	541	456	440	440
query55	72	83	79	79
query56	253	242	238	238
query57	1229	1124	1082	1082
query58	231	203	214	203
query59	3042	2925	2835	2835
query60	274	247	253	247
query61	104	106	102	102
query62	772	643	673	643
query63	223	189	183	183
query64	1376	656	654	654
query65	3236	3178	3154	3154
query66	694	297	299	297
query67	15975	15563	15592	15563
query68	4089	593	567	567
query69	438	272	264	264
query70	1163	1138	1131	1131
query71	366	253	255	253
query72	6344	3947	4103	3947
query73	760	347	353	347
query74	9946	8978	9082	8978
query75	3341	2664	2673	2664
query76	1932	1111	1055	1055
query77	495	267	280	267
query78	10565	9497	9490	9490
query79	2089	615	618	615
query80	1286	430	412	412
query81	545	236	234	234
query82	455	84	87	84
query83	158	147	143	143
query84	283	80	81	80
query85	1000	292	292	292
query86	407	300	303	300
query87	4462	4279	4305	4279
query88	3989	2378	2367	2367
query89	428	289	287	287
query90	2023	181	182	181
query91	175	149	146	146
query92	59	50	51	50
query93	2494	563	556	556
query94	882	279	290	279
query95	363	248	248	248
query96	629	282	292	282
query97	3307	3184	3181	3181
query98	216	209	205	205
query99	1583	1272	1298	1272
Total cold run time: 318028 ms
Total hot run time: 196404 ms

@doris-robot
Copy link

doris-robot commented Mar 17, 2025

ClickBench: Total hot run time: 32.1 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c9769e24d8360f9ea32504cb2bdf37417e32723f, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.51	0.53	0.50
query6	1.14	0.73	0.73
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.50	0.49
query10	0.54	0.56	0.55
query11	0.14	0.10	0.10
query12	0.14	0.13	0.12
query13	0.61	0.62	0.60
query14	2.72	2.78	2.76
query15	0.88	0.82	0.84
query16	0.39	0.37	0.38
query17	1.06	1.01	1.08
query18	0.24	0.22	0.22
query19	1.90	1.75	1.96
query20	0.02	0.01	0.01
query21	15.42	0.60	0.60
query22	2.49	2.74	1.92
query23	17.01	1.01	0.85
query24	3.33	1.11	0.93
query25	0.28	0.11	0.12
query26	0.52	0.13	0.14
query27	0.06	0.04	0.03
query28	10.28	0.47	0.50
query29	12.61	3.26	3.24
query30	0.25	0.06	0.06
query31	2.88	0.39	0.37
query32	3.26	0.46	0.45
query33	3.01	3.00	3.06
query34	16.96	4.44	4.47
query35	4.56	4.47	4.44
query36	0.68	0.48	0.48
query37	0.10	0.06	0.07
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.16	0.12	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.96 s
Total hot run time: 32.1 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 17, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.88% (10167/26152)
Line Coverage 30.29% (86627/286009)
Region Coverage 29.35% (44512/151670)
Branch Coverage 25.86% (22633/87520)

dataroaring
dataroaring approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 9c59134 into branch-3.0 Mar 17, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49111-branch-3.0 branch March 17, 2025 07:31
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @doris-robot @dataroaring @sollhui