[fix](function) fix error result when input utf8 in url_encode, strright, append_trailing_char_if_absent #49127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32520 ms |
TPC-DS: Total hot run time: 192556 ms |
ClickBench: Total hot run time: 31.03 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34030 ms |
TPC-DS: Total hot run time: 186701 ms |
ClickBench: Total hot run time: 31.57 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
need also check this case: |
Gabriel39
previously approved these changes
May 6, 2025
Contributor
Author
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 33839 ms |
TPC-DS: Total hot run time: 185699 ms |
ClickBench: Total hot run time: 29.47 s |
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34003 ms |
TPC-DS: Total hot run time: 185172 ms |
ClickBench: Total hot run time: 29.11 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run p0 |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
zhangstar333
approved these changes
May 7, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
BiteTheDDDDt
approved these changes
May 7, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2025
…ght, append_trailing_char_if_absent (#49127) ### What problem does this PR solve? The url_encode function previously performed a modulus operation on a signed number. Converting it to an unsigned number will fix the issue. ``` before mysql> select url_encode('编码'); +----------------------+ | url_encode('编码') | +----------------------+ | %5.%23%0-%5.%10%/( | +----------------------+ now mysql> select url_encode('编码'); +----------------------+ | url_encode('编码') | +----------------------+ | %E7%BC%96%E7%A0%81 | +----------------------+ ``` The strright function did not calculate the length according to the number of UTF-8 characters. ``` before mysql> select strright("你好世界",5); +----------------------------+ | strright("你好世界",5) | +----------------------------+ | | +----------------------------+ now mysql> select strright("你好世界",5); +----------------------------+ | strright("你好世界",5) | +----------------------------+ | 你好世界 | +----------------------------+ ``` he case of inputting a UTF-8 character was not considered. ``` mysql> select append_trailing_char_if_absent('中文', '文'); +-------------------------------------------------+ | append_trailing_char_if_absent('中文', '文') | +-------------------------------------------------+ | NULL | +-------------------------------------------------+ now mysql> select append_trailing_char_if_absent('中文', '文'); +-------------------------------------------------+ | append_trailing_char_if_absent('中文', '文') | +-------------------------------------------------+ | 中文 | +-------------------------------------------------+ ``` Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
Mryange
added a commit
to Mryange/doris
that referenced
this pull request
May 7, 2025
…ght, append_trailing_char_if_absent (apache#49127) ### What problem does this PR solve? The url_encode function previously performed a modulus operation on a signed number. Converting it to an unsigned number will fix the issue. ``` before mysql> select url_encode('编码'); +----------------------+ | url_encode('编码') | +----------------------+ | %5.%23%0-%5.%10%/( | +----------------------+ now mysql> select url_encode('编码'); +----------------------+ | url_encode('编码') | +----------------------+ | %E7%BC%96%E7%A0%81 | +----------------------+ ``` The strright function did not calculate the length according to the number of UTF-8 characters. ``` before mysql> select strright("你好世界",5); +----------------------------+ | strright("你好世界",5) | +----------------------------+ | | +----------------------------+ now mysql> select strright("你好世界",5); +----------------------------+ | strright("你好世界",5) | +----------------------------+ | 你好世界 | +----------------------------+ ``` he case of inputting a UTF-8 character was not considered. ``` mysql> select append_trailing_char_if_absent('中文', '文'); +-------------------------------------------------+ | append_trailing_char_if_absent('中文', '文') | +-------------------------------------------------+ | NULL | +-------------------------------------------------+ now mysql> select append_trailing_char_if_absent('中文', '文'); +-------------------------------------------------+ | append_trailing_char_if_absent('中文', '文') | +-------------------------------------------------+ | 中文 | +-------------------------------------------------+ ``` Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
Mryange
added a commit
to Mryange/doris
that referenced
this pull request
May 7, 2025
…ght, append_trailing_char_if_absent (apache#49127) The url_encode function previously performed a modulus operation on a signed number. Converting it to an unsigned number will fix the issue. ``` before mysql> select url_encode('编码'); +----------------------+ | url_encode('编码') | +----------------------+ | %5.%23%0-%5.%10%/( | +----------------------+ now mysql> select url_encode('编码'); +----------------------+ | url_encode('编码') | +----------------------+ | %E7%BC%96%E7%A0%81 | +----------------------+ ``` The strright function did not calculate the length according to the number of UTF-8 characters. ``` before mysql> select strright("你好世界",5); +----------------------------+ | strright("你好世界",5) | +----------------------------+ | | +----------------------------+ now mysql> select strright("你好世界",5); +----------------------------+ | strright("你好世界",5) | +----------------------------+ | 你好世界 | +----------------------------+ ``` he case of inputting a UTF-8 character was not considered. ``` mysql> select append_trailing_char_if_absent('中文', '文'); +-------------------------------------------------+ | append_trailing_char_if_absent('中文', '文') | +-------------------------------------------------+ | NULL | +-------------------------------------------------+ now mysql> select append_trailing_char_if_absent('中文', '文'); +-------------------------------------------------+ | append_trailing_char_if_absent('中文', '文') | +-------------------------------------------------+ | 中文 | +-------------------------------------------------+ ``` Problem Summary: None - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
This was referenced May 7, 2025
yiguolei
pushed a commit
that referenced
this pull request
May 7, 2025
…ncode, strright, append_trailing_char_if_absent #49127 (#50660) …ght, append_trailing_char_if_absent (#49127) The url_encode function previously performed a modulus operation on a signed number. Converting it to an unsigned number will fix the issue. ``` before mysql> select url_encode('编码'); +----------------------+ | url_encode('编码') | +----------------------+ | %5.%23%0-%5.%10%/( | +----------------------+ now mysql> select url_encode('编码'); +----------------------+ | url_encode('编码') | +----------------------+ | %E7%BC%96%E7%A0%81 | +----------------------+ ``` The strright function did not calculate the length according to the number of UTF-8 characters. ``` before mysql> select strright("你好世界",5); +----------------------------+ | strright("你好世界",5) | +----------------------------+ | | +----------------------------+ now mysql> select strright("你好世界",5); +----------------------------+ | strright("你好世界",5) | +----------------------------+ | 你好世界 | +----------------------------+ ``` he case of inputting a UTF-8 character was not considered. ``` mysql> select append_trailing_char_if_absent('中文', '文'); +-------------------------------------------------+ | append_trailing_char_if_absent('中文', '文') | +-------------------------------------------------+ | NULL | +-------------------------------------------------+ now mysql> select append_trailing_char_if_absent('中文', '文'); +-------------------------------------------------+ | append_trailing_char_if_absent('中文', '文') | +-------------------------------------------------+ | 中文 | +-------------------------------------------------+ ```
Closed
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…ght, append_trailing_char_if_absent (apache#49127) ### What problem does this PR solve? The url_encode function previously performed a modulus operation on a signed number. Converting it to an unsigned number will fix the issue. ``` before mysql> select url_encode('编码'); +----------------------+ | url_encode('编码') | +----------------------+ | %5.%23%0-%5.%10%/( | +----------------------+ now mysql> select url_encode('编码'); +----------------------+ | url_encode('编码') | +----------------------+ | %E7%BC%96%E7%A0%81 | +----------------------+ ``` The strright function did not calculate the length according to the number of UTF-8 characters. ``` before mysql> select strright("你好世界",5); +----------------------------+ | strright("你好世界",5) | +----------------------------+ | | +----------------------------+ now mysql> select strright("你好世界",5); +----------------------------+ | strright("你好世界",5) | +----------------------------+ | 你好世界 | +----------------------------+ ``` he case of inputting a UTF-8 character was not considered. ``` mysql> select append_trailing_char_if_absent('中文', '文'); +-------------------------------------------------+ | append_trailing_char_if_absent('中文', '文') | +-------------------------------------------------+ | NULL | +-------------------------------------------------+ now mysql> select append_trailing_char_if_absent('中文', '文'); +-------------------------------------------------+ | append_trailing_char_if_absent('中文', '文') | +-------------------------------------------------+ | 中文 | +-------------------------------------------------+ ``` Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The url_encode function previously performed a modulus operation on a signed number. Converting it to an unsigned number will fix the issue.
The strright function did not calculate the length according to the number of UTF-8 characters.
he case of inputting a UTF-8 character was not considered.
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)