Skip to content

branch-3.0: [fix](function) fix error result when input utf8 in url_encode, strright, append_trailing_char_if_absent #49127 #50659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
May 8, 2025
Merged

branch-3.0: [fix](function) fix error result when input utf8 in url_encode, strright, append_trailing_char_if_absent #49127 #50659

dataroaring merged 2 commits into from
May 8, 2025

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented May 7, 2025 •
edited
Loading

What problem does this PR solve?

#49127

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Mryange added 2 commits May 7, 2025 16:37
@Mryange
[fix](function) fix error result when input utf8 in url_encode, strri…
5c43eb9 
…ght, append_trailing_char_if_absent (apache#49127)

### What problem does this PR solve?
 
The url_encode function previously performed a modulus operation on a
signed number. Converting it to an unsigned number will fix the issue.
```
before
mysql> select url_encode('编码');
+----------------------+
| url_encode('编码')   |
+----------------------+
| %5.%23%0-%5.%10%/(   |
+----------------------+
now
mysql> select url_encode('编码');
+----------------------+
| url_encode('编码')   |
+----------------------+
| %E7%BC%96%E7%A0%81   |
+----------------------+
```

The strright function did not calculate the length according to the
number of UTF-8 characters.
```
before
mysql> select strright("你好世界",5);
+----------------------------+
| strright("你好世界",5)     |
+----------------------------+
|                            |
+----------------------------+
now

mysql> select strright("你好世界",5);
+----------------------------+
| strright("你好世界",5)     |
+----------------------------+
| 你好世界                   |
+----------------------------+
```

he case of inputting a UTF-8 character was not considered.
```
mysql> select append_trailing_char_if_absent('中文', '文');
+-------------------------------------------------+
| append_trailing_char_if_absent('中文', '文')    |
+-------------------------------------------------+
| NULL                                            |
+-------------------------------------------------+
now
mysql> select append_trailing_char_if_absent('中文', '文');
+-------------------------------------------------+
| append_trailing_char_if_absent('中文', '文')    |
+-------------------------------------------------+
| 中文                                            |
+-------------------------------------------------+
```

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@Mryange
beut
6bfa7af
@Mryange Mryange requested a review from dataroaring as a code owner May 7, 2025 08:40
@hello-stephen
Copy link
Contributor

hello-stephen commented May 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange Mryange mentioned this pull request May 7, 2025
Closed
@Mryange
Copy link
Contributor Author

Mryange commented May 7, 2025

run buildall

@doris-robot
Copy link

doris-robot commented May 7, 2025

BE UT Coverage Report

Increment line coverage 53.85% (21/39) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 40.95% (10796/26362)
Line Coverage 31.80% (92145/289764)
Region Coverage 30.87% (47553/154030)
Branch Coverage 27.38% (24374/89014)

dataroaring
dataroaring approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 54fb444 into apache:branch-3.0 May 8, 2025
21 of 23 checks passed
@IsmailTosunTnyl IsmailTosunTnyl mentioned this pull request Nov 29, 2025
Merged
8 tasks
zclllyybb pushed a commit to apache/doris-website that referenced this pull request Dec 1, 2025
@IsmailTosunTnyl
Update APPEND_TRAILING_CHAR_IF_ABSENT behavior in 3.x branch (#3129)
1bcdee7 
The behavior of APPEND_TRAILING_CHAR_IF_ABSENT has been updated in the
3.x branch.
Documentation needs to be updated accordingly to reflect the new
behavior.

## Related Doris PRs
[#50659](apache/doris#50659)
[#49346](apache/doris#49346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mryange @hello-stephen @doris-robot @dataroaring