Skip to content

branch-3.0: [fix](Nereids) fold str_to_date to wrong result when parameter out range #49033 #49151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Mar 27, 2025
Merged

branch-3.0: [fix](Nereids) fold str_to_date to wrong result when parameter out range #49033 #49151

dataroaring merged 1 commit into from
Mar 27, 2025

Conversation

@LiBinfeng-01
Copy link
Contributor

@LiBinfeng-01 LiBinfeng-01 commented Mar 17, 2025 •
edited
Loading

pick: #49033

Related PR: #18209

Problem Summary:

SELECT STR_TO_DATE('2025-04-31', '%Y-%m-%d') AS result; would be changed to result 2025-04-30 in smart mode by mistake

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Mar 17, 2025

run buildall

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Mar 17, 2025

run buildall

@morrySnow morrySnow changed the title [fix](Nereids) fold str_to_date to wrong result when parameter out range (#49033) branch-3.0: [fix](Nereids) fold str_to_date to wrong result when parameter out range #49033 Mar 17, 2025
@morrySnow
Copy link
Contributor

morrySnow commented Mar 18, 2025

run buildall

[fix](Nereids) fold str_to_date to wrong result when parameter out of…
0955883 
… range (apache#49033)

Related PR: apache#18209

Problem Summary:

SELECT STR_TO_DATE('2025-04-31', '%Y-%m-%d') AS result;
would be changed to result 2025-04-30 in smart mode by mistake
@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Mar 18, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 18, 2025

TPC-H: Total hot run time: 40275 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 09558837e54f7cc35d4912392f3042c0e81de302, data reload: false

------ Round 1 ----------------------------------
q1	17578	6826	6612	6612
q2	2057	167	177	167
q3	10634	1052	1187	1052
q4	10563	762	722	722
q5	7764	2870	2859	2859
q6	223	136	138	136
q7	982	633	627	627
q8	9356	1964	2077	1964
q9	6613	6402	6373	6373
q10	6994	2261	2295	2261
q11	473	275	261	261
q12	410	215	220	215
q13	17782	3036	3029	3029
q14	243	213	211	211
q15	506	466	466	466
q16	637	604	560	560
q17	973	592	586	586
q18	7215	6752	6704	6704
q19	1399	1058	1005	1005
q20	502	219	209	209
q21	4061	3270	3283	3270
q22	1088	990	986	986
Total cold run time: 108053 ms
Total hot run time: 40275 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6655	6602	6643	6602
q2	335	238	245	238
q3	2946	2791	2968	2791
q4	2029	1880	1831	1831
q5	5825	5862	5879	5862
q6	211	139	139	139
q7	2287	1901	1875	1875
q8	3474	3678	3672	3672
q9	8906	8937	8931	8931
q10	3575	3516	3545	3516
q11	609	496	490	490
q12	832	625	588	588
q13	8259	3259	3210	3210
q14	300	270	282	270
q15	519	473	478	473
q16	706	663	661	661
q17	1845	1641	1623	1623
q18	8269	7900	7539	7539
q19	1704	1602	1589	1589
q20	2107	1868	1886	1868
q21	5604	5500	5422	5422
q22	1150	1060	1052	1052
Total cold run time: 68147 ms
Total hot run time: 60242 ms

@doris-robot
Copy link

doris-robot commented Mar 18, 2025

TPC-DS: Total hot run time: 198337 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 09558837e54f7cc35d4912392f3042c0e81de302, data reload: false

query1	1319	954	932	932
query2	6240	2128	2104	2104
query3	10844	4493	4418	4418
query4	65623	28814	23480	23480
query5	4973	455	448	448
query6	399	176	181	176
query7	5580	316	314	314
query8	294	210	218	210
query9	8890	2615	2610	2610
query10	474	283	265	265
query11	17404	15392	15968	15392
query12	171	109	108	108
query13	1589	455	448	448
query14	10765	7095	7881	7095
query15	206	183	184	183
query16	7115	504	503	503
query17	1180	613	616	613
query18	1860	318	311	311
query19	217	164	171	164
query20	120	116	108	108
query21	212	110	105	105
query22	4727	4564	4311	4311
query23	34403	34267	34385	34267
query24	6220	2989	2924	2924
query25	532	407	417	407
query26	666	168	169	168
query27	2444	351	369	351
query28	4621	2459	2469	2459
query29	704	452	452	452
query30	237	164	158	158
query31	1001	825	841	825
query32	76	56	60	56
query33	423	311	327	311
query34	922	533	536	533
query35	887	810	727	727
query36	1076	977	982	977
query37	119	68	73	68
query38	4097	4221	4043	4043
query39	1530	1491	1482	1482
query40	221	106	109	106
query41	52	54	54	54
query42	115	102	102	102
query43	556	504	515	504
query44	1213	822	841	822
query45	191	171	173	171
query46	1151	774	784	774
query47	2033	1912	1919	1912
query48	507	398	411	398
query49	748	431	437	431
query50	867	445	437	437
query51	7367	7129	6979	6979
query52	104	95	93	93
query53	264	190	185	185
query54	578	480	470	470
query55	83	78	79	78
query56	290	256	279	256
query57	1238	1134	1107	1107
query58	226	214	224	214
query59	3301	3008	2990	2990
query60	303	284	280	280
query61	130	148	108	108
query62	783	658	659	658
query63	229	190	198	190
query64	1444	699	660	660
query65	3269	3164	3215	3164
query66	705	294	300	294
query67	15828	15658	15570	15570
query68	4035	593	584	584
query69	450	268	267	267
query70	1200	1111	1129	1111
query71	340	261	271	261
query72	6435	4083	4013	4013
query73	758	349	367	349
query74	10231	9352	9060	9060
query75	3385	2688	2649	2649
query76	1894	1073	1186	1073
query77	516	282	292	282
query78	10476	9590	9631	9590
query79	1832	619	592	592
query80	1185	441	424	424
query81	536	247	245	245
query82	324	92	91	91
query83	169	182	153	153
query84	277	82	76	76
query85	984	319	291	291
query86	414	301	275	275
query87	4454	4316	4356	4316
query88	3714	2403	2374	2374
query89	421	298	289	289
query90	1973	189	192	189
query91	180	150	150	150
query92	69	53	53	53
query93	2522	570	568	568
query94	909	303	303	303
query95	357	265	257	257
query96	627	285	283	283
query97	3312	3171	3232	3171
query98	222	207	204	204
query99	1647	1306	1281	1281
Total cold run time: 319804 ms
Total hot run time: 198337 ms

@doris-robot
Copy link

doris-robot commented Mar 18, 2025

ClickBench: Total hot run time: 32.3 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 09558837e54f7cc35d4912392f3042c0e81de302, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.06
query4	1.64	0.10	0.10
query5	0.52	0.55	0.51
query6	1.13	0.73	0.72
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.52	0.52
query10	0.56	0.55	0.55
query11	0.14	0.11	0.11
query12	0.14	0.12	0.12
query13	0.62	0.61	0.59
query14	2.74	2.82	2.83
query15	0.92	0.82	0.84
query16	0.38	0.39	0.38
query17	1.01	1.08	1.04
query18	0.24	0.22	0.22
query19	1.94	1.87	2.07
query20	0.02	0.01	0.01
query21	15.35	0.58	0.57
query22	3.05	2.00	2.48
query23	16.90	0.91	0.74
query24	3.11	0.83	1.49
query25	0.18	0.07	0.15
query26	0.53	0.16	0.13
query27	0.04	0.04	0.05
query28	10.22	0.53	0.46
query29	12.58	3.25	3.23
query30	0.25	0.06	0.06
query31	2.85	0.39	0.38
query32	3.24	0.47	0.46
query33	3.02	3.03	3.03
query34	16.94	4.48	4.46
query35	4.51	4.53	4.53
query36	0.68	0.47	0.50
query37	0.08	0.06	0.06
query38	0.05	0.03	0.03
query39	0.04	0.02	0.02
query40	0.17	0.12	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.03
query43	0.03	0.03	0.03
Total cold run time: 106.89 s
Total hot run time: 32.3 s

dataroaring
dataroaring approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit b5232d2 into apache:branch-3.0 Mar 27, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LiBinfeng-01 @hello-stephen @morrySnow @doris-robot @dataroaring