Skip to content

Conversation

@mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Mar 17, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Mar 17, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32596 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0335524abf4cac496e204d523c7e0e73b6ef51d7, data reload: false

------ Round 1 ----------------------------------
q1	24482	5093	5127	5093
q2	2056	356	208	208
q3	10420	1286	710	710
q4	10227	1037	544	544
q5	7769	2402	2381	2381
q6	194	162	132	132
q7	950	765	614	614
q8	9301	1361	1094	1094
q9	4866	4828	4592	4592
q10	6810	2315	1885	1885
q11	469	278	257	257
q12	366	360	223	223
q13	17812	3682	3147	3147
q14	237	247	219	219
q15	534	491	473	473
q16	630	642	572	572
q17	566	861	358	358
q18	7104	6589	6341	6341
q19	1224	971	571	571
q20	333	342	216	216
q21	2951	2163	1988	1988
q22	1027	978	1019	978
Total cold run time: 110328 ms
Total hot run time: 32596 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5167	5194	5157	5157
q2	247	329	248	248
q3	2176	2753	2333	2333
q4	1453	1872	1420	1420
q5	4308	4259	4460	4259
q6	216	177	130	130
q7	2036	1926	1778	1778
q8	2667	2798	2632	2632
q9	7172	7277	7185	7185
q10	2985	3174	2773	2773
q11	580	508	494	494
q12	697	763	647	647
q13	3472	3872	3300	3300
q14	280	288	285	285
q15	530	477	484	477
q16	630	688	667	667
q17	1188	1576	1371	1371
q18	7834	7541	7614	7541
q19	818	849	1035	849
q20	2004	2066	1938	1938
q21	5580	4932	4680	4680
q22	1065	1087	972	972
Total cold run time: 53105 ms
Total hot run time: 51136 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185918 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0335524abf4cac496e204d523c7e0e73b6ef51d7, data reload: false

query1	1030	501	481	481
query2	6537	1891	1925	1891
query3	6809	219	219	219
query4	26768	23377	23312	23312
query5	4360	654	468	468
query6	285	183	207	183
query7	4747	507	294	294
query8	299	245	238	238
query9	8604	2585	2595	2585
query10	471	324	261	261
query11	15874	15502	14977	14977
query12	158	109	105	105
query13	1662	536	398	398
query14	9435	6773	6490	6490
query15	204	201	170	170
query16	7163	630	468	468
query17	1183	681	584	584
query18	1957	403	293	293
query19	186	174	147	147
query20	114	108	114	108
query21	207	120	101	101
query22	4060	4212	4119	4119
query23	33757	33056	32773	32773
query24	7765	2451	2415	2415
query25	552	436	402	402
query26	1219	270	155	155
query27	2495	475	326	326
query28	4278	2415	2398	2398
query29	723	549	425	425
query30	286	217	186	186
query31	939	913	771	771
query32	68	68	64	64
query33	562	358	312	312
query34	780	838	511	511
query35	786	807	725	725
query36	981	985	895	895
query37	120	107	77	77
query38	4096	4235	4129	4129
query39	1436	1431	1416	1416
query40	209	121	106	106
query41	60	56	56	56
query42	129	107	106	106
query43	512	510	483	483
query44	1329	796	840	796
query45	175	168	169	168
query46	859	1036	635	635
query47	1728	1776	1687	1687
query48	387	418	298	298
query49	778	490	417	417
query50	672	734	420	420
query51	4107	4175	4134	4134
query52	113	100	95	95
query53	243	266	192	192
query54	495	494	417	417
query55	82	80	85	80
query56	293	274	274	274
query57	1142	1124	1074	1074
query58	246	240	295	240
query59	2554	2703	2548	2548
query60	285	282	253	253
query61	127	125	128	125
query62	781	732	662	662
query63	229	194	192	192
query64	4289	995	712	712
query65	4447	4322	4386	4322
query66	1008	415	302	302
query67	15588	15317	15399	15317
query68	7456	881	508	508
query69	483	300	261	261
query70	1235	1136	1117	1117
query71	429	291	260	260
query72	5492	3559	3745	3559
query73	747	714	355	355
query74	9226	9092	8913	8913
query75	3174	3179	2675	2675
query76	3201	1209	776	776
query77	485	395	288	288
query78	9975	10157	9298	9298
query79	1774	847	580	580
query80	701	654	471	471
query81	506	259	221	221
query82	195	127	93	93
query83	180	172	155	155
query84	246	95	70	70
query85	765	359	309	309
query86	376	304	284	284
query87	4413	4512	4477	4477
query88	2915	2307	2316	2307
query89	395	323	278	278
query90	1823	219	225	219
query91	141	149	113	113
query92	70	62	56	56
query93	1296	1045	598	598
query94	660	390	377	377
query95	355	270	260	260
query96	487	557	280	280
query97	3263	3363	3290	3290
query98	230	208	208	208
query99	1333	1382	1279	1279
Total cold run time: 269850 ms
Total hot run time: 185918 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.46 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0335524abf4cac496e204d523c7e0e73b6ef51d7, data reload: false

query1	0.05	0.04	0.04
query2	0.12	0.10	0.09
query3	0.25	0.20	0.19
query4	1.59	0.20	0.18
query5	0.60	0.59	0.60
query6	1.18	0.72	0.72
query7	0.02	0.02	0.01
query8	0.04	0.04	0.03
query9	0.58	0.53	0.52
query10	0.62	0.59	0.58
query11	0.16	0.10	0.11
query12	0.14	0.11	0.11
query13	0.62	0.60	0.61
query14	2.66	2.68	2.68
query15	0.94	0.83	0.87
query16	0.38	0.40	0.37
query17	1.06	1.02	0.99
query18	0.22	0.19	0.19
query19	1.91	1.90	1.89
query20	0.01	0.02	0.01
query21	15.37	0.92	0.55
query22	0.74	1.14	0.63
query23	15.02	1.37	0.58
query24	6.71	1.18	1.06
query25	0.48	0.16	0.28
query26	0.52	0.15	0.14
query27	0.06	0.05	0.06
query28	10.29	0.96	0.43
query29	12.54	4.13	3.37
query30	0.27	0.09	0.06
query31	2.81	0.60	0.38
query32	3.23	0.54	0.47
query33	2.99	3.02	3.08
query34	15.87	5.09	4.51
query35	4.60	4.52	4.51
query36	0.69	0.50	0.49
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.03
query40	0.18	0.14	0.13
query41	0.08	0.03	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.85 s
Total hot run time: 31.46 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 27.45% (14/51) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 48.86% (13088/26785)
Line Coverage 38.42% (112746/293490)
Region Coverage 37.24% (57369/154046)
Branch Coverage 32.31% (28817/89182)

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 18, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zhannngchen zhannngchen merged commit c108335 into apache:master Mar 18, 2025
28 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 18, 2025
add some correctness check for test
dataroaring pushed a commit that referenced this pull request Mar 19, 2025
Cherry-picked from #49160

Co-authored-by: meiyi <meiyi@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.5-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants