Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #49160

add some correctness check for test
@github-actions github-actions bot requested a review from dataroaring as a code owner March 18, 2025 06:48
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 18, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40081 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4854a37be1f94c536c6e54220c1f6b0ba7a3b91f, data reload: false

------ Round 1 ----------------------------------
q1	17639	6836	6587	6587
q2	2108	173	156	156
q3	10659	1118	1173	1118
q4	10491	718	743	718
q5	7729	2893	2878	2878
q6	220	133	130	130
q7	983	632	617	617
q8	9390	1975	2069	1975
q9	6672	6412	6439	6412
q10	7015	2265	2332	2265
q11	470	275	255	255
q12	397	209	206	206
q13	17785	2961	2966	2961
q14	235	206	211	206
q15	508	457	455	455
q16	677	596	588	588
q17	996	584	553	553
q18	7392	6737	6664	6664
q19	1409	1093	1005	1005
q20	484	205	201	201
q21	4008	3268	3115	3115
q22	1102	1021	1016	1016
Total cold run time: 108369 ms
Total hot run time: 40081 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6623	6575	6604	6575
q2	333	236	234	234
q3	2902	2751	2947	2751
q4	2027	1810	1803	1803
q5	5761	5877	5732	5732
q6	209	126	124	124
q7	2225	1809	1808	1808
q8	3430	3592	3557	3557
q9	8743	8897	8867	8867
q10	3608	3551	3542	3542
q11	585	491	501	491
q12	825	582	600	582
q13	9758	3277	3156	3156
q14	301	266	266	266
q15	518	472	460	460
q16	705	658	657	657
q17	1861	1636	1600	1600
q18	8427	7737	7587	7587
q19	1662	1480	1644	1480
q20	2092	1889	1887	1887
q21	5597	5346	5447	5346
q22	1123	1040	1016	1016
Total cold run time: 69315 ms
Total hot run time: 59521 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196724 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4854a37be1f94c536c6e54220c1f6b0ba7a3b91f, data reload: false

query1	1299	916	925	916
query2	6223	2071	2031	2031
query3	10941	4315	4496	4315
query4	65892	28829	23552	23552
query5	4954	442	461	442
query6	397	184	165	165
query7	5559	302	309	302
query8	308	227	233	227
query9	8676	2606	2614	2606
query10	466	271	263	263
query11	17225	15258	15617	15258
query12	150	106	104	104
query13	1466	455	454	454
query14	10886	7757	6847	6847
query15	203	193	173	173
query16	7125	489	491	489
query17	1066	631	607	607
query18	1908	351	321	321
query19	210	158	156	156
query20	118	113	111	111
query21	205	106	106	106
query22	4776	4530	4463	4463
query23	34453	34099	34031	34031
query24	6226	2932	2930	2930
query25	538	421	447	421
query26	674	168	169	168
query27	2303	357	366	357
query28	4834	2466	2433	2433
query29	713	466	470	466
query30	237	160	163	160
query31	994	804	788	788
query32	67	53	54	53
query33	424	315	314	314
query34	907	503	507	503
query35	889	735	719	719
query36	1064	967	956	956
query37	122	70	64	64
query38	4094	3957	4014	3957
query39	1515	1479	1491	1479
query40	207	97	99	97
query41	49	60	47	47
query42	116	101	99	99
query43	519	501	493	493
query44	1196	817	813	813
query45	189	168	166	166
query46	1168	716	719	716
query47	2067	1915	1954	1915
query48	469	384	398	384
query49	713	409	406	406
query50	857	416	428	416
query51	7416	7192	7057	7057
query52	94	86	85	85
query53	255	175	175	175
query54	552	454	443	443
query55	76	74	74	74
query56	256	241	230	230
query57	1237	1102	1132	1102
query58	216	203	225	203
query59	3069	2837	2762	2762
query60	283	249	238	238
query61	111	106	139	106
query62	777	677	671	671
query63	219	184	192	184
query64	1378	658	620	620
query65	3222	3198	3237	3198
query66	726	293	291	291
query67	15914	15819	15738	15738
query68	4155	567	557	557
query69	430	268	263	263
query70	1216	1142	1129	1129
query71	353	254	261	254
query72	6409	4053	4005	4005
query73	747	340	351	340
query74	10320	8895	9197	8895
query75	3336	2548	2698	2548
query76	1965	1079	1078	1078
query77	495	266	291	266
query78	10504	9639	9685	9639
query79	2154	593	608	593
query80	1364	420	411	411
query81	525	242	240	240
query82	1287	92	88	88
query83	168	144	138	138
query84	290	80	80	80
query85	997	294	291	291
query86	412	312	273	273
query87	4497	4275	4283	4275
query88	3767	2409	2349	2349
query89	413	291	283	283
query90	1949	183	179	179
query91	186	146	147	146
query92	71	49	49	49
query93	2917	529	518	518
query94	868	264	299	264
query95	353	255	250	250
query96	616	272	274	272
query97	3314	3138	3216	3138
query98	215	207	200	200
query99	1570	1277	1302	1277
Total cold run time: 321321 ms
Total hot run time: 196724 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.96 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4854a37be1f94c536c6e54220c1f6b0ba7a3b91f, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.03
query3	0.23	0.07	0.06
query4	1.66	0.10	0.10
query5	0.51	0.53	0.50
query6	1.13	0.72	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.02
query9	0.56	0.49	0.48
query10	0.54	0.55	0.55
query11	0.15	0.11	0.11
query12	0.14	0.11	0.13
query13	0.62	0.59	0.59
query14	2.82	2.74	2.82
query15	0.89	0.83	0.81
query16	0.36	0.37	0.40
query17	1.10	1.02	1.04
query18	0.24	0.22	0.22
query19	1.91	1.87	2.00
query20	0.01	0.02	0.01
query21	15.37	0.58	0.57
query22	2.64	2.30	2.35
query23	16.93	0.87	0.95
query24	3.35	1.58	0.96
query25	0.20	0.23	0.24
query26	0.41	0.14	0.14
query27	0.05	0.04	0.03
query28	9.92	0.53	0.45
query29	12.56	3.24	3.23
query30	0.24	0.06	0.07
query31	2.85	0.39	0.39
query32	3.26	0.47	0.46
query33	3.01	3.03	3.02
query34	17.66	4.52	4.56
query35	4.56	4.58	4.64
query36	0.64	0.47	0.48
query37	0.08	0.06	0.06
query38	0.04	0.04	0.04
query39	0.04	0.02	0.02
query40	0.17	0.14	0.12
query41	0.08	0.02	0.02
query42	0.04	0.03	0.03
query43	0.03	0.03	0.04
Total cold run time: 107.17 s
Total hot run time: 32.96 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 27.45% (14/51) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.88% (10168/26155)
Line Coverage 30.31% (86715/286129)
Region Coverage 29.35% (44541/151768)
Branch Coverage 25.87% (22657/87572)

@mymeiyi
Copy link
Contributor

mymeiyi commented Mar 19, 2025

run buildall

2 similar comments
@dataroaring
Copy link
Contributor

run buildall

@dataroaring
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40285 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4854a37be1f94c536c6e54220c1f6b0ba7a3b91f, data reload: false

------ Round 1 ----------------------------------
q1	17573	6845	6618	6618
q2	2041	169	155	155
q3	10572	1154	1202	1154
q4	10214	731	724	724
q5	7711	2820	2850	2820
q6	218	134	132	132
q7	973	624	590	590
q8	9362	1985	2033	1985
q9	6623	6414	6435	6414
q10	6997	2324	2260	2260
q11	460	266	264	264
q12	399	209	209	209
q13	17765	2984	3091	2984
q14	250	220	217	217
q15	517	492	462	462
q16	647	594	587	587
q17	967	551	572	551
q18	7567	6697	6741	6697
q19	1387	1121	1058	1058
q20	488	201	200	200
q21	4241	3228	3373	3228
q22	1123	994	976	976
Total cold run time: 108095 ms
Total hot run time: 40285 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6675	6579	6620	6579
q2	329	240	230	230
q3	2920	2766	3076	2766
q4	2036	1861	1893	1861
q5	5802	5703	5736	5703
q6	202	125	126	125
q7	2214	1889	1821	1821
q8	3348	3519	3506	3506
q9	8989	8879	8868	8868
q10	3602	3524	3506	3506
q11	589	496	492	492
q12	820	620	642	620
q13	11582	3192	3164	3164
q14	315	273	270	270
q15	508	466	463	463
q16	681	639	637	637
q17	1850	1657	1591	1591
q18	8519	7811	7480	7480
q19	1656	1411	1542	1411
q20	2071	1821	1775	1775
q21	8343	5332	5105	5105
q22	1084	1001	1005	1001
Total cold run time: 74135 ms
Total hot run time: 58974 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190482 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4854a37be1f94c536c6e54220c1f6b0ba7a3b91f, data reload: false

query1	963	377	356	356
query2	6526	2038	1998	1998
query3	6702	221	230	221
query4	33773	23513	23738	23513
query5	4329	484	450	450
query6	273	172	178	172
query7	4618	313	323	313
query8	280	213	203	203
query9	9711	2566	2591	2566
query10	466	262	250	250
query11	18316	15123	15196	15123
query12	155	107	103	103
query13	1652	438	402	402
query14	9396	6956	7082	6956
query15	273	176	181	176
query16	8280	497	484	484
query17	1626	575	580	575
query18	2102	306	310	306
query19	292	160	169	160
query20	122	107	110	107
query21	214	104	104	104
query22	4483	4382	4368	4368
query23	36017	33599	33754	33599
query24	11914	2791	2882	2791
query25	642	404	408	404
query26	1420	173	170	170
query27	2836	338	335	335
query28	8017	2381	2404	2381
query29	696	453	435	435
query30	324	168	162	162
query31	1019	785	793	785
query32	103	61	60	60
query33	791	306	322	306
query34	902	500	504	500
query35	858	715	724	715
query36	1107	941	950	941
query37	228	72	77	72
query38	3925	3907	3908	3907
query39	1505	1427	1434	1427
query40	299	102	101	101
query41	54	50	56	50
query42	124	100	106	100
query43	523	489	479	479
query44	1270	796	791	791
query45	187	169	170	169
query46	1136	698	719	698
query47	1936	1833	1823	1823
query48	459	372	377	372
query49	1272	411	412	411
query50	807	421	418	418
query51	7253	7225	6921	6921
query52	101	92	91	91
query53	254	188	187	187
query54	1048	474	467	467
query55	80	76	78	76
query56	276	244	244	244
query57	1247	1095	1119	1095
query58	245	220	217	217
query59	3084	2846	2825	2825
query60	322	267	261	261
query61	110	110	108	108
query62	847	675	688	675
query63	221	187	191	187
query64	5042	658	675	658
query65	3276	3173	3173	3173
query66	1275	312	305	305
query67	15892	15682	15404	15404
query68	5394	565	548	548
query69	404	266	270	266
query70	1216	1046	1122	1046
query71	315	250	252	250
query72	6120	4081	4014	4014
query73	754	349	354	349
query74	10135	9193	8945	8945
query75	3351	2622	2698	2622
query76	3212	988	1150	988
query77	475	273	272	272
query78	10465	9588	9552	9552
query79	2378	606	610	606
query80	1158	426	432	426
query81	541	240	231	231
query82	881	88	86	86
query83	222	148	155	148
query84	244	83	89	83
query85	1288	320	288	288
query86	423	304	292	292
query87	4425	4261	4340	4261
query88	4050	2403	2362	2362
query89	397	297	292	292
query90	2015	186	187	186
query91	186	151	148	148
query92	74	49	52	49
query93	1516	558	542	542
query94	766	303	289	289
query95	361	261	263	261
query96	602	289	278	278
query97	3288	3150	3128	3128
query98	217	201	190	190
query99	1529	1318	1282	1282
Total cold run time: 303898 ms
Total hot run time: 190482 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.59 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4854a37be1f94c536c6e54220c1f6b0ba7a3b91f, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.02	0.03
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.50	0.52	0.50
query6	1.14	0.72	0.73
query7	0.02	0.01	0.02
query8	0.05	0.03	0.03
query9	0.57	0.51	0.49
query10	0.56	0.55	0.55
query11	0.14	0.10	0.11
query12	0.15	0.12	0.11
query13	0.60	0.61	0.59
query14	2.84	2.84	2.75
query15	0.89	0.82	0.83
query16	0.38	0.38	0.38
query17	1.04	0.97	1.05
query18	0.24	0.23	0.23
query19	2.00	1.83	2.00
query20	0.02	0.01	0.00
query21	15.39	0.59	0.60
query22	2.73	2.68	1.73
query23	17.02	0.80	0.82
query24	3.00	1.77	0.47
query25	0.33	0.06	0.11
query26	0.43	0.14	0.14
query27	0.04	0.04	0.04
query28	10.37	0.56	0.45
query29	12.59	3.25	3.26
query30	0.25	0.06	0.06
query31	2.85	0.39	0.38
query32	3.25	0.46	0.48
query33	2.98	3.03	3.04
query34	17.28	4.47	4.54
query35	4.65	4.59	4.57
query36	0.68	0.48	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.04	0.03	0.03
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.44 s
Total hot run time: 31.59 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 27.45% (14/51) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.88% (10168/26155)
Line Coverage 30.30% (86710/286129)
Region Coverage 29.35% (44551/151768)
Branch Coverage 25.88% (22664/87572)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 43fff62 into branch-3.0 Mar 19, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49160-branch-3.0 branch March 19, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants