-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](load) fix dead lock when write memtable failed #49170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 32349 ms |
TPC-DS: Total hot run time: 185172 ms |
ClickBench: Total hot run time: 31.48 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 32112 ms |
TPC-DS: Total hot run time: 192021 ms |
ClickBench: Total hot run time: 31.27 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Related PR: #48489 Problem Summary: The _mem_table_ptr_lock will be locked in _reset_mem_table, so don't need to be acquired in MemTableWriter::write.
Related PR: apache#48489 Problem Summary: The _mem_table_ptr_lock will be locked in _reset_mem_table, so don't need to be acquired in MemTableWriter::write.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #48489
Problem Summary:
The _mem_table_ptr_lock will be locked in _reset_mem_table, so don't need to be acquired in MemTableWriter::write.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)