Skip to content

[fix](nereids)Fix dlog1, trim, extract_url_parameter and parse_url FE constant calculate bug. (#49074) #49224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Mar 19, 2025
Merged

[fix](nereids)Fix dlog1, trim, extract_url_parameter and parse_url FE constant calculate bug. (#49074) #49224

yiguolei merged 1 commit into from
Mar 19, 2025

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Mar 18, 2025

backport: #49074

@Jibing-Li
[fix](nereids)Fix dlog1, trim, extract_url_parameter and parse_url FE…
1ccf813 
… constant calculate bug. (apache#49074)

1. dlog1 should use Math.log
2. trim/ltrim/rtrim shouldn't use regex
3. extract_url_parameter shouldn't fetch ref part.
4. parse_url need to return NULL instream of literal 'null' when we
couldn't get the requested part.
@Jibing-Li Jibing-Li marked this pull request as ready for review March 18, 2025 14:22
@Thearas
Copy link
Contributor

Thearas commented Mar 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li requested a review from yiguolei as a code owner March 18, 2025 14:22
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Mar 18, 2025

run buildall

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Mar 18, 2025

run external

1 similar comment
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Mar 18, 2025

run external

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Mar 19, 2025

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit cc41d61 into apache:branch-2.1 Mar 19, 2025
21 checks passed
@Jibing-Li Jibing-Li deleted the dlog12.1 branch March 20, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jibing-Li @Thearas @yiguolei