Skip to content

[fix](nereids)Fix dlog1, trim, extract_url_parameter and parse_url FE constant calculate bug. #49074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jibing-Li merged 1 commit into from
Mar 18, 2025
Merged

[fix](nereids)Fix dlog1, trim, extract_url_parameter and parse_url FE constant calculate bug. #49074

Jibing-Li merged 1 commit into from
Mar 18, 2025

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Mar 14, 2025

What problem does this PR solve?

  1. dlog1 should use Math.log
  2. trim/ltrim/rtrim shouldn't use regex
  3. extract_url_parameter shouldn't fetch ref part.
  4. parse_url need to return NULL instream of literal 'null' when we couldn't get the requested part.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li force-pushed the dlog1 branch 4 times, most recently from b5d71ad to 6860b3e Compare March 14, 2025 07:51
@Jibing-Li Jibing-Li marked this pull request as ready for review March 14, 2025 07:56
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Mar 14, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 14, 2025

TPC-H: Total hot run time: 32450 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6860b3e0c34c59d45cc896f7f0c0e162f95c2e88, data reload: false

------ Round 1 ----------------------------------
q1	17582	5246	5109	5109
q2	2051	289	162	162
q3	10419	1409	719	719
q4	10231	1015	558	558
q5	7901	2413	2347	2347
q6	197	168	135	135
q7	906	746	607	607
q8	9290	1256	1105	1105
q9	4900	4686	4805	4686
q10	6807	2311	1918	1918
q11	471	286	253	253
q12	345	352	220	220
q13	17791	3738	3043	3043
q14	232	219	212	212
q15	535	479	474	474
q16	610	633	589	589
q17	569	857	340	340
q18	7127	6489	6317	6317
q19	1223	966	571	571
q20	322	326	192	192
q21	2923	2191	1932	1932
q22	1031	1012	961	961
Total cold run time: 103463 ms
Total hot run time: 32450 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5388	5172	5148	5148
q2	243	321	229	229
q3	2161	2698	2296	2296
q4	1412	1833	1411	1411
q5	4250	4111	4115	4111
q6	207	167	125	125
q7	1922	1940	1771	1771
q8	2626	2712	2571	2571
q9	7178	7260	7296	7260
q10	2987	3102	2810	2810
q11	573	514	490	490
q12	701	782	628	628
q13	3477	3891	3345	3345
q14	272	304	295	295
q15	534	472	488	472
q16	660	674	647	647
q17	1152	1609	1395	1395
q18	7782	7663	7516	7516
q19	812	887	996	887
q20	1980	2030	1905	1905
q21	5339	4907	4915	4907
q22	1114	1057	995	995
Total cold run time: 52770 ms
Total hot run time: 51214 ms

@doris-robot
Copy link

doris-robot commented Mar 14, 2025

TPC-DS: Total hot run time: 193177 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6860b3e0c34c59d45cc896f7f0c0e162f95c2e88, data reload: false

query1	1413	1029	992	992
query2	6141	1935	1910	1910
query3	11036	4538	4574	4538
query4	54092	24707	23378	23378
query5	5315	566	478	478
query6	423	192	186	186
query7	5619	529	294	294
query8	343	244	250	244
query9	7867	2644	2647	2644
query10	471	321	263	263
query11	16101	15119	15026	15026
query12	169	111	111	111
query13	1472	549	409	409
query14	10281	6733	6667	6667
query15	211	207	190	190
query16	6929	680	487	487
query17	1106	778	607	607
query18	1554	412	342	342
query19	208	202	177	177
query20	128	132	138	132
query21	216	134	110	110
query22	4600	4636	4244	4244
query23	34189	33370	33538	33370
query24	6279	2476	2478	2476
query25	464	483	413	413
query26	724	281	161	161
query27	2079	519	340	340
query28	2942	2503	2467	2467
query29	586	587	448	448
query30	269	221	193	193
query31	883	832	800	800
query32	76	70	63	63
query33	445	370	320	320
query34	769	878	519	519
query35	804	846	756	756
query36	932	1022	919	919
query37	122	109	80	80
query38	4355	4362	4394	4362
query39	1510	1466	1435	1435
query40	209	126	112	112
query41	60	56	50	50
query42	126	109	107	107
query43	516	523	491	491
query44	1392	825	819	819
query45	188	175	173	173
query46	877	1053	663	663
query47	1844	1889	1807	1807
query48	394	431	317	317
query49	714	508	469	469
query50	754	777	439	439
query51	4309	4350	4244	4244
query52	116	114	101	101
query53	248	265	192	192
query54	483	512	420	420
query55	85	81	87	81
query56	292	294	283	283
query57	1161	1157	1123	1123
query58	259	244	237	237
query59	2713	2870	2587	2587
query60	288	282	267	267
query61	123	119	123	119
query62	744	744	685	685
query63	236	197	185	185
query64	1494	1040	678	678
query65	4483	4334	4343	4334
query66	719	453	294	294
query67	16043	15666	15397	15397
query68	7101	896	492	492
query69	540	304	261	261
query70	1234	1143	1080	1080
query71	506	295	280	280
query72	5772	3698	4022	3698
query73	1028	796	348	348
query74	9196	9229	8998	8998
query75	3739	3189	2730	2730
query76	4263	1212	759	759
query77	602	383	333	333
query78	10093	10140	9244	9244
query79	3221	849	596	596
query80	696	548	459	459
query81	504	258	233	233
query82	441	129	101	101
query83	275	171	164	164
query84	293	92	81	81
query85	789	369	323	323
query86	343	313	288	288
query87	4492	4570	4322	4322
query88	3335	2291	2270	2270
query89	402	313	280	280
query90	1932	229	229	229
query91	146	149	114	114
query92	75	69	57	57
query93	2007	1073	575	575
query94	670	414	319	319
query95	353	269	262	262
query96	495	586	279	279
query97	3345	3393	3303	3303
query98	228	205	202	202
query99	1460	1398	1272	1272
Total cold run time: 303569 ms
Total hot run time: 193177 ms

@doris-robot
Copy link

doris-robot commented Mar 14, 2025

ClickBench: Total hot run time: 31.49 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6860b3e0c34c59d45cc896f7f0c0e162f95c2e88, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.63	0.10	0.11
query5	0.56	0.55	0.55
query6	1.19	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.58	0.51	0.51
query10	0.56	0.60	0.58
query11	0.16	0.12	0.11
query12	0.15	0.11	0.12
query13	0.61	0.61	0.59
query14	2.69	2.69	2.70
query15	0.92	0.86	0.85
query16	0.38	0.37	0.38
query17	1.05	1.01	1.00
query18	0.21	0.20	0.20
query19	1.88	1.76	1.98
query20	0.02	0.01	0.01
query21	15.39	0.94	0.56
query22	0.76	1.25	0.71
query23	14.80	1.38	0.61
query24	7.04	1.48	1.49
query25	0.51	0.25	0.08
query26	0.47	0.17	0.13
query27	0.05	0.05	0.05
query28	10.40	0.85	0.44
query29	12.56	3.98	3.34
query30	0.25	0.09	0.07
query31	2.83	0.58	0.40
query32	3.23	0.57	0.47
query33	2.98	3.02	3.02
query34	15.71	5.14	4.51
query35	4.54	4.53	4.50
query36	0.66	0.49	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.03
query43	0.03	0.03	0.03
Total cold run time: 105.68 s
Total hot run time: 31.49 s

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Mar 14, 2025

run buildall

morrySnow
morrySnow previously approved these changes Mar 14, 2025
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Mar 14, 2025

TPC-H: Total hot run time: 32282 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 121305739853f20fcd31aae2b37c340b807c6c3e, data reload: false

------ Round 1 ----------------------------------
q1	17597	5227	5029	5029
q2	2041	293	164	164
q3	10413	1332	695	695
q4	10222	1022	513	513
q5	8094	2434	2331	2331
q6	191	161	130	130
q7	901	735	593	593
q8	9293	1298	1108	1108
q9	5051	4894	4717	4717
q10	6817	2349	1881	1881
q11	490	269	250	250
q12	350	348	215	215
q13	17771	3651	3092	3092
q14	219	235	209	209
q15	522	490	473	473
q16	631	631	576	576
q17	572	873	340	340
q18	6796	6495	6318	6318
q19	1673	966	545	545
q20	317	325	195	195
q21	2822	2348	1926	1926
q22	1024	1026	982	982
Total cold run time: 103807 ms
Total hot run time: 32282 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5201	5076	5080	5076
q2	234	329	237	237
q3	2136	2657	2316	2316
q4	1416	1816	1357	1357
q5	4240	4104	4196	4104
q6	201	165	123	123
q7	1875	1821	1662	1662
q8	2552	2597	2525	2525
q9	7292	7152	7089	7089
q10	2973	3193	2762	2762
q11	558	501	492	492
q12	696	765	632	632
q13	3536	3927	3320	3320
q14	279	293	268	268
q15	520	475	496	475
q16	655	697	644	644
q17	1100	1580	1307	1307
q18	7625	7479	7294	7294
q19	825	792	884	792
q20	1955	2012	1866	1866
q21	5548	4942	4916	4916
q22	1140	1066	1019	1019
Total cold run time: 52557 ms
Total hot run time: 50276 ms

@doris-robot
Copy link

doris-robot commented Mar 14, 2025

TPC-DS: Total hot run time: 187151 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 121305739853f20fcd31aae2b37c340b807c6c3e, data reload: false

query1	883	381	381	381
query2	6526	1986	1994	1986
query3	6552	208	218	208
query4	25419	23174	23410	23174
query5	4391	660	463	463
query6	299	194	204	194
query7	4615	507	296	296
query8	305	246	233	233
query9	8619	2645	2632	2632
query10	504	309	250	250
query11	15565	15146	14980	14980
query12	165	108	109	108
query13	1656	525	427	427
query14	9967	6590	6625	6590
query15	209	194	172	172
query16	7684	651	480	480
query17	1252	703	567	567
query18	1997	413	304	304
query19	242	180	147	147
query20	122	110	110	110
query21	204	118	100	100
query22	4210	4509	4676	4509
query23	34388	33647	33452	33452
query24	8265	2400	2400	2400
query25	561	465	388	388
query26	1276	275	152	152
query27	2120	532	332	332
query28	4190	2433	2458	2433
query29	726	570	425	425
query30	284	225	197	197
query31	961	864	792	792
query32	72	65	64	64
query33	569	379	299	299
query34	808	856	510	510
query35	815	848	752	752
query36	947	1032	902	902
query37	130	103	77	77
query38	4299	4366	4146	4146
query39	1509	1418	1463	1418
query40	208	112	114	112
query41	59	59	56	56
query42	114	105	104	104
query43	524	520	502	502
query44	1320	799	792	792
query45	173	180	164	164
query46	854	1029	636	636
query47	1889	1975	1909	1909
query48	392	416	296	296
query49	784	504	411	411
query50	690	718	401	401
query51	4182	4170	4180	4170
query52	103	102	94	94
query53	229	257	190	190
query54	487	482	408	408
query55	77	74	81	74
query56	280	259	273	259
query57	1157	1163	1076	1076
query58	245	241	267	241
query59	2715	2845	2872	2845
query60	269	267	252	252
query61	119	121	122	121
query62	766	720	662	662
query63	228	182	183	182
query64	4170	1053	678	678
query65	4446	4349	4341	4341
query66	1027	390	292	292
query67	15655	15544	15437	15437
query68	8145	886	494	494
query69	465	296	275	275
query70	1252	1079	1106	1079
query71	463	292	267	267
query72	5320	3548	3664	3548
query73	770	725	345	345
query74	9139	8800	8999	8800
query75	3872	3139	2688	2688
query76	3765	1180	750	750
query77	795	364	285	285
query78	10005	10118	9282	9282
query79	2695	817	574	574
query80	660	510	455	455
query81	468	261	224	224
query82	697	128	96	96
query83	167	167	154	154
query84	262	92	75	75
query85	793	374	309	309
query86	387	291	275	275
query87	4419	4591	4378	4378
query88	3679	2269	2257	2257
query89	398	319	286	286
query90	1871	208	209	208
query91	138	162	111	111
query92	78	58	59	58
query93	1721	1051	579	579
query94	676	405	252	252
query95	361	272	363	272
query96	479	559	279	279
query97	3318	3425	3308	3308
query98	220	202	201	201
query99	1423	1393	1232	1232
Total cold run time: 275369 ms
Total hot run time: 187151 ms

@doris-robot
Copy link

doris-robot commented Mar 14, 2025

ClickBench: Total hot run time: 30.79 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 121305739853f20fcd31aae2b37c340b807c6c3e, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.03	0.03
query3	0.23	0.06	0.07
query4	1.63	0.10	0.10
query5	0.54	0.54	0.54
query6	1.19	0.73	0.72
query7	0.03	0.01	0.02
query8	0.05	0.03	0.04
query9	0.60	0.51	0.52
query10	0.58	0.57	0.60
query11	0.16	0.12	0.10
query12	0.14	0.11	0.11
query13	0.61	0.59	0.61
query14	2.69	2.71	2.69
query15	0.92	0.84	0.84
query16	0.38	0.38	0.37
query17	1.01	1.04	1.03
query18	0.21	0.20	0.20
query19	1.90	1.77	1.98
query20	0.01	0.01	0.00
query21	15.35	0.87	0.53
query22	0.75	1.15	0.60
query23	15.11	1.29	0.65
query24	7.28	1.16	0.91
query25	0.47	0.20	0.12
query26	0.65	0.17	0.13
query27	0.06	0.06	0.05
query28	8.82	0.86	0.43
query29	12.54	3.93	3.28
query30	0.25	0.08	0.06
query31	2.85	0.60	0.38
query32	3.23	0.55	0.47
query33	2.98	3.02	3.17
query34	15.72	5.14	4.52
query35	4.58	4.56	4.55
query36	0.66	0.49	0.48
query37	0.08	0.06	0.06
query38	0.06	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.13	0.12
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.78 s
Total hot run time: 30.79 s

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Mar 14, 2025

run p0

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Mar 16, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 16, 2025

TPC-H: Total hot run time: 32401 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 927f1a7e35a203b2a445d6950cfae80b6d7bb35b, data reload: false

------ Round 1 ----------------------------------
q1	17597	5169	5053	5053
q2	2047	280	163	163
q3	10434	1240	770	770
q4	10196	1044	535	535
q5	7531	2361	2302	2302
q6	185	158	130	130
q7	900	729	617	617
q8	9296	1217	1112	1112
q9	4880	4676	4748	4676
q10	6800	2293	1911	1911
q11	471	267	256	256
q12	346	350	210	210
q13	17765	3641	3104	3104
q14	230	233	209	209
q15	519	473	475	473
q16	622	644	570	570
q17	575	843	346	346
q18	6861	6362	6292	6292
q19	1724	956	537	537
q20	310	330	209	209
q21	2686	2192	1940	1940
q22	1059	1031	986	986
Total cold run time: 103034 ms
Total hot run time: 32401 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5185	5116	5178	5116
q2	238	330	240	240
q3	2230	2743	2357	2357
q4	1456	1847	1404	1404
q5	4260	4162	4242	4162
q6	204	168	123	123
q7	1919	1921	1805	1805
q8	2626	2656	2598	2598
q9	7424	7322	7199	7199
q10	2988	3228	2766	2766
q11	570	517	483	483
q12	697	763	596	596
q13	3342	3866	3304	3304
q14	294	297	272	272
q15	537	478	478	478
q16	661	707	659	659
q17	1147	1559	1339	1339
q18	7739	7551	7456	7456
q19	809	763	820	763
q20	1929	2013	1896	1896
q21	5398	4894	4636	4636
q22	1070	1067	1018	1018
Total cold run time: 52723 ms
Total hot run time: 50670 ms

@doris-robot
Copy link

doris-robot commented Mar 16, 2025

TPC-DS: Total hot run time: 191673 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 927f1a7e35a203b2a445d6950cfae80b6d7bb35b, data reload: false

query1	1376	1021	989	989
query2	6119	1940	1934	1934
query3	10954	4494	4394	4394
query4	54015	25396	23043	23043
query5	5124	534	479	479
query6	340	194	184	184
query7	4894	517	292	292
query8	329	248	238	238
query9	5691	2608	2632	2608
query10	407	319	257	257
query11	15051	16626	14840	14840
query12	152	112	106	106
query13	1043	517	402	402
query14	10988	7001	6501	6501
query15	198	196	194	194
query16	7048	646	478	478
query17	1078	708	575	575
query18	1521	400	310	310
query19	202	195	158	158
query20	122	117	118	117
query21	204	119	106	106
query22	4725	4589	4532	4532
query23	33742	33484	33232	33232
query24	5762	2413	2438	2413
query25	449	490	410	410
query26	701	279	152	152
query27	1761	502	344	344
query28	2812	2475	2453	2453
query29	592	569	442	442
query30	285	221	186	186
query31	866	878	785	785
query32	74	64	64	64
query33	457	355	323	323
query34	781	851	519	519
query35	805	841	735	735
query36	951	978	911	911
query37	123	102	79	79
query38	4305	4218	4086	4086
query39	1476	1456	1427	1427
query40	219	123	119	119
query41	59	55	59	55
query42	161	106	103	103
query43	493	513	478	478
query44	1278	817	799	799
query45	178	180	167	167
query46	857	1032	650	650
query47	1886	1901	1810	1810
query48	394	436	328	328
query49	692	525	407	407
query50	711	739	412	412
query51	4240	4310	4257	4257
query52	109	110	92	92
query53	235	267	190	190
query54	484	502	412	412
query55	81	77	80	77
query56	264	274	266	266
query57	1201	1179	1103	1103
query58	255	244	244	244
query59	2791	2791	2591	2591
query60	291	291	262	262
query61	129	122	121	121
query62	752	729	688	688
query63	233	196	188	188
query64	1497	1042	752	752
query65	4596	4513	4520	4513
query66	740	408	297	297
query67	15837	15518	15380	15380
query68	7316	822	502	502
query69	531	299	256	256
query70	1174	1097	1097	1097
query71	459	288	256	256
query72	5721	3629	3763	3629
query73	1315	743	353	353
query74	8827	9111	8985	8985
query75	3685	3155	2723	2723
query76	4086	1192	765	765
query77	638	365	274	274
query78	10019	9950	9188	9188
query79	2672	834	579	579
query80	724	534	456	456
query81	488	257	221	221
query82	672	127	93	93
query83	300	169	153	153
query84	290	89	78	78
query85	811	394	458	394
query86	388	292	282	282
query87	4393	4487	4255	4255
query88	3474	2310	2269	2269
query89	426	306	273	273
query90	1855	205	203	203
query91	150	144	114	114
query92	74	61	56	56
query93	1401	1038	586	586
query94	675	405	284	284
query95	350	264	256	256
query96	488	562	281	281
query97	3311	3427	3265	3265
query98	251	211	207	207
query99	1427	1377	1281	1281
Total cold run time: 296577 ms
Total hot run time: 191673 ms

@doris-robot
Copy link

doris-robot commented Mar 16, 2025

ClickBench: Total hot run time: 30.98 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 927f1a7e35a203b2a445d6950cfae80b6d7bb35b, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.04	0.03
query3	0.24	0.06	0.06
query4	1.63	0.11	0.10
query5	0.56	0.54	0.54
query6	1.19	0.71	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.58	0.51	0.52
query10	0.57	0.60	0.58
query11	0.16	0.11	0.11
query12	0.15	0.12	0.11
query13	0.60	0.60	0.60
query14	2.70	2.82	2.82
query15	0.93	0.84	0.84
query16	0.38	0.39	0.38
query17	1.04	1.00	1.03
query18	0.21	0.20	0.19
query19	1.90	1.81	2.00
query20	0.01	0.01	0.01
query21	15.36	0.91	0.55
query22	0.74	1.19	0.91
query23	14.69	1.36	0.60
query24	6.92	2.21	0.76
query25	0.54	0.07	0.17
query26	0.63	0.16	0.12
query27	0.06	0.05	0.05
query28	9.36	0.88	0.43
query29	12.56	3.98	3.29
query30	0.25	0.09	0.07
query31	2.83	0.58	0.37
query32	3.23	0.55	0.47
query33	2.97	3.01	3.03
query34	16.07	5.09	4.48
query35	4.49	4.53	4.56
query36	0.66	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.13	0.12
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.02	0.02
Total cold run time: 104.89 s
Total hot run time: 30.98 s

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 18, 2025
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Mar 18, 2025

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 18, 2025
@doris-robot
Copy link

doris-robot commented Mar 18, 2025

TPC-H: Total hot run time: 32577 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f7c2b09b76719d30280d33d3b9805245e82b4dba, data reload: false

------ Round 1 ----------------------------------
q1	24451	5300	5047	5047
q2	2061	356	184	184
q3	10499	1252	689	689
q4	10238	1023	544	544
q5	7869	2400	2368	2368
q6	191	164	132	132
q7	911	777	601	601
q8	9289	1297	1093	1093
q9	4996	4804	4839	4804
q10	6807	2293	1920	1920
q11	465	266	251	251
q12	343	354	208	208
q13	17780	3679	3051	3051
q14	226	225	206	206
q15	543	491	480	480
q16	630	603	572	572
q17	591	859	341	341
q18	6764	6517	6414	6414
q19	2031	973	553	553
q20	314	325	193	193
q21	2803	2197	1936	1936
q22	1094	1037	990	990
Total cold run time: 110896 ms
Total hot run time: 32577 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5285	5531	5177	5177
q2	240	336	229	229
q3	2150	2659	2261	2261
q4	1419	1825	1381	1381
q5	4272	4233	4434	4233
q6	220	168	127	127
q7	2003	1916	1786	1786
q8	2595	2576	2554	2554
q9	7281	7303	7199	7199
q10	2964	3132	2779	2779
q11	596	493	494	493
q12	767	780	622	622
q13	3527	3904	3238	3238
q14	285	306	278	278
q15	533	478	495	478
q16	663	682	657	657
q17	1150	1630	1360	1360
q18	7893	7612	7662	7612
q19	836	825	901	825
q20	2011	2013	1860	1860
q21	5386	4826	4933	4826
q22	1140	1085	1052	1052
Total cold run time: 53216 ms
Total hot run time: 51027 ms

@doris-robot
Copy link

doris-robot commented Mar 18, 2025

TPC-DS: Total hot run time: 192552 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f7c2b09b76719d30280d33d3b9805245e82b4dba, data reload: false

query1	1397	1053	1024	1024
query2	6221	1956	1930	1930
query3	11162	4597	4569	4569
query4	25729	23816	23429	23429
query5	4309	654	486	486
query6	301	189	195	189
query7	3984	543	305	305
query8	300	249	240	240
query9	8487	2633	2587	2587
query10	459	314	251	251
query11	15560	15088	14841	14841
query12	166	111	102	102
query13	1568	531	398	398
query14	8937	6471	6162	6162
query15	210	186	177	177
query16	7340	648	470	470
query17	1170	757	589	589
query18	1980	407	334	334
query19	197	186	165	165
query20	123	124	128	124
query21	220	131	110	110
query22	4461	4680	4479	4479
query23	34323	33597	33495	33495
query24	8011	2424	2450	2424
query25	523	460	390	390
query26	1304	272	156	156
query27	2744	495	326	326
query28	4972	2494	2424	2424
query29	710	586	439	439
query30	278	224	202	202
query31	943	925	788	788
query32	109	66	67	66
query33	535	400	320	320
query34	805	853	516	516
query35	816	864	775	775
query36	1006	1005	914	914
query37	117	97	72	72
query38	4285	4481	4227	4227
query39	1496	1413	1469	1413
query40	219	119	104	104
query41	57	53	52	52
query42	119	108	105	105
query43	511	509	498	498
query44	1312	794	792	792
query45	182	176	166	166
query46	847	1038	637	637
query47	1838	1885	1827	1827
query48	385	405	304	304
query49	760	526	414	414
query50	717	751	405	405
query51	4304	4326	4296	4296
query52	101	100	96	96
query53	239	262	187	187
query54	502	492	423	423
query55	81	83	78	78
query56	276	276	262	262
query57	1188	1179	1102	1102
query58	262	258	272	258
query59	2973	2862	2700	2700
query60	307	299	275	275
query61	153	142	144	142
query62	818	756	688	688
query63	232	192	194	192
query64	4297	1049	736	736
query65	4549	4487	4445	4445
query66	1076	412	297	297
query67	16037	15570	15592	15570
query68	8540	880	499	499
query69	473	303	279	279
query70	1288	1150	1137	1137
query71	459	286	272	272
query72	5745	3551	3761	3551
query73	774	747	348	348
query74	8987	8852	8851	8851
query75	3831	3177	2698	2698
query76	3710	1196	749	749
query77	792	362	294	294
query78	10047	10093	9200	9200
query79	2543	829	585	585
query80	637	547	438	438
query81	500	250	227	227
query82	646	124	98	98
query83	198	166	150	150
query84	291	94	73	73
query85	784	363	308	308
query86	375	294	284	284
query87	4488	4541	4406	4406
query88	3529	2260	2232	2232
query89	409	316	278	278
query90	1816	203	209	203
query91	142	137	109	109
query92	74	58	56	56
query93	1820	1050	573	573
query94	666	408	368	368
query95	350	270	266	266
query96	483	553	280	280
query97	3350	3358	3323	3323
query98	230	201	204	201
query99	1442	1405	1257	1257
Total cold run time: 281019 ms
Total hot run time: 192552 ms

@doris-robot
Copy link

doris-robot commented Mar 18, 2025

ClickBench: Total hot run time: 31.35 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f7c2b09b76719d30280d33d3b9805245e82b4dba, data reload: false

query1	0.04	0.04	0.04
query2	0.13	0.10	0.11
query3	0.24	0.19	0.18
query4	1.60	0.19	0.18
query5	0.58	0.58	0.59
query6	1.19	0.71	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.52	0.51
query10	0.60	0.59	0.57
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.60	0.60	0.60
query14	2.65	2.70	2.78
query15	0.91	0.86	0.85
query16	0.38	0.37	0.38
query17	1.01	1.03	1.04
query18	0.22	0.20	0.20
query19	1.88	1.89	1.86
query20	0.02	0.01	0.01
query21	15.36	0.92	0.53
query22	0.76	1.08	0.59
query23	15.11	1.38	0.64
query24	7.33	1.41	0.95
query25	0.54	0.29	0.06
query26	0.50	0.16	0.14
query27	0.06	0.05	0.05
query28	10.06	0.85	0.41
query29	12.54	4.07	3.35
query30	0.25	0.09	0.06
query31	2.84	0.57	0.39
query32	3.22	0.54	0.46
query33	3.08	3.08	3.07
query34	15.66	5.14	4.55
query35	4.55	4.55	4.56
query36	0.68	0.50	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106 s
Total hot run time: 31.35 s

@Jibing-Li Jibing-Li merged commit 5d97d3a into apache:master Mar 18, 2025
24 checks passed
@Jibing-Li Jibing-Li deleted the dlog1 branch March 18, 2025 14:10
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Mar 18, 2025
@Jibing-Li
[fix](nereids)Fix dlog1, trim, extract_url_parameter and parse_url FE…
1ccf813 
… constant calculate bug. (apache#49074)

1. dlog1 should use Math.log
2. trim/ltrim/rtrim shouldn't use regex
3. extract_url_parameter shouldn't fetch ref part.
4. parse_url need to return NULL instream of literal 'null' when we
couldn't get the requested part.
@Jibing-Li Jibing-Li mentioned this pull request Mar 18, 2025
Merged
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Mar 18, 2025
@Jibing-Li
[fix](nereids)Fix dlog1, trim, extract_url_parameter and parse_url FE…
2071e35 
… constant calculate bug. (apache#49074)

1. dlog1 should use Math.log
2. trim/ltrim/rtrim shouldn't use regex
3. extract_url_parameter shouldn't fetch ref part.
4. parse_url need to return NULL instream of literal 'null' when we
couldn't get the requested part.
@Jibing-Li Jibing-Li mentioned this pull request Mar 18, 2025
Merged
yiguolei pushed a commit that referenced this pull request Mar 19, 2025
@Jibing-Li
[fix](nereids)Fix dlog1, trim, extract_url_parameter and parse_url FE…
cc41d61 
… constant calculate bug. (#49074) (#49224)

backport: #49074
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Mar 20, 2025
@Jibing-Li
[fix](nereids)Fix dlog1, trim, extract_url_parameter and parse_url FE…
7399627 
… constant calculate bug. (apache#49074)

1. dlog1 should use Math.log
2. trim/ltrim/rtrim shouldn't use regex
3. extract_url_parameter shouldn't fetch ref part.
4. parse_url need to return NULL instream of literal 'null' when we
couldn't get the requested part.
dataroaring pushed a commit that referenced this pull request Mar 20, 2025
@Jibing-Li
branch-3.0: [fix](nereids)Fix dlog1, trim, extract_url_parameter and …
8b6ec5a 
…parse_url FE constant calculate bug. #49074 (#49225)

backport: #49074
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@Jibing-Li @koarz
[fix](nereids)Fix dlog1, trim, extract_url_parameter and parse_url FE…
d11c94c 
… constant calculate bug. (apache#49074)

### What problem does this PR solve?

1. dlog1 should use Math.log
2. trim/ltrim/rtrim shouldn't use regex
3. extract_url_parameter shouldn't fetch ref part.
4. parse_url need to return NULL instream of literal 'null' when we
couldn't get the requested part.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zclllyybb zclllyybb zclllyybb approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.5-merged p0_w reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Jibing-Li @Thearas @doris-robot @zclllyybb @morrySnow @yiguolei @dataroaring