Skip to content

Conversation

@Jibing-Li
Copy link
Contributor

backport: #49074

@Jibing-Li Jibing-Li marked this pull request as ready for review March 18, 2025 14:29
@Thearas
Copy link
Contributor

Thearas commented Mar 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li requested a review from dataroaring as a code owner March 18, 2025 14:29
@Jibing-Li
Copy link
Contributor Author

run buildall

2 similar comments
@Jibing-Li
Copy link
Contributor Author

run buildall

@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40259 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2071e355894b326011b4be82b3e152503564cbdb, data reload: false

------ Round 1 ----------------------------------
q1	17578	6718	6592	6592
q2	2068	171	163	163
q3	10846	1031	1160	1031
q4	10214	773	669	669
q5	7736	2825	2839	2825
q6	222	133	131	131
q7	984	613	613	613
q8	9668	1955	1994	1955
q9	6687	6498	6447	6447
q10	7056	2264	2242	2242
q11	461	258	265	258
q12	398	216	209	209
q13	18300	3042	3020	3020
q14	241	209	215	209
q15	496	469	458	458
q16	666	587	573	573
q17	982	613	642	613
q18	7248	6756	6761	6756
q19	1400	1066	1036	1036
q20	474	217	199	199
q21	4057	3214	3290	3214
q22	1169	1063	1046	1046
Total cold run time: 108951 ms
Total hot run time: 40259 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6623	6692	6684	6684
q2	333	243	252	243
q3	3071	2982	3155	2982
q4	2104	1896	1897	1896
q5	5971	5840	5792	5792
q6	211	126	130	126
q7	2245	1817	1740	1740
q8	3393	3560	3545	3545
q9	8902	8834	8878	8834
q10	3558	3768	3539	3539
q11	581	493	503	493
q12	855	601	616	601
q13	13714	3192	3186	3186
q14	295	261	273	261
q15	501	472	467	467
q16	704	659	655	655
q17	1839	1609	1601	1601
q18	8303	7916	7676	7676
q19	1663	1561	1594	1561
q20	2122	1881	1897	1881
q21	5456	5347	5251	5251
q22	1153	1062	1021	1021
Total cold run time: 73597 ms
Total hot run time: 60035 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196503 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2071e355894b326011b4be82b3e152503564cbdb, data reload: false

query1	1302	910	924	910
query2	6254	2169	2091	2091
query3	10801	4365	4416	4365
query4	65406	29102	23210	23210
query5	4928	457	453	453
query6	411	175	171	171
query7	5643	315	318	315
query8	299	223	222	222
query9	9375	2604	2568	2568
query10	463	287	253	253
query11	17610	15402	15747	15402
query12	151	107	105	105
query13	1522	449	449	449
query14	10899	7431	6696	6696
query15	226	181	168	168
query16	7365	489	494	489
query17	1095	591	583	583
query18	1899	335	312	312
query19	224	166	161	161
query20	121	108	112	108
query21	205	100	100	100
query22	5032	4491	4619	4491
query23	34308	33808	34047	33808
query24	6493	2941	2926	2926
query25	519	395	384	384
query26	686	168	164	164
query27	1959	353	364	353
query28	4176	2463	2445	2445
query29	702	452	432	432
query30	252	166	162	162
query31	981	828	841	828
query32	66	54	57	54
query33	460	291	294	291
query34	909	489	507	489
query35	891	729	727	727
query36	1096	965	950	950
query37	118	67	67	67
query38	4088	3988	3998	3988
query39	1522	1464	1515	1464
query40	208	96	97	96
query41	51	48	49	48
query42	111	96	97	96
query43	552	494	503	494
query44	1183	808	806	806
query45	182	168	170	168
query46	1153	701	741	701
query47	2087	1954	1994	1954
query48	498	400	404	400
query49	777	393	396	393
query50	839	427	428	427
query51	7465	7108	7245	7108
query52	97	85	89	85
query53	255	175	177	175
query54	548	451	440	440
query55	73	75	74	74
query56	254	239	234	234
query57	1230	1145	1137	1137
query58	230	195	208	195
query59	3248	3086	2907	2907
query60	295	251	255	251
query61	114	110	105	105
query62	789	670	685	670
query63	215	184	181	181
query64	1396	683	629	629
query65	3257	3210	3178	3178
query66	711	301	303	301
query67	16090	15584	15721	15584
query68	3621	592	575	575
query69	430	269	266	266
query70	1147	1108	1126	1108
query71	349	259	264	259
query72	6393	4021	4087	4021
query73	762	335	352	335
query74	10309	8941	9047	8941
query75	3352	2644	2652	2644
query76	1953	1036	1061	1036
query77	469	300	276	276
query78	10575	9588	9626	9588
query79	1148	607	581	581
query80	842	427	440	427
query81	509	236	235	235
query82	1303	91	90	90
query83	279	145	149	145
query84	288	81	73	73
query85	863	293	293	293
query86	325	271	305	271
query87	4408	4233	4285	4233
query88	3592	2414	2456	2414
query89	413	295	286	286
query90	2078	181	184	181
query91	177	149	150	149
query92	63	51	50	50
query93	1328	550	545	545
query94	795	293	286	286
query95	349	254	255	254
query96	615	280	281	280
query97	3364	3190	3203	3190
query98	218	198	192	192
query99	1553	1318	1288	1288
Total cold run time: 318235 ms
Total hot run time: 196503 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.1 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2071e355894b326011b4be82b3e152503564cbdb, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.54	0.50	0.51
query6	1.12	0.73	0.73
query7	0.02	0.02	0.01
query8	0.06	0.03	0.03
query9	0.56	0.51	0.51
query10	0.56	0.56	0.55
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.60	0.58
query14	2.73	2.83	2.76
query15	0.90	0.82	0.83
query16	0.40	0.39	0.39
query17	1.05	1.05	0.99
query18	0.23	0.22	0.22
query19	1.81	1.91	2.01
query20	0.01	0.01	0.01
query21	15.36	0.57	0.56
query22	2.51	2.25	2.13
query23	16.91	0.93	0.74
query24	3.50	1.17	0.67
query25	0.15	0.09	0.20
query26	0.56	0.13	0.13
query27	0.04	0.06	0.05
query28	10.32	0.49	0.46
query29	12.61	3.23	3.22
query30	0.25	0.05	0.06
query31	2.84	0.38	0.38
query32	3.27	0.45	0.47
query33	3.00	2.97	3.05
query34	17.08	4.46	4.50
query35	4.57	4.54	4.52
query36	0.66	0.49	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.94 s
Total hot run time: 32.1 s

… constant calculate bug. (apache#49074)

1. dlog1 should use Math.log
2. trim/ltrim/rtrim shouldn't use regex
3. extract_url_parameter shouldn't fetch ref part.
4. parse_url need to return NULL instream of literal 'null' when we
couldn't get the requested part.
@Jibing-Li
Copy link
Contributor Author

run buildall

@morrySnow morrySnow changed the title [fix](nereids)Fix dlog1, trim, extract_url_parameter and parse_url FE constant calculate bug. (#49074) branch-3.0: [fix](nereids)Fix dlog1, trim, extract_url_parameter and parse_url FE constant calculate bug. #49074 Mar 20, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 8b6ec5a into apache:branch-3.0 Mar 20, 2025
21 of 24 checks passed
@Jibing-Li Jibing-Li deleted the dlog13.0 branch March 20, 2025 14:15
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants