Skip to content

[feature](function) upper lower support utf8 input #49231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HappenLee merged 3 commits into from
Mar 20, 2025
Merged

[feature](function) upper lower support utf8 input #49231

HappenLee merged 3 commits into from
Mar 20, 2025

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Mar 19, 2025 •
edited
Loading

What problem does this PR solve?

upper lower supports SQL similar to this

select lower('ÀÇ')

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Mar 19, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 19, 2025

TPC-H: Total hot run time: 32291 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 13e357eb61988fc6d634fc5841eb90ac2bc8d95b, data reload: false

------ Round 1 ----------------------------------
q1	24288	5178	5193	5178
q2	2059	347	182	182
q3	10472	1269	706	706
q4	10241	1015	519	519
q5	7853	2405	2327	2327
q6	195	167	139	139
q7	912	755	612	612
q8	9306	1348	1042	1042
q9	4927	4659	4711	4659
q10	6817	2312	1865	1865
q11	480	267	258	258
q12	341	353	211	211
q13	17763	3696	3077	3077
q14	234	230	221	221
q15	528	473	487	473
q16	624	623	574	574
q17	584	869	343	343
q18	7016	6564	6251	6251
q19	1218	958	546	546
q20	321	328	199	199
q21	2928	2244	1933	1933
q22	1050	1042	976	976
Total cold run time: 110157 ms
Total hot run time: 32291 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5221	5170	5135	5135
q2	251	336	230	230
q3	2145	2644	2312	2312
q4	1453	1806	1401	1401
q5	4242	4126	4526	4126
q6	219	171	126	126
q7	2002	1967	1765	1765
q8	2642	2610	2581	2581
q9	7194	7281	7186	7186
q10	2989	3211	2742	2742
q11	580	506	500	500
q12	671	773	611	611
q13	3556	3915	3298	3298
q14	283	300	284	284
q15	521	487	476	476
q16	641	704	662	662
q17	1180	1605	1334	1334
q18	7885	7679	7605	7605
q19	857	880	1039	880
q20	1949	2050	1868	1868
q21	5562	4984	4761	4761
q22	1077	1057	1003	1003
Total cold run time: 53120 ms
Total hot run time: 50886 ms

@doris-robot
Copy link

doris-robot commented Mar 19, 2025

TPC-DS: Total hot run time: 185553 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 13e357eb61988fc6d634fc5841eb90ac2bc8d95b, data reload: false

query1	986	507	462	462
query2	6541	1922	1889	1889
query3	6802	212	209	209
query4	26770	23229	23457	23229
query5	4395	666	491	491
query6	308	200	189	189
query7	4600	498	291	291
query8	297	242	244	242
query9	8593	2631	2618	2618
query10	476	318	268	268
query11	15408	15175	14950	14950
query12	157	107	111	107
query13	1653	515	393	393
query14	8632	6176	6219	6176
query15	203	193	168	168
query16	7146	662	414	414
query17	1175	702	581	581
query18	1961	399	313	313
query19	195	181	158	158
query20	123	115	116	115
query21	212	123	108	108
query22	4271	4502	4409	4409
query23	34023	33306	33065	33065
query24	8478	2408	2351	2351
query25	530	448	389	389
query26	1226	268	152	152
query27	2751	485	331	331
query28	4414	2437	2422	2422
query29	752	569	419	419
query30	285	220	185	185
query31	946	843	771	771
query32	68	65	63	63
query33	564	382	302	302
query34	764	833	512	512
query35	786	796	738	738
query36	929	1030	899	899
query37	116	102	74	74
query38	4101	4218	4089	4089
query39	1427	1377	1401	1377
query40	198	114	103	103
query41	53	50	50	50
query42	127	103	100	100
query43	493	496	475	475
query44	1278	792	773	773
query45	174	167	162	162
query46	837	1030	617	617
query47	1770	1814	1715	1715
query48	374	416	303	303
query49	775	501	429	429
query50	688	726	411	411
query51	4209	4208	4113	4113
query52	107	104	91	91
query53	228	256	183	183
query54	480	489	406	406
query55	87	79	83	79
query56	277	258	243	243
query57	1139	1132	1086	1086
query58	242	242	251	242
query59	2478	2714	2553	2553
query60	287	276	241	241
query61	140	119	115	115
query62	789	715	705	705
query63	220	187	185	185
query64	4309	982	646	646
query65	4414	4322	4352	4322
query66	1134	404	308	308
query67	15878	15394	15224	15224
query68	7844	868	496	496
query69	464	297	260	260
query70	1206	1151	1117	1117
query71	446	347	263	263
query72	5329	3592	3701	3592
query73	788	733	347	347
query74	9059	9148	8939	8939
query75	3681	3152	2716	2716
query76	3657	1165	738	738
query77	795	358	276	276
query78	9953	10179	9360	9360
query79	2464	823	586	586
query80	731	521	447	447
query81	480	256	220	220
query82	471	126	96	96
query83	204	166	157	157
query84	279	98	69	69
query85	778	346	303	303
query86	338	282	291	282
query87	4457	4517	4351	4351
query88	3360	2277	2277	2277
query89	387	326	281	281
query90	1932	206	207	206
query91	145	139	107	107
query92	78	58	56	56
query93	1276	1069	572	572
query94	671	427	306	306
query95	353	324	261	261
query96	482	569	285	285
query97	3383	3375	3329	3329
query98	233	211	202	202
query99	1441	1365	1257	1257
Total cold run time: 273414 ms
Total hot run time: 185553 ms

@doris-robot
Copy link

doris-robot commented Mar 19, 2025

ClickBench: Total hot run time: 30.87 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 13e357eb61988fc6d634fc5841eb90ac2bc8d95b, data reload: false

query1	0.04	0.04	0.04
query2	0.12	0.10	0.11
query3	0.25	0.19	0.20
query4	1.59	0.20	0.18
query5	0.59	0.59	0.60
query6	1.18	0.72	0.71
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.59	0.51	0.53
query10	0.58	0.59	0.58
query11	0.16	0.12	0.11
query12	0.15	0.11	0.12
query13	0.61	0.59	0.60
query14	2.74	2.71	2.80
query15	0.92	0.85	0.85
query16	0.38	0.38	0.37
query17	1.02	1.07	1.01
query18	0.21	0.19	0.19
query19	1.93	2.00	1.85
query20	0.01	0.01	0.01
query21	15.35	0.91	0.54
query22	0.76	1.17	0.66
query23	14.92	1.35	0.59
query24	6.92	1.94	0.52
query25	0.51	0.24	0.09
query26	0.62	0.15	0.14
query27	0.05	0.05	0.04
query28	9.65	0.86	0.44
query29	12.55	4.00	3.38
query30	0.25	0.09	0.06
query31	2.81	0.58	0.39
query32	3.23	0.55	0.46
query33	2.94	3.03	3.00
query34	15.85	5.11	4.47
query35	4.52	4.56	4.54
query36	0.65	0.50	0.48
query37	0.08	0.06	0.06
query38	0.05	0.05	0.04
query39	0.03	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.19 s
Total hot run time: 30.87 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 19, 2025

BE UT Coverage Report

Increment line coverage 100.00% (45/45) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 48.90% (13099/26786)
Line Coverage 38.46% (112939/293674)
Region Coverage 37.26% (57423/154110)
Branch Coverage 32.34% (28852/89218)

zclllyybb
zclllyybb requested changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个得有足够多的testcase才行，把特殊情况都覆盖到。

@Mryange
Copy link
Contributor Author

Mryange commented Mar 19, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 19, 2025

TPC-H: Total hot run time: 32325 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 945e69dcd72428c75579e0deebc6451b3fa02878, data reload: false

------ Round 1 ----------------------------------
q1	24445	5022	5005	5005
q2	2051	310	209	209
q3	10349	1220	672	672
q4	10228	1005	517	517
q5	7531	2346	2321	2321
q6	178	160	131	131
q7	897	740	583	583
q8	9297	1270	1009	1009
q9	5107	4543	4841	4543
q10	6824	2292	1914	1914
q11	470	283	258	258
q12	347	353	213	213
q13	17769	3678	3090	3090
q14	243	244	238	238
q15	522	491	484	484
q16	621	625	617	617
q17	591	866	360	360
q18	7172	6547	6446	6446
q19	1240	951	561	561
q20	330	350	205	205
q21	2884	2156	1981	1981
q22	1064	1037	968	968
Total cold run time: 110160 ms
Total hot run time: 32325 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5146	5093	5122	5093
q2	237	330	233	233
q3	2141	2663	2267	2267
q4	1398	1797	1384	1384
q5	4206	4115	4406	4115
q6	213	170	129	129
q7	1986	1897	1745	1745
q8	2589	2601	2548	2548
q9	7213	7141	7237	7141
q10	2953	3186	2663	2663
q11	556	491	495	491
q12	744	797	644	644
q13	3524	3912	3258	3258
q14	288	298	263	263
q15	523	487	476	476
q16	626	698	640	640
q17	1148	1605	1360	1360
q18	7743	7663	7497	7497
q19	821	852	1017	852
q20	1991	2037	1894	1894
q21	5363	4703	4797	4703
q22	1085	1059	1051	1051
Total cold run time: 52494 ms
Total hot run time: 50447 ms

@doris-robot
Copy link

doris-robot commented Mar 19, 2025

TPC-DS: Total hot run time: 191762 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 945e69dcd72428c75579e0deebc6451b3fa02878, data reload: false

query1	1428	1058	1030	1030
query2	6200	2091	1906	1906
query3	11029	4618	4422	4422
query4	53693	25817	22926	22926
query5	5134	601	473	473
query6	367	196	193	193
query7	4982	525	311	311
query8	334	248	228	228
query9	6018	2634	2637	2634
query10	442	319	265	265
query11	15187	15165	14938	14938
query12	159	109	106	106
query13	1083	510	407	407
query14	10311	6432	6391	6391
query15	189	216	178	178
query16	7064	675	492	492
query17	1084	710	558	558
query18	1540	428	323	323
query19	195	192	163	163
query20	124	117	119	117
query21	212	134	106	106
query22	4547	4481	4370	4370
query23	34055	33301	33470	33301
query24	6529	2442	2425	2425
query25	468	462	396	396
query26	723	276	157	157
query27	2422	492	333	333
query28	3230	2461	2465	2461
query29	565	568	438	438
query30	279	220	196	196
query31	872	867	785	785
query32	79	68	62	62
query33	472	353	309	309
query34	758	831	510	510
query35	837	828	778	778
query36	966	1040	889	889
query37	124	104	76	76
query38	4207	4284	4223	4223
query39	1529	1435	1618	1435
query40	213	117	101	101
query41	54	51	48	48
query42	121	109	110	109
query43	514	536	492	492
query44	1313	795	797	795
query45	208	173	165	165
query46	826	1037	660	660
query47	1801	1905	1818	1818
query48	398	418	308	308
query49	697	522	428	428
query50	698	741	418	418
query51	4357	4297	4290	4290
query52	110	103	98	98
query53	246	264	188	188
query54	498	501	424	424
query55	81	80	85	80
query56	286	266	249	249
query57	1149	1180	1096	1096
query58	272	238	239	238
query59	2716	2906	2894	2894
query60	292	262	259	259
query61	123	122	117	117
query62	762	738	647	647
query63	238	186	194	186
query64	1855	1028	691	691
query65	4577	4455	4465	4455
query66	743	397	302	302
query67	15836	15488	15282	15282
query68	6976	877	496	496
query69	538	289	260	260
query70	1186	1131	1122	1122
query71	470	314	280	280
query72	5763	3763	3718	3718
query73	1212	716	350	350
query74	8897	9418	8740	8740
query75	3637	3166	2659	2659
query76	4100	1191	764	764
query77	646	362	280	280
query78	9932	10152	9294	9294
query79	2109	823	636	636
query80	620	534	462	462
query81	474	252	228	228
query82	470	128	98	98
query83	171	167	156	156
query84	281	97	75	75
query85	762	354	307	307
query86	356	308	304	304
query87	4486	4564	4333	4333
query88	3548	2247	2244	2244
query89	410	316	283	283
query90	1862	214	216	214
query91	143	138	114	114
query92	73	63	57	57
query93	1179	1074	577	577
query94	688	408	300	300
query95	356	271	265	265
query96	479	563	280	280
query97	3258	3416	3242	3242
query98	222	205	212	205
query99	1704	1405	1270	1270
Total cold run time: 297429 ms
Total hot run time: 191762 ms

@doris-robot
Copy link

doris-robot commented Mar 19, 2025

ClickBench: Total hot run time: 31.35 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 945e69dcd72428c75579e0deebc6451b3fa02878, data reload: false

query1	0.04	0.03	0.03
query2	0.12	0.10	0.10
query3	0.26	0.19	0.20
query4	1.59	0.19	0.19
query5	0.59	0.58	0.57
query6	1.17	0.70	0.71
query7	0.02	0.02	0.01
query8	0.04	0.04	0.03
query9	0.56	0.51	0.52
query10	0.57	0.59	0.57
query11	0.16	0.11	0.11
query12	0.15	0.11	0.11
query13	0.62	0.60	0.60
query14	2.66	2.81	2.78
query15	0.93	0.84	0.85
query16	0.38	0.38	0.37
query17	1.02	1.02	1.05
query18	0.22	0.19	0.20
query19	1.91	1.91	1.90
query20	0.01	0.02	0.01
query21	15.36	0.89	0.54
query22	0.75	1.18	0.64
query23	14.93	1.37	0.62
query24	6.71	2.15	1.11
query25	0.51	0.14	0.07
query26	0.60	0.16	0.14
query27	0.05	0.05	0.05
query28	9.58	0.80	0.41
query29	12.56	3.84	3.26
query30	0.25	0.09	0.07
query31	2.82	0.58	0.38
query32	3.23	0.58	0.45
query33	2.94	3.03	3.02
query34	16.08	5.13	4.47
query35	4.57	4.51	4.51
query36	0.66	0.48	0.47
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.12	0.12
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.11 s
Total hot run time: 31.35 s

zclllyybb
zclllyybb approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Mar 19, 2025

BE UT Coverage Report

Increment line coverage 100.00% (45/45) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 48.81% (13075/26787)
Line Coverage 38.39% (112755/293744)
Region Coverage 37.18% (57315/154154)
Branch Coverage 32.29% (28817/89244)

@Mryange
Copy link
Contributor Author

Mryange commented Mar 19, 2025

run cloud_p0

HappenLee
HappenLee reviewed Mar 20, 2025
View reviewed changes
be/src/vec/functions/function_string.cpp Outdated
sp.set(data, size);
icu::UnicodeString unicode_str = icu::UnicodeString::fromUTF8(sp);
unicode_str.toUpper();
std::string output;
Copy link
Contributor

@HappenLee HappenLee Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why pass output as the param, reuse the string mem.

@Mryange
Copy link
Contributor Author

Mryange commented Mar 20, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 20, 2025

TPC-H: Total hot run time: 32554 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 55bce316aae2a26640d2b8eddb7540e901fa9cf7, data reload: false

------ Round 1 ----------------------------------
q1	24018	5102	5073	5073
q2	2048	296	174	174
q3	10394	1237	692	692
q4	10227	1025	516	516
q5	7547	2402	2328	2328
q6	206	163	134	134
q7	943	724	623	623
q8	9318	1279	1199	1199
q9	4811	4604	4851	4604
q10	6877	2323	1909	1909
q11	475	282	264	264
q12	354	357	222	222
q13	17776	3694	3027	3027
q14	221	227	210	210
q15	536	483	479	479
q16	621	624	598	598
q17	572	857	351	351
q18	6742	6581	6395	6395
q19	1526	934	570	570
q20	339	340	197	197
q21	2831	2280	2013	2013
q22	1074	1037	976	976
Total cold run time: 109456 ms
Total hot run time: 32554 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5199	5174	5142	5142
q2	231	328	233	233
q3	2191	2641	2273	2273
q4	1436	1838	1400	1400
q5	4279	4184	4426	4184
q6	259	173	129	129
q7	2052	1924	1793	1793
q8	2633	2767	2647	2647
q9	7347	7288	7103	7103
q10	3020	3225	2670	2670
q11	577	509	521	509
q12	725	773	619	619
q13	3619	3903	3293	3293
q14	278	320	261	261
q15	519	473	484	473
q16	644	689	674	674
q17	1137	1570	1382	1382
q18	7740	7540	7590	7540
q19	852	861	971	861
q20	1997	2038	1885	1885
q21	5490	4812	4870	4812
q22	1120	1066	1006	1006
Total cold run time: 53345 ms
Total hot run time: 50889 ms

@doris-robot
Copy link

doris-robot commented Mar 20, 2025

TPC-DS: Total hot run time: 192183 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 55bce316aae2a26640d2b8eddb7540e901fa9cf7, data reload: false

query1	1420	1064	1036	1036
query2	6224	1902	1913	1902
query3	11049	4535	4448	4448
query4	54222	25672	23492	23492
query5	4957	574	492	492
query6	354	200	189	189
query7	4935	516	299	299
query8	320	270	230	230
query9	5918	2579	2602	2579
query10	439	307	255	255
query11	15120	14967	14867	14867
query12	162	108	111	108
query13	1084	523	402	402
query14	10280	6373	6521	6373
query15	203	198	178	178
query16	6952	650	511	511
query17	1102	746	561	561
query18	1427	401	315	315
query19	191	193	173	173
query20	121	130	116	116
query21	204	122	109	109
query22	4694	4481	4556	4481
query23	33917	33485	33252	33252
query24	6309	2400	2418	2400
query25	450	456	395	395
query26	731	272	153	153
query27	2234	509	332	332
query28	3167	2454	2433	2433
query29	550	568	464	464
query30	275	223	191	191
query31	860	867	759	759
query32	76	69	67	67
query33	431	355	295	295
query34	747	843	499	499
query35	795	846	752	752
query36	964	996	919	919
query37	121	102	78	78
query38	4327	4252	4139	4139
query39	1494	1427	1425	1425
query40	209	117	100	100
query41	52	51	50	50
query42	123	112	100	100
query43	516	495	476	476
query44	1308	814	822	814
query45	178	173	172	172
query46	868	1037	647	647
query47	1862	1927	1822	1822
query48	420	413	307	307
query49	728	524	464	464
query50	698	750	432	432
query51	4292	4323	4306	4306
query52	107	114	101	101
query53	231	262	184	184
query54	489	488	421	421
query55	93	88	85	85
query56	278	283	269	269
query57	1160	1176	1100	1100
query58	254	248	238	238
query59	2779	2886	2595	2595
query60	299	271	284	271
query61	127	126	128	126
query62	729	734	684	684
query63	232	192	186	186
query64	1785	1031	678	678
query65	4514	4497	4389	4389
query66	700	385	289	289
query67	16341	15359	15358	15358
query68	7178	871	499	499
query69	538	298	253	253
query70	1197	1120	1056	1056
query71	453	289	264	264
query72	5745	3758	3734	3734
query73	1279	739	345	345
query74	8883	8989	8825	8825
query75	3199	3144	2742	2742
query76	3871	1188	754	754
query77	562	361	273	273
query78	10348	10181	9360	9360
query79	2632	836	593	593
query80	865	524	466	466
query81	534	258	224	224
query82	524	128	94	94
query83	208	175	152	152
query84	292	93	70	70
query85	847	355	305	305
query86	452	310	272	272
query87	4418	4560	4403	4403
query88	3655	2248	2222	2222
query89	397	328	281	281
query90	1661	211	212	211
query91	138	137	108	108
query92	75	62	59	59
query93	2629	1051	597	597
query94	720	422	346	346
query95	342	275	262	262
query96	484	571	274	274
query97	3343	3359	3288	3288
query98	236	201	211	201
query99	1336	1377	1317	1317
Total cold run time: 299239 ms
Total hot run time: 192183 ms

@doris-robot
Copy link

doris-robot commented Mar 20, 2025

ClickBench: Total hot run time: 31 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 55bce316aae2a26640d2b8eddb7540e901fa9cf7, data reload: false

query1	0.04	0.04	0.03
query2	0.11	0.10	0.10
query3	0.25	0.19	0.20
query4	1.58	0.18	0.19
query5	0.60	0.57	0.58
query6	1.20	0.72	0.72
query7	0.02	0.01	0.02
query8	0.03	0.03	0.03
query9	0.58	0.52	0.50
query10	0.58	0.60	0.57
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.61	0.60	0.60
query14	2.67	2.68	2.80
query15	0.92	0.87	0.86
query16	0.38	0.37	0.37
query17	1.02	1.03	1.04
query18	0.21	0.19	0.19
query19	1.90	1.90	1.97
query20	0.02	0.01	0.01
query21	15.38	0.90	0.55
query22	0.75	1.15	0.65
query23	14.97	1.38	0.60
query24	7.56	1.33	0.68
query25	0.49	0.33	0.12
query26	0.67	0.16	0.13
query27	0.05	0.06	0.05
query28	9.10	0.86	0.44
query29	12.54	4.03	3.33
query30	0.24	0.09	0.06
query31	2.82	0.59	0.38
query32	3.22	0.55	0.46
query33	3.06	2.97	3.03
query34	15.70	5.11	4.49
query35	4.51	4.57	4.55
query36	0.67	0.50	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.15	0.15	0.12
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.22 s
Total hot run time: 31 s

@doris-robot
Copy link

doris-robot commented Mar 20, 2025

BE UT Coverage Report

Increment line coverage 100.00% (42/42) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 48.80% (13070/26784)
Line Coverage 38.37% (112699/293699)
Region Coverage 37.17% (57295/154144)
Branch Coverage 32.27% (28800/89238)

HappenLee
HappenLee approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2025

PR approved by at least one committer and no changes requested.

@HappenLee HappenLee merged commit 20a925d into apache:master Mar 20, 2025
23 of 24 checks passed
Mryange added a commit to Mryange/doris that referenced this pull request Apr 2, 2025
@Mryange
[feature](function) upper lower support utf8 input (apache#49231)
9310ffb 
upper lower supports SQL similar to this
```
select lower('ÀÇ')
```
This was referenced Apr 2, 2025
Merged
Merged
@yiguolei yiguolei added usercase Important user case type label p0_w labels Apr 7, 2025
yiguolei pushed a commit that referenced this pull request Apr 7, 2025
@Mryange
[feature](function) upper lower support utf8 input (#49756)
aad189c 
### What problem does this PR solve?
#49231
dataroaring pushed a commit that referenced this pull request Apr 7, 2025
@Mryange
[feature](function) upper lower support utf8 input (#49763)
413552c 
#49231
@yiguolei yiguolei mentioned this pull request Apr 16, 2025
Closed
3 tasks
@yiguolei yiguolei mentioned this pull request May 13, 2025
Closed
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@Mryange @koarz
[feature](function) upper lower support utf8 input (apache#49231)
afb7073 
upper lower supports SQL similar to this
```
select lower('ÀÇ')
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.10-merged dev/3.0.5-merged p0_w reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Mryange @Thearas @doris-robot @hello-stephen @HappenLee @zclllyybb @yiguolei @dataroaring