Skip to content

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Apr 2, 2025

What problem does this PR solve?

#49231

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Apr 2, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Apr 2, 2025

run buildall

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (42/42) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 39.12% (10248/26194)
Line Coverage 30.47% (87389/286828)
Region Coverage 29.52% (44933/152219)
Branch Coverage 26.05% (22880/87846)

@Mryange Mryange marked this pull request as ready for review April 2, 2025 08:39
@Mryange Mryange requested a review from dataroaring as a code owner April 2, 2025 08:39
@Mryange Mryange force-pushed the branch-3.0-pick-49231 branch from 59cf0d4 to 3ed30ca Compare April 2, 2025 08:45
@Mryange
Copy link
Contributor Author

Mryange commented Apr 2, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40175 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3ed30cada948e20ae85d57b0a0df009d01d6dffe, data reload: false

------ Round 1 ----------------------------------
q1	17869	6921	6573	6573
q2	2062	171	177	171
q3	10741	1072	1182	1072
q4	10546	750	727	727
q5	7699	2890	2763	2763
q6	224	134	135	134
q7	972	632	612	612
q8	9358	1952	2028	1952
q9	6583	6397	6396	6396
q10	7046	2244	2313	2244
q11	465	264	269	264
q12	395	214	212	212
q13	17772	2995	3016	2995
q14	236	211	208	208
q15	506	464	468	464
q16	678	576	583	576
q17	983	516	548	516
q18	7181	6753	6658	6658
q19	1415	1105	1140	1105
q20	505	212	205	205
q21	4034	3342	3425	3342
q22	1103	994	986	986
Total cold run time: 108373 ms
Total hot run time: 40175 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6680	6582	6547	6547
q2	344	237	233	233
q3	2919	2700	2940	2700
q4	2047	1817	1816	1816
q5	5738	5743	5739	5739
q6	216	129	130	129
q7	2249	1808	1791	1791
q8	3429	3551	3497	3497
q9	8755	8839	8783	8783
q10	3600	3548	3522	3522
q11	597	492	506	492
q12	817	603	581	581
q13	10045	3149	3219	3149
q14	292	261	266	261
q15	522	460	458	458
q16	702	650	650	650
q17	1851	1658	1580	1580
q18	8244	7651	7903	7651
q19	1682	1581	1647	1581
q20	2070	1891	1918	1891
q21	5731	5312	5341	5312
q22	1090	1053	994	994
Total cold run time: 69620 ms
Total hot run time: 59357 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (42/42) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 39.13% (10249/26194)
Line Coverage 30.47% (87390/286823)
Region Coverage 29.52% (44933/152208)
Branch Coverage 26.05% (22883/87844)

@doris-robot
Copy link

TPC-DS: Total hot run time: 197499 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3ed30cada948e20ae85d57b0a0df009d01d6dffe, data reload: false

query1	1283	924	891	891
query2	6230	2100	2032	2032
query3	10829	4275	4278	4275
query4	60633	28491	23279	23279
query5	5217	477	474	474
query6	426	180	181	180
query7	5491	326	313	313
query8	311	228	239	228
query9	8528	2570	2571	2570
query10	438	261	257	257
query11	17918	15334	15831	15334
query12	161	103	101	101
query13	1415	457	444	444
query14	9921	7752	7561	7561
query15	209	185	187	185
query16	7014	485	447	447
query17	1177	605	608	605
query18	1802	327	321	321
query19	210	166	167	166
query20	126	110	110	110
query21	220	108	106	106
query22	4546	4411	4793	4411
query23	34726	33789	34148	33789
query24	6141	3013	2916	2916
query25	560	419	445	419
query26	666	178	173	173
query27	2007	381	358	358
query28	4375	2458	2407	2407
query29	719	465	457	457
query30	246	174	166	166
query31	1003	821	832	821
query32	69	54	56	54
query33	446	299	299	299
query34	911	520	537	520
query35	824	750	762	750
query36	1118	964	985	964
query37	122	71	68	68
query38	4198	4044	4052	4044
query39	1513	1471	1501	1471
query40	211	100	97	97
query41	53	48	46	46
query42	119	99	101	99
query43	528	481	497	481
query44	1190	827	820	820
query45	189	170	174	170
query46	1144	744	741	741
query47	1975	1910	1891	1891
query48	484	383	383	383
query49	729	389	392	389
query50	858	445	438	438
query51	7274	7174	7341	7174
query52	107	96	89	89
query53	259	196	189	189
query54	583	466	476	466
query55	79	80	78	78
query56	271	251	257	251
query57	1260	1129	1156	1129
query58	224	214	220	214
query59	3186	2996	2948	2948
query60	284	261	260	260
query61	113	111	111	111
query62	778	689	673	673
query63	224	191	188	188
query64	1383	682	671	671
query65	3275	3233	3247	3233
query66	720	305	306	305
query67	16007	15670	15566	15566
query68	4226	589	570	570
query69	433	271	261	261
query70	1135	1123	1091	1091
query71	357	263	275	263
query72	6338	4054	4038	4038
query73	742	358	352	352
query74	10607	8872	9236	8872
query75	3350	2684	2693	2684
query76	1970	1064	1181	1064
query77	489	272	269	269
query78	10421	9634	9498	9498
query79	1324	614	594	594
query80	809	452	432	432
query81	505	241	239	239
query82	415	90	88	88
query83	180	150	147	147
query84	279	89	81	81
query85	845	307	296	296
query86	313	295	302	295
query87	4378	4420	4274	4274
query88	3964	2422	2370	2370
query89	414	293	295	293
query90	2027	186	190	186
query91	180	145	153	145
query92	61	50	51	50
query93	1600	552	562	552
query94	743	273	286	273
query95	353	259	262	259
query96	612	285	284	284
query97	3356	3112	3157	3112
query98	214	205	195	195
query99	1591	1308	1306	1306
Total cold run time: 311487 ms
Total hot run time: 197499 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.31 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3ed30cada948e20ae85d57b0a0df009d01d6dffe, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.63	0.10	0.10
query5	0.53	0.51	0.49
query6	1.14	0.74	0.73
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.57	0.52	0.51
query10	0.55	0.55	0.54
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.61	0.61	0.59
query14	2.72	2.88	2.87
query15	0.91	0.84	0.83
query16	0.39	0.37	0.38
query17	0.99	1.00	1.07
query18	0.24	0.23	0.22
query19	1.89	1.75	2.02
query20	0.01	0.01	0.01
query21	15.35	0.59	0.58
query22	2.85	2.20	1.70
query23	17.25	0.82	0.74
query24	2.68	1.30	1.38
query25	0.20	0.06	0.04
query26	0.59	0.14	0.14
query27	0.05	0.05	0.05
query28	10.18	0.53	0.48
query29	12.57	3.28	3.26
query30	0.25	0.06	0.06
query31	2.87	0.37	0.38
query32	3.27	0.46	0.46
query33	2.98	2.98	3.06
query34	16.97	4.55	4.48
query35	4.53	4.49	4.53
query36	0.66	0.50	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.04	0.03	0.02
query40	0.16	0.12	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.61 s
Total hot run time: 32.31 s

@yiguolei yiguolei added the usercase Important user case type label label Apr 7, 2025
@Mryange
Copy link
Contributor Author

Mryange commented Apr 7, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39677 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3ed30cada948e20ae85d57b0a0df009d01d6dffe, data reload: false

------ Round 1 ----------------------------------
q1	17576	6731	6560	6560
q2	2067	177	173	173
q3	10574	1052	1243	1052
q4	10559	729	744	729
q5	7722	2844	2883	2844
q6	221	132	131	131
q7	984	614	610	610
q8	9393	1954	2027	1954
q9	6600	6366	6367	6366
q10	7012	2244	2285	2244
q11	468	266	270	266
q12	395	201	205	201
q13	17811	2985	2976	2976
q14	227	201	211	201
q15	489	464	470	464
q16	669	573	590	573
q17	985	544	527	527
q18	7204	6741	6613	6613
q19	1387	1049	957	957
q20	472	199	198	198
q21	3952	3073	3288	3073
q22	1069	965	971	965
Total cold run time: 107836 ms
Total hot run time: 39677 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6555	6556	6578	6556
q2	328	242	233	233
q3	2874	2749	2800	2749
q4	2049	1805	1788	1788
q5	5766	5749	5730	5730
q6	217	133	133	133
q7	2282	1824	1821	1821
q8	3337	3526	3529	3526
q9	8822	8888	8834	8834
q10	3570	3533	3527	3527
q11	578	492	493	492
q12	793	606	589	589
q13	5986	3181	3182	3181
q14	304	267	280	267
q15	513	473	469	469
q16	713	657	667	657
q17	1819	1626	1624	1624
q18	8207	7608	7820	7608
q19	1649	1617	1498	1498
q20	2069	1895	1881	1881
q21	5523	5388	5325	5325
q22	1106	1002	984	984
Total cold run time: 65060 ms
Total hot run time: 59472 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197125 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3ed30cada948e20ae85d57b0a0df009d01d6dffe, data reload: false

query1	1264	918	876	876
query2	6260	2036	2063	2036
query3	10808	4347	4288	4288
query4	60639	29248	23224	23224
query5	5221	461	440	440
query6	396	181	186	181
query7	5438	319	305	305
query8	309	226	227	226
query9	8474	2611	2592	2592
query10	466	275	257	257
query11	17761	15259	15747	15259
query12	157	99	98	98
query13	1422	459	424	424
query14	10830	7155	7484	7155
query15	201	174	185	174
query16	7229	481	507	481
query17	1190	571	585	571
query18	1879	318	319	318
query19	210	155	154	154
query20	118	120	115	115
query21	209	107	103	103
query22	4997	4831	4594	4594
query23	34525	34101	33642	33642
query24	6304	2902	3005	2902
query25	542	439	431	431
query26	665	169	175	169
query27	1840	351	369	351
query28	4078	2469	2436	2436
query29	705	456	448	448
query30	252	160	170	160
query31	1006	837	837	837
query32	66	56	57	56
query33	434	300	296	296
query34	896	500	512	500
query35	863	759	710	710
query36	1085	959	958	958
query37	119	70	71	70
query38	4103	3957	4024	3957
query39	1563	1465	1469	1465
query40	200	96	99	96
query41	58	48	49	48
query42	115	99	102	99
query43	529	477	486	477
query44	1139	810	834	810
query45	182	171	171	171
query46	1151	765	737	737
query47	1982	1937	1956	1937
query48	480	400	378	378
query49	763	385	393	385
query50	850	418	418	418
query51	7524	7356	7311	7311
query52	101	89	88	88
query53	266	194	185	185
query54	615	461	472	461
query55	78	77	79	77
query56	269	252	260	252
query57	1309	1188	1199	1188
query58	222	212	224	212
query59	3119	2867	2939	2867
query60	288	248	254	248
query61	133	106	115	106
query62	755	670	664	664
query63	217	192	182	182
query64	1402	670	654	654
query65	3265	3201	3224	3201
query66	701	297	292	292
query67	16017	15580	15609	15580
query68	4094	587	557	557
query69	436	265	258	258
query70	1146	1153	1126	1126
query71	337	259	259	259
query72	6340	4027	4090	4027
query73	751	353	363	353
query74	10608	9267	9044	9044
query75	3365	2654	2657	2654
query76	1977	1120	1116	1116
query77	494	275	276	275
query78	10701	9675	9716	9675
query79	1737	603	603	603
query80	1259	425	422	422
query81	534	236	242	236
query82	1309	88	88	88
query83	256	146	143	143
query84	282	80	80	80
query85	1002	305	288	288
query86	381	299	298	298
query87	4547	4231	4448	4231
query88	3845	2378	2362	2362
query89	419	288	294	288
query90	1999	184	176	176
query91	180	150	145	145
query92	61	58	50	50
query93	2060	552	547	547
query94	778	302	286	286
query95	359	251	260	251
query96	616	274	282	274
query97	3351	3151	3181	3151
query98	209	203	203	203
query99	1610	1291	1276	1276
Total cold run time: 315297 ms
Total hot run time: 197125 ms

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (42/42) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 39.25% (10282/26196)
Line Coverage 30.61% (87805/286895)
Region Coverage 29.66% (45164/152258)
Branch Coverage 26.15% (22984/87878)

@doris-robot
Copy link

ClickBench: Total hot run time: 32.61 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3ed30cada948e20ae85d57b0a0df009d01d6dffe, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.60	0.52	0.50
query6	1.14	0.72	0.72
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.52	0.50
query10	0.55	0.55	0.56
query11	0.14	0.10	0.11
query12	0.16	0.11	0.10
query13	0.60	0.59	0.59
query14	2.74	2.75	2.71
query15	0.90	0.83	0.83
query16	0.38	0.39	0.37
query17	1.06	1.07	1.02
query18	0.23	0.22	0.21
query19	1.86	1.78	2.01
query20	0.01	0.01	0.01
query21	15.37	0.59	0.58
query22	2.34	2.55	1.98
query23	16.91	1.16	1.08
query24	3.31	1.70	1.18
query25	0.17	0.18	0.10
query26	0.54	0.15	0.13
query27	0.05	0.04	0.04
query28	9.37	0.47	0.44
query29	12.63	3.25	3.28
query30	0.24	0.06	0.06
query31	2.86	0.38	0.37
query32	3.26	0.45	0.45
query33	3.00	3.04	3.05
query34	16.94	4.46	4.43
query35	4.53	4.50	4.45
query36	0.69	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.03
query40	0.17	0.12	0.12
query41	0.07	0.02	0.02
query42	0.04	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.64 s
Total hot run time: 32.61 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 413552c into apache:branch-3.0 Apr 7, 2025
20 of 21 checks passed
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants