Skip to content

[fix](nereids) proper planning of shadow columns for load and schema change concurrent execution #49332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Mar 21, 2025
Merged

[fix](nereids) proper planning of shadow columns for load and schema change concurrent execution #49332

dataroaring merged 1 commit into from
Mar 21, 2025

Conversation

@sollhui
Copy link
Contributor

@sollhui sollhui commented Mar 20, 2025 •
edited
Loading

What problem does this PR solve?

fix #49333

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@sollhui @starocean999
proper planning of shadow columns for load and schema change concurre…
ecb4bcc 
…nt execution

>
>

Co-authored-by: starocean999 <40539150+starocean999@users.noreply.github.com>
@sollhui sollhui force-pushed the load_plan_with_sc branch from f460687 to ecb4bcc Compare March 20, 2025 15:07
@sollhui
Copy link
Contributor Author

sollhui commented Mar 20, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2025

PR approved by anyone and no changes requested.

liaoxin01
liaoxin01 approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dataroaring
dataroaring approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 1f00a6c into apache:master Mar 21, 2025
34 of 35 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 21, 2025
@sollhui @starocean999
[fix](nereids) proper planning of shadow columns for load and schema …
42c6da0 
…change concurrent execution (#49332)

fix #49333

Co-authored-by: starocean999 <40539150+starocean999@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Mar 21, 2025
Merged
dataroaring pushed a commit that referenced this pull request Mar 22, 2025
@github-actions @sollhui @starocean999
branch-3.0: [fix](nereids) proper planning of shadow columns for load…
67de0c1 
… and schema change concurrent execution #49332 (#49338)

Cherry-picked from #49332

Co-authored-by: hui lai <laihui@selectdb.com>
Co-authored-by: starocean999 <40539150+starocean999@users.noreply.github.com>
sollhui added a commit to sollhui/doris that referenced this pull request May 8, 2025
@sollhui @starocean999
[fix](nereids) proper planning of shadow columns for load and schema …
7980ffa 
…change concurrent execution (apache#49332)

fix apache#49333

Co-authored-by: starocean999 <40539150+starocean999@users.noreply.github.com>
@sollhui sollhui mentioned this pull request May 8, 2025
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request May 9, 2025
@sollhui
branch-2.1: proper planning of shadow columns for load and schema cha…
0347e8a 
…nge concurrent execution (#49332) (#50710)
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@sollhui @starocean999 @koarz
[fix](nereids) proper planning of shadow columns for load and schema …
6e7b3c9 
…change concurrent execution (apache#49332)

fix apache#49333

Co-authored-by: starocean999 <40539150+starocean999@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liaoxin01 liaoxin01 liaoxin01 approved these changes

@starocean999 starocean999 starocean999 approved these changes

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.10-merged dev/3.0.5-merged p0_w reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] The result error when load and schema change concurrent execution

6 participants

@sollhui @Thearas @liaoxin01 @starocean999 @dataroaring @yiguolei