Skip to content

branch-3.0: [fix](lzo) fix lzo decompression failed #49538 #49633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions wants to merge 3 commits into from
Closed

branch-3.0: [fix](lzo) fix lzo decompression failed #49538 #49633

github-actions wants to merge 3 commits into from

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 28, 2025

Cherry-picked from #49538

@github-actions github-actions bot requested a review from dataroaring as a code owner March 28, 2025 08:02
@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 28, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 28, 2025

run buildall

dataroaring
dataroaring previously approved these changes Mar 30, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 30, 2025
@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 30, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 30, 2025

PR approved by anyone and no changes requested.

@morningman morningman force-pushed the auto-pick-49538-branch-3.0 branch from f3cf344 to 739481f Compare April 22, 2025 05:05
@morningman
Copy link
Contributor

morningman commented Apr 22, 2025

run buildall

@morningman
Copy link
Contributor

morningman commented Apr 22, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 22, 2025
@morningman
Copy link
Contributor

morningman commented Apr 22, 2025

run buildall

@morningman
[fix](lzo) fix lzo decompression failed (#49538)
974793d 
### What problem does this PR solve?

Problem Summary:

1.
If there is an empty block in lzo file, the decompress may fail:
`Lzo decompression failed: MalformedInputException at :13`

This is because if the next block's uncompressed size is 0,
we thought it is the last block, which is not right.

This PR fix it by removing the peek for the next block.

2.
Fix a bug that compressed size may be read wrong.
@morningman
2
36d7215
@morningman
2
f7ee06c
@morningman morningman force-pushed the auto-pick-49538-branch-3.0 branch from c52f55c to f7ee06c Compare April 23, 2025 05:42
@morningman morningman closed this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring left review comments

Assignees

No one assigned

Labels

reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hello-stephen @morningman @dataroaring