-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](lzo) fix lzo decompression failed #49538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34238 ms |
TPC-DS: Total hot run time: 186600 ms |
ClickBench: Total hot run time: 31.65 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
352a21a to
da7535f
Compare
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
1 similar comment
|
PR approved by anyone and no changes requested. |
|
run performance |
TPC-H: Total hot run time: 33959 ms |
TPC-DS: Total hot run time: 186901 ms |
ClickBench: Total hot run time: 30.77 s |
### What problem does this PR solve? Problem Summary: 1. If there is an empty block in lzo file, the decompress may fail: `Lzo decompression failed: MalformedInputException at :13` This is because if the next block's uncompressed size is 0, we thought it is the last block, which is not right. This PR fix it by removing the peek for the next block. 2. Fix a bug that compressed size may be read wrong.
### What problem does this PR solve? Problem Summary: 1. If there is an empty block in lzo file, the decompress may fail: `Lzo decompression failed: MalformedInputException at :13` This is because if the next block's uncompressed size is 0, we thought it is the last block, which is not right. This PR fix it by removing the peek for the next block. 2. Fix a bug that compressed size may be read wrong.
### What problem does this PR solve? Problem Summary: 1. If there is an empty block in lzo file, the decompress may fail: `Lzo decompression failed: MalformedInputException at :13` This is because if the next block's uncompressed size is 0, we thought it is the last block, which is not right. This PR fix it by removing the peek for the next block. 2. Fix a bug that compressed size may be read wrong.
### What problem does this PR solve? Problem Summary: 1. If there is an empty block in lzo file, the decompress may fail: `Lzo decompression failed: MalformedInputException at :13` This is because if the next block's uncompressed size is 0, we thought it is the last block, which is not right. This PR fix it by removing the peek for the next block. 2. Fix a bug that compressed size may be read wrong.
### What problem does this PR solve? Problem Summary: 1. If there is an empty block in lzo file, the decompress may fail: `Lzo decompression failed: MalformedInputException at :13` This is because if the next block's uncompressed size is 0, we thought it is the last block, which is not right. This PR fix it by removing the peek for the next block. 2. Fix a bug that compressed size may be read wrong.
### What problem does this PR solve? Problem Summary: 1. If there is an empty block in lzo file, the decompress may fail: `Lzo decompression failed: MalformedInputException at :13` This is because if the next block's uncompressed size is 0, we thought it is the last block, which is not right. This PR fix it by removing the peek for the next block. 2. Fix a bug that compressed size may be read wrong.
What problem does this PR solve?
Problem Summary:
If there is an empty block in lzo file, the decompress may fail:
Lzo decompression failed: MalformedInputException at :13This is because if the next block's uncompressed size is 0,
we thought it is the last block, which is not right.
This PR fix it by removing the peek for the next block.
Fix a bug that compressed size may be read wrong.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)