Skip to content

branch-3.0: [fix](lzo) fix lzo decompression failed (#49538) #50323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
Apr 24, 2025
Merged

branch-3.0: [fix](lzo) fix lzo decompression failed (#49538) #50323

dataroaring merged 2 commits into from
Apr 24, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Apr 23, 2025

bp #49538

@morningman
[fix](lzo) fix lzo decompression failed (apache#49538)
b4fb129 
### What problem does this PR solve?

Problem Summary:

1.
If there is an empty block in lzo file, the decompress may fail:
`Lzo decompression failed: MalformedInputException at :13`

This is because if the next block's uncompressed size is 0,
we thought it is the last block, which is not right.

This PR fix it by removing the peek for the next block.

2.
Fix a bug that compressed size may be read wrong.
@morningman morningman requested a review from dataroaring as a code owner April 23, 2025 05:43
@Thearas
Copy link
Contributor

Thearas commented Apr 23, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Apr 23, 2025

run buildall

@morningman
Copy link
Contributor Author

morningman commented Apr 23, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 23, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 40.22% (10558/26248)
Line Coverage 30.99% (89315/288214)
Region Coverage 30.12% (46074/152974)
Branch Coverage 26.63% (23552/88456)

@morningman morningman closed this Apr 23, 2025
@morningman morningman reopened this Apr 23, 2025
@morningman morningman changed the title [fix](lzo) fix lzo decompression failed (#49538) branch-3.0: [fix](lzo) fix lzo decompression failed (#49538) Apr 23, 2025
dataroaring
dataroaring approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 65a742b into apache:branch-3.0 Apr 24, 2025
30 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morningman @Thearas @doris-robot @dataroaring