Skip to content

branch-2.1: [fix](lzo) fix lzo decompression failed #49538 #49634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 2 commits into from
Apr 17, 2025
Merged

branch-2.1: [fix](lzo) fix lzo decompression failed #49538 #49634

yiguolei merged 2 commits into from
Apr 17, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 28, 2025

Cherry-picked from #49538

@morningman
[fix](lzo) fix lzo decompression failed (#49538)
5c55018 
### What problem does this PR solve?

Problem Summary:

1.
If there is an empty block in lzo file, the decompress may fail:
`Lzo decompression failed: MalformedInputException at :13`

This is because if the next block's uncompressed size is 0,
we thought it is the last block, which is not right.

This PR fix it by removing the peek for the next block.

2.
Fix a bug that compressed size may be read wrong.
@github-actions github-actions bot requested a review from yiguolei as a code owner March 28, 2025 08:03
@Thearas
Copy link
Contributor

Thearas commented Mar 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 28, 2025
@Thearas
Copy link
Contributor

Thearas commented Mar 28, 2025

run buildall

@morningman
Copy link
Contributor

morningman commented Apr 9, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 9, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.17% (10060/26353)
Line Coverage 29.20% (82894/283910)
Region Coverage 27.85% (42601/152943)
Branch Coverage 24.48% (21588/88200)

@yiguolei yiguolei merged commit 2aa9cb2 into branch-2.1 Apr 17, 2025
21 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49538-branch-2.1 branch April 17, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Thearas @morningman @hello-stephen @yiguolei @dataroaring