-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[chore] Fix unhandled exceptions thrown by stoi on streamload #49714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34366 ms |
TPC-DS: Total hot run time: 186841 ms |
ClickBench: Total hot run time: 31.57 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
48ee1c9 to
1e07626
Compare
|
run buildall |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 34332 ms |
TPC-DS: Total hot run time: 192641 ms |
ClickBench: Total hot run time: 29.88 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 33825 ms |
TPC-DS: Total hot run time: 191816 ms |
ClickBench: Total hot run time: 29.42 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 33995 ms |
TPC-DS: Total hot run time: 185434 ms |
ClickBench: Total hot run time: 28.9 s |
|
run buildall |
TPC-H: Total hot run time: 34195 ms |
TPC-DS: Total hot run time: 192436 ms |
ClickBench: Total hot run time: 29.31 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 33894 ms |
TPC-DS: Total hot run time: 192522 ms |
ClickBench: Total hot run time: 29.73 s |
BE Regression P0 && UT Coverage ReportIncrement line coverage Increment coverage report
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression P0 && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
BE Regression P0 && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
PR approved by at least one committer and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Problem Summary: fixes the issue where providing a timeout value exceeding the range of int32 causes a core dump during streamload. The root cause is that the timeout value parsed using std::stoi() can throw a std::out_of_range exception if the value exceeds int32 limits, which wasn't handled correctly. Co-authored-by: 宋光璠 <songguangfan@sf.com> Co-authored-by: morningman <yunyou@selectdb.com> Co-authored-by: morningman <morningman@163.com>
liaoxin01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…#49714) Problem Summary: fixes the issue where providing a timeout value exceeding the range of int32 causes a core dump during streamload. The root cause is that the timeout value parsed using std::stoi() can throw a std::out_of_range exception if the value exceeds int32 limits, which wasn't handled correctly. Co-authored-by: 宋光璠 <songguangfan@sf.com> Co-authored-by: morningman <yunyou@selectdb.com> Co-authored-by: morningman <morningman@163.com>
What problem does this PR solve?
Issue Number: close #48859
Related PR: #xxx
Problem Summary:
fixes the issue where providing a timeout value exceeding the range of int32 causes a core dump during streamload.
The root cause is that the timeout value parsed using std::stoi() can throw a std::out_of_range exception if the value exceeds int32 limits, which wasn't handled correctly.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)