Skip to content

Conversation

@Tech-Circle-48
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #48859

Related PR: #xxx

Problem Summary:
fixes the issue where providing a timeout value exceeding the range of int32 causes a core dump during streamload.

The root cause is that the timeout value parsed using std::stoi() can throw a std::out_of_range exception if the value exceeds int32 limits, which wasn't handled correctly.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 31, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Tech-Circle-48
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34366 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit db3f51196b1e05b8a8aa2c603ffaae5c9ba3c73b, data reload: false

------ Round 1 ----------------------------------
q1	26203	5082	5152	5082
q2	2101	278	182	182
q3	10399	1277	721	721
q4	10214	1001	528	528
q5	7570	2306	2402	2306
q6	188	164	134	134
q7	910	759	616	616
q8	9325	1315	1131	1131
q9	7036	5162	5168	5162
q10	6822	2316	1875	1875
q11	495	295	281	281
q12	350	353	224	224
q13	17767	3635	3097	3097
q14	236	245	220	220
q15	537	493	480	480
q16	641	617	576	576
q17	619	861	401	401
q18	7823	7260	7085	7085
q19	1226	958	565	565
q20	352	348	234	234
q21	4440	3570	2510	2510
q22	1029	1006	956	956
Total cold run time: 116283 ms
Total hot run time: 34366 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5185	5143	5103	5103
q2	234	331	229	229
q3	2166	2707	2278	2278
q4	1408	1851	1531	1531
q5	4514	4470	4372	4372
q6	209	162	124	124
q7	1950	1871	1744	1744
q8	2596	2489	2508	2489
q9	7199	7118	7188	7118
q10	2980	3134	2729	2729
q11	569	496	503	496
q12	705	777	616	616
q13	3498	3904	3275	3275
q14	274	284	293	284
q15	525	481	475	475
q16	640	702	656	656
q17	1157	1542	1363	1363
q18	7599	7586	7463	7463
q19	828	805	865	805
q20	1985	2026	1969	1969
q21	5217	4687	4697	4687
q22	1059	1019	978	978
Total cold run time: 52497 ms
Total hot run time: 50784 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186841 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit db3f51196b1e05b8a8aa2c603ffaae5c9ba3c73b, data reload: false

query1	1042	510	483	483
query2	6554	1971	1954	1954
query3	6778	226	230	226
query4	26385	23779	23119	23119
query5	4345	636	490	490
query6	340	212	211	211
query7	4622	493	302	302
query8	298	239	235	235
query9	8642	2596	2595	2595
query10	491	326	268	268
query11	15724	15115	14823	14823
query12	171	105	107	105
query13	1651	530	381	381
query14	9835	6196	6279	6196
query15	223	187	170	170
query16	7598	642	465	465
query17	1173	711	587	587
query18	1993	391	304	304
query19	198	188	155	155
query20	124	121	116	116
query21	216	122	104	104
query22	4055	4109	4229	4109
query23	33967	32952	32888	32888
query24	8323	2379	2378	2378
query25	530	458	394	394
query26	1227	278	153	153
query27	2726	498	321	321
query28	4390	2418	2389	2389
query29	709	553	458	458
query30	288	223	192	192
query31	945	861	742	742
query32	72	69	64	64
query33	576	376	315	315
query34	814	861	521	521
query35	821	822	736	736
query36	960	983	912	912
query37	131	100	77	77
query38	4256	4310	4248	4248
query39	1438	1397	1430	1397
query40	213	122	107	107
query41	59	56	56	56
query42	120	108	113	108
query43	511	520	488	488
query44	1337	794	802	794
query45	179	185	168	168
query46	864	1039	635	635
query47	1796	1782	1735	1735
query48	387	414	307	307
query49	758	508	415	415
query50	669	697	397	397
query51	4180	4151	4196	4151
query52	109	105	95	95
query53	238	268	186	186
query54	584	579	516	516
query55	85	81	82	81
query56	318	297	297	297
query57	1145	1151	1074	1074
query58	288	257	260	257
query59	2564	2790	2679	2679
query60	342	339	314	314
query61	157	153	150	150
query62	781	730	709	709
query63	232	200	199	199
query64	4322	1104	821	821
query65	4329	4264	4229	4229
query66	1081	428	334	334
query67	15749	15503	15323	15323
query68	7881	901	519	519
query69	469	316	263	263
query70	1217	1086	1114	1086
query71	473	314	295	295
query72	5681	4751	4895	4751
query73	749	676	348	348
query74	8887	8951	8788	8788
query75	3859	3188	2708	2708
query76	3706	1212	767	767
query77	780	383	297	297
query78	10105	10233	9244	9244
query79	2316	807	567	567
query80	619	506	429	429
query81	476	263	222	222
query82	451	129	99	99
query83	296	260	232	232
query84	299	113	89	89
query85	795	352	351	351
query86	354	336	307	307
query87	4472	4464	4320	4320
query88	3388	2264	2248	2248
query89	391	316	283	283
query90	1967	227	226	226
query91	147	146	121	121
query92	82	70	56	56
query93	1611	962	594	594
query94	682	444	304	304
query95	439	305	290	290
query96	491	575	275	275
query97	3229	3233	3107	3107
query98	233	203	214	203
query99	1462	1412	1244	1244
Total cold run time: 276035 ms
Total hot run time: 186841 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.57 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit db3f51196b1e05b8a8aa2c603ffaae5c9ba3c73b, data reload: false

query1	0.04	0.04	0.04
query2	0.13	0.10	0.10
query3	0.25	0.20	0.19
query4	1.58	0.20	0.20
query5	0.57	0.57	0.58
query6	1.22	0.72	0.71
query7	0.03	0.02	0.02
query8	0.04	0.03	0.04
query9	0.58	0.54	0.51
query10	0.59	0.60	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.60	0.60
query14	2.67	2.67	2.71
query15	0.92	0.85	0.86
query16	0.37	0.38	0.38
query17	1.00	1.06	1.03
query18	0.20	0.20	0.20
query19	1.93	1.95	1.85
query20	0.01	0.02	0.01
query21	15.38	0.90	0.56
query22	0.78	1.36	0.70
query23	14.75	1.40	0.64
query24	7.18	1.16	1.37
query25	0.46	0.26	0.11
query26	0.55	0.17	0.13
query27	0.05	0.05	0.05
query28	10.36	0.87	0.44
query29	12.54	3.99	3.31
query30	0.25	0.10	0.07
query31	2.82	0.58	0.39
query32	3.23	0.55	0.47
query33	3.04	3.04	3.10
query34	15.76	5.13	4.45
query35	4.56	4.50	4.50
query36	0.66	0.49	0.49
query37	0.08	0.06	0.07
query38	0.05	0.04	0.03
query39	0.02	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.02	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.02
Total cold run time: 105.91 s
Total hot run time: 31.57 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/28) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 51.33% (13736/26760)
Line Coverage 40.69% (119617/293960)
Region Coverage 39.42% (60941/154613)
Branch Coverage 34.22% (30588/89392)

@Tech-Circle-48 Tech-Circle-48 force-pushed the streamload-branch branch 2 times, most recently from 48ee1c9 to 1e07626 Compare April 2, 2025 10:18
@Tech-Circle-48
Copy link
Contributor Author

run buildall

dataroaring
dataroaring previously approved these changes Apr 16, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 16, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 34332 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 98a311f422af6193c9372edef9fc0903afaa4f1a, data reload: false

------ Round 1 ----------------------------------
q1	25965	5065	5144	5065
q2	2076	283	194	194
q3	10369	1278	700	700
q4	10223	1027	531	531
q5	7548	2414	2345	2345
q6	187	169	132	132
q7	947	738	627	627
q8	9310	1498	1159	1159
q9	6933	5210	5107	5107
q10	6823	2309	1894	1894
q11	470	291	268	268
q12	351	364	216	216
q13	17793	3642	3088	3088
q14	231	223	208	208
q15	525	496	482	482
q16	453	441	408	408
q17	614	872	365	365
q18	7635	7333	7261	7261
q19	1605	966	564	564
q20	325	334	223	223
q21	4095	3412	2502	2502
q22	1046	1036	993	993
Total cold run time: 115524 ms
Total hot run time: 34332 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5175	5118	5145	5118
q2	235	330	229	229
q3	2145	2669	2290	2290
q4	1431	1849	1517	1517
q5	4486	4446	4406	4406
q6	226	176	130	130
q7	2040	1911	1776	1776
q8	2612	2595	2544	2544
q9	7256	7238	7136	7136
q10	3008	3199	2716	2716
q11	568	515	484	484
q12	673	742	618	618
q13	3507	3983	3321	3321
q14	300	325	286	286
q15	525	473	473	473
q16	467	503	461	461
q17	1183	1540	1448	1448
q18	7711	7597	7404	7404
q19	834	854	837	837
q20	2040	1960	1827	1827
q21	5374	4787	4750	4750
q22	1132	1052	1004	1004
Total cold run time: 52928 ms
Total hot run time: 50775 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192641 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 98a311f422af6193c9372edef9fc0903afaa4f1a, data reload: false

query1	1419	1081	1066	1066
query2	6205	1820	1823	1820
query3	10992	4399	4403	4399
query4	52387	25192	22979	22979
query5	5021	592	459	459
query6	338	218	199	199
query7	4879	496	276	276
query8	296	245	226	226
query9	5421	2585	2598	2585
query10	430	315	268	268
query11	15232	15041	14799	14799
query12	156	113	107	107
query13	1038	517	409	409
query14	10175	6348	6370	6348
query15	216	204	169	169
query16	7047	659	483	483
query17	1075	745	594	594
query18	1517	395	307	307
query19	192	191	158	158
query20	127	126	127	126
query21	206	130	114	114
query22	4295	4499	4319	4319
query23	33833	33583	33280	33280
query24	6555	2451	2430	2430
query25	453	465	430	430
query26	678	285	159	159
query27	2306	513	346	346
query28	3054	2202	2179	2179
query29	589	578	425	425
query30	274	224	187	187
query31	864	848	786	786
query32	73	65	60	60
query33	449	355	312	312
query34	758	876	522	522
query35	811	874	755	755
query36	933	996	922	922
query37	122	99	79	79
query38	4303	4216	4233	4216
query39	1519	1461	1442	1442
query40	210	118	108	108
query41	58	59	54	54
query42	127	111	110	110
query43	498	529	493	493
query44	1301	811	806	806
query45	192	181	173	173
query46	866	1030	651	651
query47	1858	1866	1796	1796
query48	392	426	326	326
query49	679	511	430	430
query50	675	703	428	428
query51	4252	4279	4268	4268
query52	110	101	101	101
query53	236	263	186	186
query54	594	598	521	521
query55	83	81	81	81
query56	321	304	304	304
query57	1155	1247	1128	1128
query58	267	268	259	259
query59	2768	2852	2699	2699
query60	353	335	301	301
query61	131	130	127	127
query62	769	731	672	672
query63	235	195	188	188
query64	1473	1078	710	710
query65	4419	4427	4336	4336
query66	715	405	305	305
query67	15698	15340	15416	15340
query68	4370	898	523	523
query69	500	320	257	257
query70	1198	1067	1107	1067
query71	438	322	299	299
query72	5971	4722	4803	4722
query73	682	617	341	341
query74	9172	9094	8995	8995
query75	3175	3199	2708	2708
query76	3422	1204	769	769
query77	513	388	293	293
query78	9963	10065	9339	9339
query79	2073	822	574	574
query80	940	533	474	474
query81	502	262	214	214
query82	408	137	100	100
query83	329	258	248	248
query84	310	102	79	79
query85	754	353	303	303
query86	344	311	303	303
query87	4366	4484	4398	4398
query88	2803	2225	2225	2225
query89	395	310	295	295
query90	1595	204	210	204
query91	160	141	114	114
query92	67	60	54	54
query93	1829	955	592	592
query94	699	418	317	317
query95	370	293	345	293
query96	484	563	277	277
query97	3135	3240	3095	3095
query98	227	216	209	209
query99	1378	1420	1319	1319
Total cold run time: 289245 ms
Total hot run time: 192641 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.88 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 98a311f422af6193c9372edef9fc0903afaa4f1a, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.12	0.10
query3	0.25	0.19	0.19
query4	1.58	0.18	0.19
query5	0.60	0.57	0.59
query6	1.21	0.72	0.72
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.57	0.54	0.52
query10	0.56	0.58	0.57
query11	0.16	0.10	0.11
query12	0.14	0.11	0.11
query13	0.60	0.60	0.60
query14	1.18	1.26	1.19
query15	0.89	0.85	0.84
query16	0.39	0.38	0.38
query17	1.04	1.04	1.01
query18	0.21	0.19	0.20
query19	1.97	1.81	1.85
query20	0.01	0.01	0.01
query21	15.40	0.89	0.53
query22	0.75	1.14	0.74
query23	14.88	1.37	0.66
query24	6.92	2.26	0.91
query25	0.54	0.22	0.13
query26	0.58	0.16	0.13
query27	0.05	0.05	0.06
query28	9.83	0.85	0.42
query29	12.55	4.14	3.42
query30	0.24	0.09	0.06
query31	2.83	0.59	0.39
query32	3.22	0.55	0.47
query33	3.17	3.04	3.04
query34	15.79	5.08	4.49
query35	4.54	4.49	4.47
query36	0.66	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.03	0.02
query40	0.17	0.14	0.13
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 104.03 s
Total hot run time: 29.88 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/30) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.46% (14116/26908)
Line Coverage 41.37% (122402/295889)
Region Coverage 40.08% (62272/155379)
Branch Coverage 34.78% (31257/89872)

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 16, 2025
@Tech-Circle-48
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33825 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a066bdbf41c158884f32e87a9b8d4fed7a4f2646, data reload: false

------ Round 1 ----------------------------------
q1	25817	5218	4965	4965
q2	2063	272	174	174
q3	10411	1240	666	666
q4	10218	1006	517	517
q5	7542	2264	2319	2264
q6	182	162	130	130
q7	897	751	616	616
q8	9302	1197	1083	1083
q9	6868	5122	5106	5106
q10	6856	2297	1892	1892
q11	496	286	270	270
q12	351	345	216	216
q13	17782	3695	3078	3078
q14	224	218	209	209
q15	535	498	487	487
q16	440	449	419	419
q17	597	844	352	352
q18	7443	7211	7190	7190
q19	1677	963	549	549
q20	327	325	232	232
q21	4105	3337	2429	2429
q22	1043	1019	981	981
Total cold run time: 115176 ms
Total hot run time: 33825 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5169	5060	5056	5056
q2	229	328	226	226
q3	2134	2651	2282	2282
q4	1398	1795	1367	1367
q5	4400	4374	4387	4374
q6	220	172	124	124
q7	1966	1914	1734	1734
q8	2574	2531	2471	2471
q9	7401	7250	6969	6969
q10	3052	3181	2747	2747
q11	565	515	480	480
q12	681	742	628	628
q13	3527	3881	3293	3293
q14	282	307	288	288
q15	521	490	484	484
q16	474	511	459	459
q17	1113	1539	1397	1397
q18	7685	7557	7389	7389
q19	800	790	853	790
q20	1966	2010	1835	1835
q21	5137	4862	4798	4798
q22	1130	1076	1026	1026
Total cold run time: 52424 ms
Total hot run time: 50217 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191816 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a066bdbf41c158884f32e87a9b8d4fed7a4f2646, data reload: false

query1	1417	1074	1055	1055
query2	6369	1816	1819	1816
query3	11111	4608	4682	4608
query4	25449	23747	23174	23174
query5	4298	632	448	448
query6	307	220	187	187
query7	3993	483	280	280
query8	289	228	226	226
query9	8472	2537	2536	2536
query10	462	319	260	260
query11	15234	15178	14734	14734
query12	159	111	106	106
query13	1556	510	404	404
query14	8333	6034	5877	5877
query15	206	177	167	167
query16	7159	622	463	463
query17	1184	746	583	583
query18	1980	423	308	308
query19	203	184	161	161
query20	127	123	115	115
query21	208	127	112	112
query22	4596	4568	4467	4467
query23	34424	33681	33442	33442
query24	8435	2437	2451	2437
query25	535	456	392	392
query26	1212	265	145	145
query27	2991	493	337	337
query28	4672	2141	2110	2110
query29	748	565	467	467
query30	267	216	190	190
query31	877	834	778	778
query32	74	61	65	61
query33	544	351	316	316
query34	782	875	518	518
query35	811	870	770	770
query36	975	1008	914	914
query37	116	103	75	75
query38	4245	4262	4091	4091
query39	1498	1472	1442	1442
query40	221	126	115	115
query41	59	55	57	55
query42	119	106	110	106
query43	506	525	515	515
query44	1328	803	807	803
query45	178	173	162	162
query46	833	1008	637	637
query47	1823	1891	1856	1856
query48	383	420	308	308
query49	759	494	414	414
query50	651	685	413	413
query51	4260	4262	4232	4232
query52	108	106	106	106
query53	227	265	188	188
query54	587	580	520	520
query55	82	87	84	84
query56	299	299	300	299
query57	1195	1185	1107	1107
query58	250	263	253	253
query59	2787	2912	2719	2719
query60	333	321	317	317
query61	129	124	131	124
query62	787	738	657	657
query63	218	180	187	180
query64	4194	1087	691	691
query65	4405	4353	4391	4353
query66	1130	411	304	304
query67	16434	15342	15305	15305
query68	8413	883	511	511
query69	486	292	264	264
query70	1217	1133	1092	1092
query71	454	303	284	284
query72	5229	4638	4649	4638
query73	672	559	340	340
query74	9200	9074	8893	8893
query75	3815	3206	2654	2654
query76	3664	1171	736	736
query77	782	375	269	269
query78	9697	10039	9246	9246
query79	1760	801	550	550
query80	592	509	556	509
query81	466	256	217	217
query82	182	124	94	94
query83	271	254	227	227
query84	283	94	82	82
query85	739	344	304	304
query86	321	280	272	272
query87	4474	4444	4405	4405
query88	2730	2203	2138	2138
query89	387	312	279	279
query90	2077	207	202	202
query91	134	141	108	108
query92	72	57	54	54
query93	1107	932	579	579
query94	654	416	307	307
query95	365	290	282	282
query96	486	561	269	269
query97	3109	3215	3117	3117
query98	220	210	197	197
query99	1393	1375	1302	1302
Total cold run time: 276054 ms
Total hot run time: 191816 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.42 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a066bdbf41c158884f32e87a9b8d4fed7a4f2646, data reload: false

query1	0.03	0.04	0.03
query2	0.12	0.11	0.13
query3	0.25	0.19	0.19
query4	1.59	0.19	0.18
query5	0.60	0.60	0.60
query6	1.21	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.58	0.54	0.51
query10	0.57	0.56	0.57
query11	0.16	0.11	0.11
query12	0.14	0.12	0.11
query13	0.62	0.59	0.60
query14	1.15	1.21	1.17
query15	0.88	0.86	0.83
query16	0.37	0.39	0.38
query17	1.03	1.02	1.03
query18	0.20	0.19	0.20
query19	1.93	1.79	1.85
query20	0.01	0.01	0.01
query21	15.44	0.88	0.55
query22	0.75	1.17	0.62
query23	15.04	1.40	0.60
query24	7.18	1.64	0.56
query25	0.51	0.25	0.18
query26	0.64	0.16	0.15
query27	0.04	0.05	0.05
query28	9.08	0.90	0.44
query29	12.62	4.00	3.33
query30	0.24	0.09	0.07
query31	2.82	0.58	0.40
query32	3.22	0.53	0.49
query33	3.07	3.01	3.09
query34	15.69	5.12	4.51
query35	4.54	4.57	4.51
query36	0.67	0.48	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.04
query39	0.03	0.02	0.03
query40	0.18	0.14	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 103.55 s
Total hot run time: 29.42 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/30) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.82% (14221/26921)
Line Coverage 41.71% (123436/295917)
Region Coverage 40.45% (62869/155431)
Branch Coverage 35.07% (31531/89896)

@Tech-Circle-48
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33995 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ad3d337cf32bab5287ec6aa37329d70706746a93, data reload: false

------ Round 1 ----------------------------------
q1	25919	5014	5036	5014
q2	2073	290	187	187
q3	10374	1275	692	692
q4	10213	1012	559	559
q5	7553	2313	2399	2313
q6	184	163	130	130
q7	872	742	618	618
q8	9318	1256	1105	1105
q9	6732	5111	5134	5111
q10	6818	2306	1911	1911
q11	491	285	278	278
q12	348	349	221	221
q13	17759	3633	3109	3109
q14	222	221	206	206
q15	537	484	495	484
q16	455	449	416	416
q17	596	865	375	375
q18	7570	7297	7049	7049
q19	1212	951	547	547
q20	333	342	222	222
q21	4018	3408	2469	2469
q22	1047	1038	979	979
Total cold run time: 114644 ms
Total hot run time: 33995 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5115	5088	5075	5075
q2	235	323	234	234
q3	2183	2630	2236	2236
q4	1432	1827	1404	1404
q5	4524	4461	4381	4381
q6	209	168	126	126
q7	1928	1913	1728	1728
q8	2657	2445	2502	2445
q9	7113	7293	7101	7101
q10	2968	3223	2758	2758
q11	564	502	483	483
q12	694	779	644	644
q13	3472	4012	3244	3244
q14	295	319	271	271
q15	527	473	477	473
q16	474	489	448	448
q17	1190	1558	1372	1372
q18	7755	7527	7418	7418
q19	816	810	931	810
q20	1967	1974	1793	1793
q21	5072	4663	4721	4663
q22	1057	1031	997	997
Total cold run time: 52247 ms
Total hot run time: 50104 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185434 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ad3d337cf32bab5287ec6aa37329d70706746a93, data reload: false

query1	1010	470	504	470
query2	6562	1822	1862	1822
query3	6755	224	218	218
query4	26568	23641	23190	23190
query5	4262	605	451	451
query6	300	220	194	194
query7	4619	492	274	274
query8	287	232	214	214
query9	8590	2564	2572	2564
query10	477	338	252	252
query11	15845	15013	14795	14795
query12	155	106	102	102
query13	1637	491	395	395
query14	9250	6077	6055	6055
query15	200	183	168	168
query16	6851	583	486	486
query17	1168	715	559	559
query18	1852	371	327	327
query19	187	176	154	154
query20	116	114	113	113
query21	215	120	100	100
query22	4029	4199	4042	4042
query23	33709	32964	32998	32964
query24	8507	2372	2334	2334
query25	529	436	385	385
query26	1241	273	157	157
query27	2743	487	331	331
query28	4424	2079	2067	2067
query29	652	557	436	436
query30	278	215	187	187
query31	951	860	790	790
query32	76	66	64	64
query33	559	397	322	322
query34	789	861	506	506
query35	801	832	745	745
query36	964	991	879	879
query37	109	104	80	80
query38	4146	4191	4033	4033
query39	1458	1383	1388	1383
query40	215	134	111	111
query41	68	60	58	58
query42	128	110	108	108
query43	475	483	491	483
query44	1275	791	796	791
query45	183	175	175	175
query46	824	1022	631	631
query47	1776	1762	1732	1732
query48	386	423	309	309
query49	780	515	452	452
query50	639	727	395	395
query51	4134	4139	4076	4076
query52	111	112	102	102
query53	231	257	188	188
query54	573	566	505	505
query55	121	86	80	80
query56	287	305	296	296
query57	1119	1171	1092	1092
query58	259	251	264	251
query59	2583	2675	2625	2625
query60	326	305	288	288
query61	126	124	148	124
query62	809	721	724	721
query63	234	186	183	183
query64	4432	999	661	661
query65	4304	4241	4292	4241
query66	1149	410	301	301
query67	15711	15415	15388	15388
query68	8823	816	519	519
query69	465	296	272	272
query70	1214	1091	1063	1063
query71	450	322	294	294
query72	5124	4661	4664	4661
query73	691	556	332	332
query74	8890	9219	8833	8833
query75	4161	3164	2688	2688
query76	3656	1170	752	752
query77	797	373	285	285
query78	10018	10002	9274	9274
query79	2011	814	564	564
query80	568	504	427	427
query81	481	251	217	217
query82	472	126	96	96
query83	258	257	236	236
query84	249	109	89	89
query85	798	342	309	309
query86	385	301	295	295
query87	4366	4596	4316	4316
query88	3603	2219	2202	2202
query89	380	318	285	285
query90	1831	214	217	214
query91	142	148	113	113
query92	79	62	59	59
query93	1582	962	578	578
query94	664	415	322	322
query95	382	287	282	282
query96	482	568	276	276
query97	3135	3265	3119	3119
query98	245	213	204	204
query99	1406	1447	1283	1283
Total cold run time: 273937 ms
Total hot run time: 185434 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.9 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6a1662138a33247bcff3b3f434ce853f7c2ac327, data reload: false

query1	0.04	0.05	0.04
query2	0.13	0.11	0.11
query3	0.26	0.20	0.19
query4	1.59	0.20	0.11
query5	0.59	0.56	0.54
query6	1.18	0.71	0.72
query7	0.03	0.02	0.02
query8	0.04	0.03	0.04
query9	0.58	0.53	0.51
query10	0.57	0.57	0.58
query11	0.15	0.11	0.11
query12	0.15	0.11	0.12
query13	0.62	0.59	0.60
query14	1.20	1.16	1.19
query15	0.86	0.84	0.87
query16	0.38	0.38	0.38
query17	1.03	1.04	1.04
query18	0.21	0.20	0.19
query19	1.86	1.80	1.82
query20	0.01	0.01	0.01
query21	15.43	0.88	0.54
query22	0.75	1.20	0.74
query23	14.83	1.34	0.60
query24	6.82	1.31	0.37
query25	0.51	0.16	0.06
query26	0.68	0.16	0.14
query27	0.05	0.05	0.05
query28	9.03	0.90	0.43
query29	12.55	4.00	3.27
query30	0.25	0.08	0.06
query31	2.83	0.60	0.39
query32	3.22	0.55	0.48
query33	3.06	3.07	3.00
query34	15.85	5.05	4.46
query35	4.51	4.53	4.46
query36	0.67	0.49	0.49
query37	0.08	0.06	0.07
query38	0.05	0.05	0.03
query39	0.03	0.02	0.02
query40	0.16	0.14	0.13
query41	0.07	0.02	0.02
query42	0.03	0.03	0.02
query43	0.03	0.04	0.02
Total cold run time: 102.97 s
Total hot run time: 28.9 s

@morningman
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34195 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1dd04affc731e356b1a5a8ccd2c0034c8acf9925, data reload: false

------ Round 1 ----------------------------------
q1	26173	4977	4975	4975
q2	2065	296	186	186
q3	10386	1259	702	702
q4	10224	1024	583	583
q5	7536	2352	2370	2352
q6	181	164	130	130
q7	924	786	618	618
q8	9318	1343	1092	1092
q9	6838	5097	5125	5097
q10	6819	2296	1884	1884
q11	470	287	260	260
q12	358	370	228	228
q13	17783	3683	3216	3216
q14	218	227	222	222
q15	537	483	481	481
q16	439	451	400	400
q17	579	869	362	362
q18	7460	7243	7087	7087
q19	1607	964	609	609
q20	333	361	233	233
q21	4228	3398	2502	2502
q22	1049	1025	976	976
Total cold run time: 115525 ms
Total hot run time: 34195 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5136	5084	5066	5066
q2	234	333	231	231
q3	2153	2667	2230	2230
q4	1467	1823	1430	1430
q5	4486	4436	4432	4432
q6	212	170	127	127
q7	1987	1922	1759	1759
q8	2617	2447	2660	2447
q9	7214	7193	6931	6931
q10	2980	3201	2735	2735
q11	579	514	488	488
q12	672	748	609	609
q13	3518	3916	3256	3256
q14	291	285	272	272
q15	531	506	465	465
q16	478	495	452	452
q17	1169	1545	1421	1421
q18	7810	7494	7399	7399
q19	784	893	1082	893
q20	1961	2096	1857	1857
q21	5253	4953	4793	4793
q22	1079	1062	1038	1038
Total cold run time: 52611 ms
Total hot run time: 50331 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192436 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1dd04affc731e356b1a5a8ccd2c0034c8acf9925, data reload: false

query1	1445	1089	1041	1041
query2	6343	1810	1770	1770
query3	11025	4593	4424	4424
query4	53514	25483	23354	23354
query5	5277	481	473	473
query6	369	204	186	186
query7	5080	514	288	288
query8	331	266	254	254
query9	6511	2594	2612	2594
query10	430	330	271	271
query11	15141	15585	14931	14931
query12	161	113	108	108
query13	1145	526	399	399
query14	10213	6364	6360	6360
query15	211	192	200	192
query16	7081	665	492	492
query17	1102	734	630	630
query18	1533	389	316	316
query19	197	190	170	170
query20	126	122	124	122
query21	201	128	108	108
query22	4309	4450	4274	4274
query23	34215	33402	33364	33364
query24	6583	2443	2458	2443
query25	476	473	407	407
query26	655	279	153	153
query27	2179	517	336	336
query28	3042	2165	2158	2158
query29	568	575	432	432
query30	279	216	184	184
query31	852	889	768	768
query32	68	60	66	60
query33	449	401	329	329
query34	774	871	543	543
query35	788	834	755	755
query36	898	985	919	919
query37	119	106	80	80
query38	4250	4213	4068	4068
query39	1515	1450	1461	1450
query40	226	122	108	108
query41	55	54	90	54
query42	120	113	114	113
query43	504	512	484	484
query44	1345	818	850	818
query45	188	175	169	169
query46	874	1038	645	645
query47	1799	1831	1798	1798
query48	384	431	309	309
query49	688	526	433	433
query50	671	701	418	418
query51	4190	4286	4275	4275
query52	106	116	102	102
query53	228	267	189	189
query54	584	584	516	516
query55	80	84	85	84
query56	310	312	313	312
query57	1191	1194	1114	1114
query58	260	270	279	270
query59	2656	2710	2628	2628
query60	325	320	311	311
query61	153	124	128	124
query62	754	744	694	694
query63	224	206	200	200
query64	1497	1057	715	715
query65	4442	4344	4200	4200
query66	714	407	307	307
query67	15834	15600	15116	15116
query68	5402	903	524	524
query69	522	357	265	265
query70	1164	1104	1085	1085
query71	448	329	290	290
query72	5889	4920	4989	4920
query73	1091	730	356	356
query74	9248	9201	8744	8744
query75	3418	3196	2707	2707
query76	3788	1198	770	770
query77	549	358	278	278
query78	9895	10013	9152	9152
query79	1882	874	677	677
query80	820	511	439	439
query81	500	264	219	219
query82	396	131	97	97
query83	264	259	226	226
query84	290	105	85	85
query85	827	354	314	314
query86	407	311	288	288
query87	4399	4343	4342	4342
query88	2890	2231	2224	2224
query89	387	327	279	279
query90	1838	216	217	216
query91	145	146	114	114
query92	78	60	52	52
query93	2550	937	577	577
query94	681	418	312	312
query95	377	295	285	285
query96	492	578	277	277
query97	3129	3209	3120	3120
query98	222	215	208	208
query99	1360	1380	1282	1282
Total cold run time: 295205 ms
Total hot run time: 192436 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.31 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1dd04affc731e356b1a5a8ccd2c0034c8acf9925, data reload: false

query1	0.04	0.04	0.02
query2	0.13	0.10	0.12
query3	0.24	0.20	0.19
query4	1.60	0.19	0.19
query5	0.59	0.59	0.59
query6	1.19	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.56	0.53	0.50
query10	0.56	0.57	0.56
query11	0.15	0.11	0.11
query12	0.15	0.11	0.12
query13	0.61	0.60	0.60
query14	1.17	1.19	1.20
query15	0.88	0.84	0.85
query16	0.39	0.38	0.38
query17	1.03	1.01	1.04
query18	0.21	0.19	0.19
query19	1.86	1.77	1.75
query20	0.02	0.01	0.01
query21	15.39	0.89	0.54
query22	0.76	1.08	0.61
query23	15.13	1.39	0.63
query24	7.81	1.40	0.74
query25	0.47	0.20	0.11
query26	0.58	0.16	0.15
query27	0.05	0.06	0.04
query28	9.25	0.86	0.43
query29	12.54	3.90	3.26
query30	0.26	0.09	0.07
query31	2.84	0.62	0.38
query32	3.24	0.56	0.48
query33	3.04	3.07	3.10
query34	15.66	5.07	4.46
query35	4.47	4.54	4.47
query36	0.65	0.49	0.47
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.02	0.02	0.02
query40	0.16	0.14	0.12
query41	0.06	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 104.02 s
Total hot run time: 29.31 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/44) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.53% (14532/27147)
Line Coverage 42.35% (126024/297601)
Region Coverage 41.17% (64423/156485)
Branch Coverage 35.76% (32395/90588)

@Tech-Circle-48
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33894 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1dd04affc731e356b1a5a8ccd2c0034c8acf9925, data reload: false

------ Round 1 ----------------------------------
q1	26187	5085	4994	4994
q2	2062	274	183	183
q3	10588	1257	718	718
q4	10258	987	517	517
q5	8090	2450	2340	2340
q6	185	165	137	137
q7	922	752	620	620
q8	9324	1310	1104	1104
q9	6812	5070	5090	5070
q10	6849	2318	1882	1882
q11	484	285	266	266
q12	354	356	226	226
q13	17769	3732	3068	3068
q14	229	237	215	215
q15	529	487	472	472
q16	456	444	404	404
q17	590	860	355	355
q18	7666	7165	7140	7140
q19	2190	974	550	550
q20	322	330	214	214
q21	4001	2630	2422	2422
q22	1084	1035	997	997
Total cold run time: 116951 ms
Total hot run time: 33894 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5235	5069	5062	5062
q2	244	333	233	233
q3	2131	2629	2292	2292
q4	1412	1887	1442	1442
q5	4463	4429	4436	4429
q6	214	167	128	128
q7	1970	1958	1764	1764
q8	2605	2533	2543	2533
q9	7301	7207	7190	7190
q10	2997	3175	2785	2785
q11	566	498	502	498
q12	666	774	591	591
q13	3551	3962	3327	3327
q14	326	299	264	264
q15	519	477	469	469
q16	466	499	465	465
q17	1161	1592	1374	1374
q18	7755	7650	7495	7495
q19	815	769	940	769
q20	1973	1969	1846	1846
q21	5291	4914	4810	4810
q22	1115	1036	1040	1036
Total cold run time: 52776 ms
Total hot run time: 50802 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192522 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1dd04affc731e356b1a5a8ccd2c0034c8acf9925, data reload: false

query1	1424	1064	1064	1064
query2	6222	1802	1779	1779
query3	11165	4669	4588	4588
query4	53917	25544	23355	23355
query5	5007	544	462	462
query6	344	223	215	215
query7	4890	500	282	282
query8	307	254	236	236
query9	5439	2617	2607	2607
query10	425	325	278	278
query11	15074	14940	14981	14940
query12	160	119	102	102
query13	1032	486	365	365
query14	10224	6390	6302	6302
query15	216	208	180	180
query16	7112	671	457	457
query17	1060	732	548	548
query18	1577	406	328	328
query19	193	192	165	165
query20	130	139	130	130
query21	206	127	106	106
query22	4359	4624	4331	4331
query23	34064	33177	33500	33177
query24	6632	2418	2418	2418
query25	466	495	451	451
query26	692	287	157	157
query27	2159	519	345	345
query28	3075	2163	2143	2143
query29	611	592	482	482
query30	281	227	197	197
query31	871	904	788	788
query32	81	68	70	68
query33	464	383	342	342
query34	772	870	523	523
query35	839	833	759	759
query36	954	991	902	902
query37	120	105	80	80
query38	4287	4364	4225	4225
query39	1496	1420	1469	1420
query40	213	121	105	105
query41	59	53	88	53
query42	137	109	104	104
query43	498	524	481	481
query44	1294	804	799	799
query45	177	178	167	167
query46	853	1030	665	665
query47	1859	1863	1799	1799
query48	385	422	314	314
query49	661	507	423	423
query50	718	726	407	407
query51	4202	4181	4233	4181
query52	105	105	99	99
query53	242	263	184	184
query54	581	579	506	506
query55	87	85	81	81
query56	312	309	305	305
query57	1180	1189	1151	1151
query58	285	278	255	255
query59	2651	2779	2673	2673
query60	365	334	308	308
query61	131	143	135	135
query62	742	771	674	674
query63	232	184	184	184
query64	1894	1083	693	693
query65	4358	4226	4212	4212
query66	730	408	295	295
query67	16071	15803	15353	15353
query68	7557	893	525	525
query69	536	316	269	269
query70	1219	1137	1119	1119
query71	512	320	297	297
query72	5712	4746	4849	4746
query73	1466	639	355	355
query74	8910	9236	8706	8706
query75	3787	3184	2717	2717
query76	4274	1197	779	779
query77	618	374	288	288
query78	9951	10088	9199	9199
query79	2338	827	571	571
query80	622	530	438	438
query81	467	255	223	223
query82	419	128	97	97
query83	342	253	249	249
query84	359	113	100	100
query85	785	352	316	316
query86	360	279	290	279
query87	4438	4377	4394	4377
query88	3279	2239	2226	2226
query89	400	307	281	281
query90	1977	219	220	219
query91	149	140	118	118
query92	71	59	61	59
query93	1169	953	600	600
query94	676	408	289	289
query95	371	302	286	286
query96	511	567	270	270
query97	3191	3320	3135	3135
query98	238	222	209	209
query99	1435	1406	1277	1277
Total cold run time: 297508 ms
Total hot run time: 192522 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.73 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1dd04affc731e356b1a5a8ccd2c0034c8acf9925, data reload: false

query1	0.03	0.03	0.03
query2	0.12	0.11	0.12
query3	0.26	0.20	0.19
query4	1.62	0.20	0.19
query5	0.61	0.59	0.60
query6	1.18	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.03
query9	0.56	0.52	0.50
query10	0.58	0.57	0.56
query11	0.15	0.11	0.11
query12	0.15	0.11	0.12
query13	0.61	0.59	0.59
query14	1.19	1.23	1.17
query15	0.87	0.85	0.85
query16	0.39	0.39	0.37
query17	1.01	1.07	1.08
query18	0.21	0.19	0.20
query19	1.88	1.82	1.81
query20	0.02	0.01	0.01
query21	15.40	0.89	0.54
query22	0.74	1.19	0.78
query23	14.80	1.39	0.62
query24	7.95	1.03	0.73
query25	0.47	0.15	0.06
query26	0.61	0.16	0.13
query27	0.06	0.05	0.04
query28	9.08	0.86	0.43
query29	12.51	4.11	3.35
query30	0.26	0.09	0.06
query31	2.81	0.58	0.40
query32	3.22	0.56	0.47
query33	3.00	3.02	3.07
query34	15.85	5.14	4.52
query35	4.58	4.62	4.58
query36	0.66	0.50	0.47
query37	0.08	0.06	0.07
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.18	0.15	0.13
query41	0.07	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.99 s
Total hot run time: 29.73 s

@hello-stephen
Copy link
Contributor

BE Regression P0 && UT Coverage Report

Increment line coverage 0.00% (0/44) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage
Line Coverage
Region Coverage
Branch Coverage

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/44) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.59% (14548/27147)
Line Coverage 42.44% (126307/297601)
Region Coverage 41.23% (64517/156485)
Branch Coverage 35.83% (32456/90588)

@hello-stephen
Copy link
Contributor

BE Regression P0 && UT Coverage Report

Increment line coverage 0.00% (0/44) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage
Line Coverage
Region Coverage
Branch Coverage

1 similar comment
@hello-stephen
Copy link
Contributor

BE Regression P0 && UT Coverage Report

Increment line coverage 0.00% (0/44) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage
Line Coverage
Region Coverage
Branch Coverage

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 24, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 2178810 into apache:master Apr 25, 2025
25 of 26 checks passed
@dataroaring dataroaring added the usercase Important user case type label label Apr 25, 2025
github-actions bot pushed a commit that referenced this pull request Apr 25, 2025
Problem Summary:
fixes the issue where providing a timeout value exceeding the range of
int32 causes a core dump during streamload.

The root cause is that the timeout value parsed using std::stoi() can
throw a std::out_of_range exception if the value exceeds int32 limits,
which wasn't handled correctly.


Co-authored-by: 宋光璠 <songguangfan@sf.com>
Co-authored-by: morningman <yunyou@selectdb.com>
Co-authored-by: morningman <morningman@163.com>
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dataroaring pushed a commit that referenced this pull request Apr 27, 2025
…load #49714 (#50410)

Cherry-picked from #49714

Co-authored-by: 神技圈子 <songguangfan@gmail.com>
Co-authored-by: 宋光璠 <songguangfan@sf.com>
Co-authored-by: morningman <yunyou@selectdb.com>
Co-authored-by: morningman <morningman@163.com>
@shuke987 shuke987 removed the dev/2.1.x label May 7, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
…#49714)

Problem Summary:
fixes the issue where providing a timeout value exceeding the range of
int32 causes a core dump during streamload.

The root cause is that the timeout value parsed using std::stoi() can
throw a std::out_of_range exception if the value exceeds int32 limits,
which wasn't handled correctly.


Co-authored-by: 宋光璠 <songguangfan@sf.com>
Co-authored-by: morningman <yunyou@selectdb.com>
Co-authored-by: morningman <morningman@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.x-conflict dev/3.0.6-merged reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] be does not handle timeout out of range for streamload

8 participants