Skip to content

branch-3.0: [chore] Fix unhandled exceptions thrown by stoi on streamload #49714 #50410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Apr 27, 2025
Merged

branch-3.0: [chore] Fix unhandled exceptions thrown by stoi on streamload #49714 #50410

dataroaring merged 1 commit into from
Apr 27, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 25, 2025

Cherry-picked from #49714

@Tech-Circle-48 @morningman
[chore] Fix unhandled exceptions thrown by stoi on streamload (#49714)
6b266dd 
Problem Summary:
fixes the issue where providing a timeout value exceeding the range of
int32 causes a core dump during streamload.

The root cause is that the timeout value parsed using std::stoi() can
throw a std::out_of_range exception if the value exceeds int32 limits,
which wasn't handled correctly.


Co-authored-by: 宋光璠 <songguangfan@sf.com>
Co-authored-by: morningman <yunyou@selectdb.com>
Co-authored-by: morningman <morningman@163.com>
@github-actions github-actions bot requested a review from dataroaring as a code owner April 25, 2025 06:09
@Thearas
Copy link
Contributor

Thearas commented Apr 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Apr 25, 2025
@Thearas
Copy link
Contributor

Thearas commented Apr 25, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 25, 2025

TPC-H: Total hot run time: 40289 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6b266dd77128673de98b9cdb8b5e4447621e44fb, data reload: false

------ Round 1 ----------------------------------
q1	17587	6760	6616	6616
q2	2059	170	182	170
q3	10542	1075	1214	1075
q4	10420	730	709	709
q5	7749	2863	2821	2821
q6	224	132	130	130
q7	986	614	603	603
q8	9351	1983	2006	1983
q9	6644	6478	6385	6385
q10	7052	2280	2310	2280
q11	469	267	271	267
q12	421	221	211	211
q13	17783	2972	2974	2972
q14	243	204	216	204
q15	516	465	458	458
q16	686	603	600	600
q17	989	596	577	577
q18	7394	6820	6626	6626
q19	1439	1162	1094	1094
q20	469	206	211	206
q21	4252	3304	3342	3304
q22	1117	998	999	998
Total cold run time: 108392 ms
Total hot run time: 40289 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6596	6595	6568	6568
q2	333	233	228	228
q3	2874	2769	2920	2769
q4	2000	1789	1794	1789
q5	5742	5756	5756	5756
q6	215	127	126	126
q7	2198	1787	1835	1787
q8	3439	3600	3523	3523
q9	8879	8857	8913	8857
q10	3553	3513	3548	3513
q11	586	495	486	486
q12	791	592	625	592
q13	7990	3106	3162	3106
q14	294	278	272	272
q15	511	463	458	458
q16	706	647	674	647
q17	1843	1632	1618	1618
q18	8396	7747	7712	7712
q19	1767	1544	1546	1544
q20	2069	1810	1804	1804
q21	5539	5291	5231	5231
q22	1142	1056	1062	1056
Total cold run time: 67463 ms
Total hot run time: 59442 ms

@doris-robot
Copy link

doris-robot commented Apr 25, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/44) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 40.21% (10555/26248)
Line Coverage 30.98% (89305/288232)
Region Coverage 30.11% (46063/152993)
Branch Coverage 26.61% (23546/88470)

@doris-robot
Copy link

doris-robot commented Apr 25, 2025

TPC-DS: Total hot run time: 197861 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6b266dd77128673de98b9cdb8b5e4447621e44fb, data reload: false

query1	1285	902	902	902
query2	6271	1993	1986	1986
query3	10822	4316	4342	4316
query4	61602	28381	23846	23846
query5	5140	448	444	444
query6	414	172	164	164
query7	5509	308	317	308
query8	313	231	223	223
query9	8707	2626	2627	2626
query10	470	271	245	245
query11	17555	15567	15757	15567
query12	161	100	106	100
query13	1465	459	417	417
query14	10226	6697	7610	6697
query15	212	177	185	177
query16	7188	497	509	497
query17	1159	572	581	572
query18	1978	325	315	315
query19	211	175	161	161
query20	116	109	108	108
query21	206	104	106	104
query22	4732	4686	4538	4538
query23	34606	34319	34119	34119
query24	6133	2926	2888	2888
query25	510	402	398	398
query26	652	165	177	165
query27	2002	359	365	359
query28	4626	2469	2433	2433
query29	692	432	434	432
query30	246	158	160	158
query31	999	856	832	832
query32	68	53	56	53
query33	419	297	284	284
query34	927	512	509	509
query35	857	742	722	722
query36	1073	936	961	936
query37	116	67	67	67
query38	4092	3948	3980	3948
query39	1542	1477	1510	1477
query40	205	108	97	97
query41	52	48	49	48
query42	117	96	97	96
query43	542	490	492	490
query44	1215	817	838	817
query45	182	170	173	170
query46	1139	741	744	741
query47	2053	1935	1904	1904
query48	465	400	391	391
query49	735	393	403	393
query50	862	424	439	424
query51	7340	7255	7097	7097
query52	103	86	88	86
query53	268	198	178	178
query54	584	460	467	460
query55	78	76	74	74
query56	254	240	246	240
query57	1277	1205	1156	1156
query58	220	207	220	207
query59	3209	3140	3080	3080
query60	280	252	253	252
query61	112	117	112	112
query62	796	687	706	687
query63	219	194	189	189
query64	1439	690	638	638
query65	3247	3172	3188	3172
query66	690	296	302	296
query67	15906	15585	15546	15546
query68	4302	581	572	572
query69	430	269	284	269
query70	1181	1089	1104	1089
query71	348	263	264	263
query72	6397	4088	4108	4088
query73	758	353	353	353
query74	10284	9209	9298	9209
query75	3363	2625	2662	2625
query76	1897	1149	1029	1029
query77	530	273	272	272
query78	10520	9728	9603	9603
query79	1571	597	589	589
query80	870	439	428	428
query81	515	239	239	239
query82	1223	88	83	83
query83	250	159	144	144
query84	285	83	75	75
query85	904	290	287	287
query86	330	277	305	277
query87	4383	4203	4212	4203
query88	3691	2408	2384	2384
query89	425	290	295	290
query90	1981	183	184	183
query91	182	150	147	147
query92	67	51	48	48
query93	1876	557	552	552
query94	763	293	306	293
query95	352	263	255	255
query96	607	274	273	273
query97	3295	3105	3165	3105
query98	216	204	200	200
query99	1636	1300	1312	1300
Total cold run time: 314323 ms
Total hot run time: 197861 ms

@doris-robot
Copy link

doris-robot commented Apr 25, 2025

ClickBench: Total hot run time: 32.62 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6b266dd77128673de98b9cdb8b5e4447621e44fb, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.04
query3	0.23	0.07	0.07
query4	1.63	0.11	0.11
query5	0.52	0.50	0.50
query6	1.13	0.72	0.73
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.56	0.51	0.49
query10	0.55	0.54	0.54
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.59
query14	2.74	2.73	2.82
query15	0.91	0.82	0.83
query16	0.38	0.40	0.39
query17	1.04	1.04	1.08
query18	0.25	0.23	0.22
query19	1.96	1.90	2.00
query20	0.01	0.02	0.01
query21	15.36	0.59	0.59
query22	2.36	2.35	1.88
query23	16.95	1.01	0.92
query24	2.99	1.16	2.00
query25	0.33	0.10	0.05
query26	0.43	0.14	0.14
query27	0.04	0.04	0.04
query28	9.41	0.52	0.49
query29	12.59	3.27	3.27
query30	0.24	0.06	0.06
query31	2.84	0.38	0.39
query32	3.26	0.46	0.45
query33	2.98	3.02	3.03
query34	16.99	4.48	4.46
query35	4.54	4.47	4.55
query36	0.67	0.49	0.48
query37	0.08	0.06	0.06
query38	0.05	0.03	0.04
query39	0.04	0.03	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.43 s
Total hot run time: 32.62 s

dataroaring
dataroaring approved these changes Apr 27, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 0fdf872 into branch-3.0 Apr 27, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49714-branch-3.0 branch April 27, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thearas @doris-robot @dataroaring @Tech-Circle-48