Skip to content

branch-2.1: [fix](function) check return type is nullptr in FunctionBasePtr::build #49737 #49759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions wants to merge 1 commit into from
Closed

branch-2.1: [fix](function) check return type is nullptr in FunctionBasePtr::build #49737 #49759

github-actions wants to merge 1 commit into from

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 2, 2025

Cherry-picked from #49737

@Mryange
[fix](function) check return type is nullptr in FunctionBasePtr::build (
8da12f3 
#49737)

### What problem does this PR solve?

Some functions' implementations return a nullptr in case of an error,
which can directly cause a core dump.
@github-actions github-actions bot requested a review from yiguolei as a code owner April 2, 2025 03:24
@Thearas
Copy link
Contributor

Thearas commented Apr 2, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Apr 2, 2025
@dataroaring dataroaring reopened this Apr 2, 2025
@Thearas
Copy link
Contributor

Thearas commented Apr 2, 2025

run buildall

@yiguolei yiguolei closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei Awaiting requested review from yiguolei yiguolei is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @yiguolei @dataroaring @Mryange